[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2022-03-23 Thread Fahad Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=385694

--- Comment #10 from Fahad Al-Saidi  ---
thanks @Waqar for fixing RTL bugs in kate.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2022-03-22 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=385694

Waqar Ahmed  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/ktexteditor/commit/d
   ||c7d5b99a7691327d0da97e17906
   ||c9bba4e35371
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Waqar Ahmed  ---
Git commit dc7d5b99a7691327d0da97e17906c9bba4e35371 by Waqar Ahmed.
Committed on 22/03/2022 at 15:11.
Pushed by cullmann into branch 'master'.

Fix cursor in RTL text with dyn wrap on

Also fix the issue that the cursor is not visible in column 0.
Related: bug 368182

M  +11   -0src/render/katerenderer.cpp

https://invent.kde.org/frameworks/ktexteditor/commit/dc7d5b99a7691327d0da97e17906c9bba4e35371

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2022-03-22 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=385694

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/342

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-12-14 Thread Safa Alfulaij
https://bugs.kde.org/show_bug.cgi?id=385694

Safa Alfulaij  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #7 from Safa Alfulaij  ---
Related bug: https://bugs.kde.org/show_bug.cgi?id=368182
Related Qt bugs:
https://bugreports.qt.io/browse/QTBUG-71489
https://bugreports.qt.io/browse/QTBUG-55929
https://bugreports.qt.io/browse/QTBUG-65508

Related task: https://phabricator.kde.org/T10863

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-12-14 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=385694

Christoph Cullmann  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #6 from Christoph Cullmann  ---
*** Bug 367722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-12-14 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=385694

Waqar Ahmed  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #5 from Waqar Ahmed  ---
This bug happens because of how text is wrapped dynamically and it is easier to
understand it if you turn on "Show spaces".

Consider the following sentence:

This is a sentence.

Assume this sentence reached the view width, and now I enter a space character.
The line will not wrap, and the space will be added to the end of the sentence,
outside the border. 
   |
This is a sentence.| [space][space]
   |

This is all good, now lets see what happens when the text is RTL:

X .Some RTL Text

Assume "X" is the position of the cursor, and now I enter a space. The space is
added to the sentence correctly, and the sentence is not wrapped as expected.
However, Instead of increasing the cursor position on the left border, it is
done on the right border like LTR text. The result is something like this
(assume two spaces added):

|
X [space][space].Some RTL Te| xt
|

The above is what "actually" happens. If "Show spaces" is turned on, it can be
seen directly. The text is painted according to the expectation, however the
cursor is pointing to the wrong position.

In the above case, if I try to delete a character, the character that will get
deleted will be the one that is two positions forward(because of two spaces).

I have tried to figure out where exactly this is handled but i have been
unsuccessful so far. This can be a bug in Qt even, but I am not sure about it
completely. Can any Kate Dev drop some hints?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-11-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=385694

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #4 from Christoph Feck  ---
Thanks for the update; changing status.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-11-01 Thread Fahad Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=385694

--- Comment #3 from Fahad Al-Saidi  ---
Created attachment 132956
  --> https://bugs.kde.org/attachment.cgi?id=132956&action=edit
the problem

this screen recording about the problem. notice that put the cursor after "لا"
then I hit backspace the letter "م" deleted!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-11-01 Thread Fahad Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=385694

--- Comment #2 from Fahad Al-Saidi  ---
(In reply to Justin Zobel from comment #1)
> Fahad I've just tried this on kate from git master and deleting letters from
> words in the text you provided works as I would expect.
> 
> Can you please confirm if this issue is still present for you.

NO the bug still there. I check it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2020-10-29 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=385694

Justin Zobel  changed:

   What|Removed |Added

 CC||[email protected]
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Justin Zobel  ---
Fahad I've just tried this on kate from git master and deleting letters from
words in the text you provided works as I would expect.

Can you please confirm if this issue is still present for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 385694] Backspace deletes the wrong character in Arabic text

2017-10-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=385694

Christoph Feck  changed:

   What|Removed |Added

   Keywords||rtl

-- 
You are receiving this mail because:
You are watching all bug changes.