[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added Latest Commit|https://cgit.kde.org/konsol |https://invent.kde.org/kde/ |e.git/commit/?id=bbdf27cc9f |kate/commit/4fec9bf8a8283bf |ee4cf40e7f2551769445b2146ec |d00d15707aa1615f438f9ab05 |20c | Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In|19.12 |20.04.0 --- Comment #12 from Nate Graham --- Git commit 4fec9bf8a8283bfd00d15707aa1615f438f9ab05 by Nate Graham. Committed on 08/12/2019 at 16:50. Pushed by ngraham into branch 'master'. Open/close and focus/defocus terminal using the same shortcuts as Dolphin Summary: Users have complained that Kate's terminal doesn't use the same shortcut as Dolphin to open and close. This patch makes it do so, using the same shortcuts that dolphin uses to both open/close and also focus/de-focus: F4: Open/close Ctrl+Shift+F4: Focus/de-focus (also open if currently closed) FIXED-IN: 20.04.0 Closes T12318 Test Plan: Hit F4 twice -> terminal opens and closes Hit Ctrl+Shift+F4 twice -> terminal focuses and de-focuses Reviewers: #kate, cullmann Reviewed By: #kate, cullmann Subscribers: cullmann, kwrite-devel Tags: #kate Maniphest Tasks: T12318 Differential Revision: https://phabricator.kde.org/D25805 M +20 -2addons/konsole/kateconsole.cpp M +5-0addons/konsole/kateconsole.h M +3-2addons/konsole/ui.rc https://invent.kde.org/kde/kate/commit/4fec9bf8a8283bfd00d15707aa1615f438f9ab05 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kat |kate/commit/4fec9bf8a8283bf |e/4fec9bf8a8283bfd00d15707a |d00d15707aa1615f438f9ab05 |a1615f438f9ab05 --- Comment #13 from Nate Graham --- Git commit 4fec9bf8a8283bfd00d15707aa1615f438f9ab05 by Nate Graham. Committed on 08/12/2019 at 16:50. Pushed by scmsync into branch 'master'. Open/close and focus/defocus terminal using the same shortcuts as Dolphin Summary: Users have complained that Kate's terminal doesn't use the same shortcut as Dolphin to open and close. This patch makes it do so, using the same shortcuts that dolphin uses to both open/close and also focus/de-focus: F4: Open/close Ctrl+Shift+F4: Focus/de-focus (also open if currently closed) FIXED-IN: 20.04.0 Closes T12318 Test Plan: Hit F4 twice -> terminal opens and closes Hit Ctrl+Shift+F4 twice -> terminal focuses and de-focuses Reviewers: #kate, cullmann Reviewed By: #kate, cullmann Subscribers: cullmann, kwrite-devel Tags: #kate Maniphest Tasks: T12318 Differential Revision: https://phabricator.kde.org/D25805 M +20 -2addons/konsole/kateconsole.cpp M +5-0addons/konsole/kateconsole.h M +3-2addons/konsole/ui.rc https://commits.kde.org/kate/4fec9bf8a8283bfd00d15707aa1615f438f9ab05 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #11 from Nate Graham --- Will be fixed with https://phabricator.kde.org/D25805 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added Assignee|kwrite-bugs-n...@kde.org|n...@kde.org Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #10 from Postix --- (In reply to Postix from comment #8) > > Can you open a Phabricator Task about this and tag Dolphin and Kate? > > I can surely do that. Maybe tomorrow I will look into it. Nate, an apology for changing my mind, but can you please do it for me? Due to lack of time*, I don't think I can adequately supervise this task. *reporting bugs already takes a lot of my little spare time. :) -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #9 from Matthias --- I doubt that long-time Dolphin users would get excited when you change their beloved Dolphin shortcuts. Why not simply go the easy way and add that obvious shortcut to Kate? Where is the downside? -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #8 from Postix --- > Can you open a Phabricator Task about this and tag Dolphin and Kate? I can surely do that. Maybe tomorrow I will look into it. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Postix changed: What|Removed |Added Version Fixed In||19.12 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #7 from Nate Graham --- It's a good point that the two apps are inconsistent: Dolphin has no keyboard method to focus/de-focus an open terminal panel, while Kate has no keyboard method to close an open terminal panel. We should fix that. Can you open a Phabricator Task about this and tag Dolphin and Kate? It would make more sense to discuss it there than in a bunch of disjointed bug reports. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Postix changed: What|Removed |Added Resolution|FIXED |WAITINGFORINFO Latest Commit||https://cgit.kde.org/konsol ||e.git/commit/?id=bbdf27cc9f ||ee4cf40e7f2551769445b2146ec ||20c -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #6 from Postix --- (Sorry for a second post, I would really like to just edit my old one ...) I come from Vim, and I find it handy to only use the keyboard, that's why I also like to take and give the focus (in practical show or hide) from or to the terminal just by a hotkey without any mouse movement. ;-) -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #5 from Postix --- > Can you verify that the above is working properly once you have Konsole 19.12 > or from git master? I'll do that! However, I wonder why you prefer such inconsistency with Dolphin? Why not not a different shortcut to take the focus away? Or maybe I will have to get used to Yuakake instead, where I can both show and hide it F12. Having the terminal displayed all the time just takes too much space away, if it's not needed. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED Status|NEEDSINFO |RESOLVED --- Comment #4 from Nate Graham --- (In reply to Postix from comment #3) > Currently F4 opens it only for me, but does not close it again as in Dolphin. > I have not enabled anything special, at least not intentionally. This is actually intentional in Kate. F4 opens the Konsole panel and thereafter, switches focus between the Konsole panel and the main text editing view. > Under "Extra" there's a context menu entry saying "Take the focus from the > terminal (F4)" but it does not nothing if I press it and the terminal was > focused. This is fixed in Konsole 19.12 by https://cgit.kde.org/konsole.git/commit/?id=bbdf27cc9fee4cf40e7f2551769445b2146ec20c Can you verify that the above is working properly once you have Konsole 19.12 or from git master? -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 --- Comment #3 from Postix --- (In reply to Matthias from comment #1) > Currently, F4 closes the Terminal. It does not open it again (...) (In reply to Nate Graham from comment #2) > For me, F4 already does show the terminal view just like in Dolphin. What am > I missing? Do you have the "Terminal Tool View" plugin enabled? Currently F4 opens it only for me, but does not close it again as in Dolphin. I have not enabled anything special, at least not intentionally. Under "Extra" there's a context menu entry saying "Take the focus from the terminal (F4)" but it does not nothing if I press it and the terminal was focused. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Nate Graham changed: What|Removed |Added CC||n...@kde.org Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Nate Graham --- For me, F4 already does show the terminal view just like in Dolphin. What am I missing? Do you have the "Terminal Tool View" plugin enabled? -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Matthias changed: What|Removed |Added CC||shaloksha...@protonmail.ch --- Comment #1 from Matthias --- Currently, F4 closes the Terminal. It does not open it again, a simple fix in the shortcuts dialog does fix this. I also recommend setting this to the default setting, due to consistency. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 414587] Set F4 shortcut to open the terminal in Kate like in Dolphin
https://bugs.kde.org/show_bug.cgi?id=414587 Postix changed: What|Removed |Added CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
