[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-12-31 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=490926

Waqar Ahmed  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/kate/-/commit/51097a6 |ities/kate/-/commit/6956d8d
   |72e627d776298b06e558104fb12 |ee9d5fc9ac1ebe1221cc0e9f207
   |24682e  |35c446

--- Comment #14 from Waqar Ahmed  ---
Git commit 6956d8dee9d5fc9ac1ebe1221cc0e9f20735c446 by Waqar Ahmed.
Committed on 31/12/2024 at 17:57.
Pushed by waqar into branch 'master'.

Allow the user to add paths to PATH var

Kate relies heavily on external executables for a lot of functionality
for e.g., LSP servers, formatters, linters, git etc. However, we dont
provide any way to the user to provide a path where these programs can
be found. As such the user has only 1 way to fix this which is to modify
some global file and ensure the PATH is set there.

On linux, things are messy in general so it kind of works sometimes. On
windows you can change your PATH variable in settings. On mac, you can
sort of edit /etc/paths. The problem with these approaches is that it
forces the user to change things globally even if this functionality is
only required by Kate on the whole system.

This patch introduces a way to prepend paths to the existing PATH env
var.

M  +61   -1apps/lib/autotests/basic_ui_tests.cpp
M  +9-0apps/lib/kateapp.cpp
M  +63   -0apps/lib/kateconfigdialog.cpp
M  +1-0apps/lib/kateconfigdialog.h
M  +3-0apps/lib/katemainwindow.cpp

https://invent.kde.org/utilities/kate/-/commit/6956d8dee9d5fc9ac1ebe1221cc0e9f20735c446

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-12-31 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=490926

Waqar Ahmed  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/kate/-/commit/233b944 |ities/kate/-/commit/51097a6
   |beb71720c0268abd726799c8126 |72e627d776298b06e558104fb12
   |feb05f  |24682e

--- Comment #13 from Waqar Ahmed  ---
Git commit 51097a672e627d776298b06e558104fb1224682e by Waqar Ahmed.
Committed on 31/12/2024 at 07:43.
Pushed by waqar into branch 'master'.

Use path_helper utility on macos for setting PATH

The old code builds a very basic path that excludes a lot of stuff like
per user paths.

M  +16   -10   apps/lib/kateapp.cpp

https://invent.kde.org/utilities/kate/-/commit/51097a672e627d776298b06e558104fb1224682e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-17 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=490926

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Version Fixed In||24.12
  Latest Commit||https://invent.kde.org/util
   ||ities/kate/-/commit/233b944
   ||beb71720c0268abd726799c8126
   ||feb05f

--- Comment #12 from Christoph Cullmann  ---
Should be fixed with 24.12

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-17 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #11 from Christoph Cullmann  ---
Git commit 233b944beb71720c0268abd726799c8126feb05f by Christoph Cullmann.
Committed on 17/11/2024 at 12:02.
Pushed by cullmann into branch 'release/24.12'.

Try to have a PATH on macos when not launched from terminal


(cherry picked from commit 7fccdf6e5085d1e90295c37ca7cb679463071aa9)

Co-authored-by: Waqar Ahmed 

M  +19   -0apps/lib/kateapp.cpp

https://invent.kde.org/utilities/kate/-/commit/233b944beb71720c0268abd726799c8126feb05f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-17 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #10 from Christoph Cullmann  ---
Git commit 7fccdf6e5085d1e90295c37ca7cb679463071aa9 by Christoph Cullmann, on
behalf of Waqar Ahmed.
Committed on 17/11/2024 at 11:56.
Pushed by cullmann into branch 'master'.

Try to have a PATH on macos when not launched from terminal

M  +19   -0apps/lib/kateapp.cpp

https://invent.kde.org/utilities/kate/-/commit/7fccdf6e5085d1e90295c37ca7cb679463071aa9

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #9 from Christoph Cullmann  ---
I triggered a new build, perhaps other stuff was damaged there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #8 from Lassi Väätämöinen  ---
(In reply to Waqar Ahmed from comment #4)
> @Lassi Väätämöinen can you test:
> https://invent.kde.org/utilities/kate/-/merge_requests/1621 ?

Downloaded: https://invent.kde.org/utilities/kate/-/jobs/2286643

I was only able to start Kate off the command line. Starting from the GUI I
only got a popup "kate is damaged and can't be opened. You should move it to
Bin"

So with this build I cannot try to verify if the reported issue is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #5 from Lassi Väätämöinen  ---
(In reply to Waqar Ahmed from comment #4)
> @Lassi Väätämöinen can you test:
> https://invent.kde.org/utilities/kate/-/merge_requests/1621 ?

I haven't been able to make MacOS builds happen. Is there some CI build that
can be done?

I know we have nightly builds, but those are off 'master' branch, I guess?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

Lassi Väätämöinen  changed:

   What|Removed |Added

   Assignee|me.waqas.ah...@gmail.com|w.ahme...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

Lassi Väätämöinen  changed:

   What|Removed |Added

   Assignee|kwrite-bugs-n...@kde.org|me.waqas.ah...@gmail.com
 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

Lassi Väätämöinen  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #7 from Lassi Väätämöinen  ---
Ok, nice. I hope I'll have time to try it tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #6 from Waqar Ahmed  ---
It can be triggered manually on the MR. I just triggered them so hopefully new
binaries will appear soon

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-11-14 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #4 from Waqar Ahmed  ---
@Lassi Väätämöinen can you test:
https://invent.kde.org/utilities/kate/-/merge_requests/1621 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-07-29 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=490926

Christoph Cullmann  changed:

   What|Removed |Added

 CC||christ...@cullmann.io

--- Comment #3 from Christoph Cullmann  ---
I think it might make sense to add some way in the Kate config dialog to add
directories to the paths we use, an on macOS that is all a pain. Will not hurt
on other systems, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-07-29 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

--- Comment #2 from Lassi Väätämöinen  ---
(In reply to Waqar Ahmed from comment #1)
> Does something like this works:
> https://stackoverflow.com/questions/829749/launch-mac-eclipse-with-
> environment-variables-set ?

I can check if there's something I haven't tried. Glancing quickly through,
most of the comments are from 2009, so I am fairly certain those don't work.

I tried some *.plist magic from instructions that were written 2017...2022, and
those did not work either. Apple has changed / broken / jailed more stuff since
then, so we'd probably need actual Mac-expertise to help with this, maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-07-29 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=490926

Waqar Ahmed  changed:

   What|Removed |Added

 CC||waqar@gmail.com

--- Comment #1 from Waqar Ahmed  ---
Does something like this works:
https://stackoverflow.com/questions/829749/launch-mac-eclipse-with-environment-variables-set
?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 490926] MacOS: Language servers don't start, due to no PATH definition in GUI

2024-07-28 Thread Lassi Väätämöinen
https://bugs.kde.org/show_bug.cgi?id=490926

Lassi Väätämöinen  changed:

   What|Removed |Added

 OS|Other   |macOS

-- 
You are receiving this mail because:
You are watching all bug changes.