[kdeconnect] [Bug 485830] Virtual Monitor plugin sends wrong url, plugin not usable

2024-04-28 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=485830

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/netw
   ||ork/kdeconnect-kde/-/commit
   ||/2716a7a2e6583ead4cc4e9a9a9
   ||efb831dd7b28e7

--- Comment #2 from Aleix Pol  ---
Git commit 2716a7a2e6583ead4cc4e9a9a9efb831dd7b28e7 by Aleix Pol Gonzalez, on
behalf of Fabian Arndt.
Committed on 28/04/2024 at 14:14.
Pushed by apol into branch 'master'.

Fixed virtualmonitorplugin url generation

The current implementation of the plugin is severly broken.

1. The generated URL links to the localhost
2. The port is not set

-

The URL is now generated on the request receiving side, not send in the
request.
This allows finding a valid IP address.

Furthermore, I changed the protocol by splitting it up. This could become
useful, if we ever want to support other rdp protocols/platforms.

Note: This is a breaking change, but the current implementation is not working
at all.. so it does not actually break something.

M  +30   -10   plugins/virtualmonitor/virtualmonitorplugin.cpp

https://invent.kde.org/network/kdeconnect-kde/-/commit/2716a7a2e6583ead4cc4e9a9a9efb831dd7b28e7

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 485830] Virtual Monitor plugin sends wrong url, plugin not usable

2024-04-25 Thread Fabian Arndt
https://bugs.kde.org/show_bug.cgi?id=485830

Fabian Arndt  changed:

   What|Removed |Added

   Assignee|albertv...@gmail.com|fabian.ar...@root-core.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 485830] Virtual Monitor plugin sends wrong url, plugin not usable

2024-04-25 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=485830

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/669

-- 
You are receiving this mail because:
You are watching all bug changes.