[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Julius Künzel]

https://bugs.kde.org/show_bug.cgi?id=377829

Julius Künzel  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/kdenlive/commit/5aaa
   ||7466ea0f88642ac81bd31bd1223
   ||df17956c1

--- Comment #8 from Julius Künzel  ---
Git commit 5aaa7466ea0f88642ac81bd31bd1223df17956c1 by Julius Künzel.
Committed on 14/05/2021 at 23:08.
Pushed by jlskuz into branch 'master'.

Remove DVD Wizard
Related: bug 403128, bug 403405, bug 413567, bug 406042, bug 407242, bug
420319, bug 390431, bug 420428
Fixes #681
Fixes #1005

M  +0-33   data/org.kde.kdenlive.appdata.xml
M  +0-35   packaging/flatpak/org.kde.kdenlive-nightly.json
M  +0-1src/CMakeLists.txt
M  +1-0src/bin/bin.cpp
M  +1-1src/definitions.h
M  +1-0src/dialogs/kdenlivesettingsdialog.cpp
M  +1-4src/dialogs/renderwidget.cpp
M  +0-1src/dialogs/renderwidget.h
D  +0-8src/dvdwizard/CMakeLists.txt
D  +0-1044 src/dvdwizard/dvdwizard.cpp
D  +0-91   src/dvdwizard/dvdwizard.h
D  +0-272  src/dvdwizard/dvdwizardchapters.cpp
D  +0-64   src/dvdwizard/dvdwizardchapters.h
D  +0-912  src/dvdwizard/dvdwizardmenu.cpp
D  +0-147  src/dvdwizard/dvdwizardmenu.h
D  +0-873  src/dvdwizard/dvdwizardvob.cpp
D  +0-161  src/dvdwizard/dvdwizardvob.h
M  +1-0src/jobs/speedtask.cpp
M  +0-1src/kdenliveui.rc
M  +0-11   src/mainwindow.cpp
M  +2-2src/mainwindow.h
M  +1-0src/mltconnection.cpp
M  +33   -45   src/monitor/monitor.cpp
M  +0-1src/monitor/monitor.h
M  +1-4src/monitor/qmlmanager.cpp
M  +0-4src/scopes/scopemanager.cpp
M  +1-0src/timeline2/model/timelinefunctions.cpp
M  +1-0src/timeline2/view/timelinewidget.cpp
D  +0-149  src/ui/dvdwizardchapters_ui.ui
D  +0-345  src/ui/dvdwizardmenu_ui.ui
D  +0-212  src/ui/dvdwizardstatus_ui.ui
D  +0-173  src/ui/dvdwizardvob_ui.ui
M  +1-8src/ui/renderwidget_ui.ui
M  +1-1src/utils/otioconvertions.cpp

https://invent.kde.org/multimedia/kdenlive/commit/5aaa7466ea0f88642ac81bd31bd1223df17956c1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=377829

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #7 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=377829

--- Comment #6 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Julius Künzel]

https://bugs.kde.org/show_bug.cgi?id=377829

Julius Künzel  changed:

   What|Removed |Added

 CC||jk.kde...@smartlab.uber.spa
   ||ce

--- Comment #5 from Julius Künzel  ---
We are currently discussing if it is worth to keep the DVD Wizard in kdenlive
or if we should drop it. The discussion is at
https://invent.kde.org/multimedia/kdenlive/-/issues/1005. Maybe you want to
leave a comment there? (It would be very helpful to have some opinions)

Please take the comment of @emohr still in to account and close this bug if it
has been fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=377829

--- Comment #4 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[emohr]

https://bugs.kde.org/show_bug.cgi?id=377829

emohr  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #3 from emohr  ---
As it has been a while since this was reported, can you please test and confirm
if this issue is still occurring or if this bug report can be marked as
resolved.

Please try with the current Kdenlive AppImage version 20.12.2 
https://download.kde.org/stable/kdenlive/20.12/linux/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[emohr]

https://bugs.kde.org/show_bug.cgi?id=377829

emohr  changed:

   What|Removed |Added

  Flags||Brainstorm+
 CC||fritzib...@gmx.net

--- Comment #2 from emohr  ---
Was that code implemented in 17.04?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 377829] [patch?] dvdwizard menu edit chapter label names

[Jean-Baptiste Mardelle]

https://bugs.kde.org/show_bug.cgi?id=377829

Jean-Baptiste Mardelle  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Jean-Baptiste Mardelle  ---
I had a quick look and it seems ok to me. However I think we can ghet rid of
the Chapter class. 

Have not looked at this code for a while, but I think we could store the time
part of a Chapter as an int. Then we could simply use a QPair 
instead of the custom Chapter class, sorting can be achieved like this:

QList > vobChapters;

// sort function
struct QPairFirstComparer
{
template
bool operator()(const QPair & a, const QPair & b) const
{
return a.first < b.first;
}
};

// sort:
qSort(vobChapters.begin(), vobChapters.end(), QPairFirstComparer());

see: 
http://stackoverflow.com/questions/10188920/sorting-algorithm-with-qt-c-sort-a-qlist-of-struct

Does that seem ok to you ? The deadline for Kdenlive 17.04 is on this
wednesday, 23rd of march at midnight UTC, so if you can get a patch ready for
that time, would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.