[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[Allen Winter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

Allen Winter  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 Ever confirmed|0   |1

--- Comment #8 from Allen Winter  ---
re-opening because we never added the conditionals as discussed in Comment 6.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[Allen Winter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

Allen Winter  changed:

   What|Removed |Added

 CC||win...@kde.org

--- Comment #7 from Allen Winter  ---
good idea about the conditional.
please make a new patch, test it and attach here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

--- Comment #6 from 38dosb+99yi2ktucs...@guerrillamailblock.com ---
Thanks for applying the patch! But, unfortunately, I forgot to update the line
"Updated: 2010-06-06", and it is misleading now. Also, should the past changes
in the list of official holidays be reflected in the holiday file by using
conditionals like "public on ((year >= 2015 ) ? [october 14] : noop)"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

Laurent Montel  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kdep |http://commits.kde.org/khol
   |imlibs/cb0585c117fa532eac78 |idays/08cb6ac11ce246e22c0fc
   |cad1f88ec6fd1e80a439|5da8e6ccba66dbd09be

--- Comment #5 from Laurent Montel  ---
Git commit 08cb6ac11ce246e22c0fc5da8e6ccba66dbd09be by Montel Laurent.
Committed on 25/02/2016 at 07:59.
Pushed by mlaurent into branch 'master'.

Backport: holidays_ua_uk - updated Ukrainian holidays

M  +18   -6holidays/plan2/holiday_ua_uk

http://commits.kde.org/kholidays/08cb6ac11ce246e22c0fc5da8e6ccba66dbd09be

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[Allen Winter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

Allen Winter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/kdep
   ||imlibs/cb0585c117fa532eac78
   ||cad1f88ec6fd1e80a439
 Resolution|--- |FIXED

--- Comment #4 from Allen Winter  ---
Git commit cb0585c117fa532eac78cad1f88ec6fd1e80a439 by Allen Winter.
Committed on 24/02/2016 at 17:43.
Pushed by winterz into branch 'KDE/4.14'.

holidays_ua_uk - updated Ukrainian holidays

CHERRY-PICK: everywhere

M  +18   -6kholidays/holidays/plan2/holiday_ua_uk

http://commits.kde.org/kdepimlibs/cb0585c117fa532eac78cad1f88ec6fd1e80a439

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

--- Comment #3 from 38dosb+99yi2ktucs...@guerrillamailblock.com ---
The links to president.gov.ua are dead (I admit that I copied them from
Wikipedia articles). The updated URLs are
http://www.president.gov.ua/documents/8722014-18001 and
http://www.president.gov.ua/documents/692015-18468

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

--- Comment #2 from 38dosb+99yi2ktucs...@guerrillamailblock.com ---
Created attachment 97380
  --> https://bugs.kde.org/attachment.cgi?id=97380=edit
The same patch with corrected capitalization

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdepimlibs] [Bug 359708] Updated holiday file for Ukraine

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359708

--- Comment #1 from 38dosb+99yi2ktucs...@guerrillamailblock.com ---
Created attachment 97379
  --> https://bugs.kde.org/attachment.cgi?id=97379=edit
A patch fixing this issue

I've attached a patch against the current kholidays.git HEAD (not tested).

-- 
You are receiving this mail because:
You are watching all bug changes.