[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=330539

--- Comment #11 from Kevin Funk  ---
Thanks for the patches!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=330539

Kevin Funk  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.1.0
 Resolution|--- |FIXED

--- Comment #10 from Kevin Funk  ---
Patches pushed.

https://phabricator.kde.org/D3171 (kdevplatform)
https://phabricator.kde.org/D3172 (kdevelop)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=330539

Kevin Funk  changed:

   What|Removed |Added

 CC||kf...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Markus Trippelsdorf]

https://bugs.kde.org/show_bug.cgi?id=330539

--- Comment #9 from Markus Trippelsdorf  ---
(In reply to Kevin Funk from comment #8)
> It'd be better to have these patches on either ReviewBoard or Phabricator so
> we could discuss the diff.

It is just a rough rebase. I have only tested it in a very limited way.
Split open doesn't work for example:

markus@x4 ~ % cat test.zsh
RESULT=$(qdbus org.kdevelop.kdevelop-30695 /org/kdevelop/DocumentController
org.kdevelop.DocumentController.openDocumentsSimple  $1 )
 if [[ "$RESULT" != "true" ]]; then
   echo "Failed to open $1" && exit 1
 fi
 echo "OK"
markus@x4 ~ % bash test.zsh "( /home/markus/bench.cpp - /home/markus/hello.cpp
)"
OK
markus@x4 ~ % zsh test.zsh "( /home/markus/bench.cpp - /home/markus/hello.cpp
)"
Failed to open ( /home/markus/bench.cpp - /home/markus/hello.cpp )

Not sure what is going on. 
So this needs more testing before it can be officially proposed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=330539

--- Comment #8 from Kevin Funk  ---
It'd be better to have these patches on either ReviewBoard or Phabricator so we
could discuss the diff.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Markus Trippelsdorf]

https://bugs.kde.org/show_bug.cgi?id=330539

--- Comment #6 from Markus Trippelsdorf  ---
Created attachment 101796
  --> https://bugs.kde.org/attachment.cgi?id=101796=edit
zsh support patch for kdevplatform

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Markus Trippelsdorf]

https://bugs.kde.org/show_bug.cgi?id=330539

--- Comment #7 from Markus Trippelsdorf  ---
Created attachment 101797
  --> https://bugs.kde.org/attachment.cgi?id=101797=edit
zsh support patch for kdevelop

The patches are attached. Works fine for me.
It is a bit ugly that .zshrc gets installed in /usr/bin.
Maybe it should live somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=330539

Kevin Funk  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Kevin Funk  ---
Feel free to pick up those patches and rebase & test them once more, then we'll
have these merged.

Any takers?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Markus Trippelsdorf]

https://bugs.kde.org/show_bug.cgi?id=330539

Markus Trippelsdorf  changed:

   What|Removed |Added

 CC||octopl...@yandex.com

--- Comment #4 from Markus Trippelsdorf  ---
There was some attempt to add zsh support some years ago:
https://git.reviewboard.kde.org/r/110298/diff/3/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 330539] Konsole opens bash after kdevelop_attach even if zsh is set.

[Diadlo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=330539

Diadlo  changed:

   What|Removed |Added

 CC||dia...@openmailbox.org

--- Comment #3 from Diadlo  ---
KDevelop use it own addition for bash environment (`.bashrc`). I'm not sure,
that it will work right in another shell
You can find it in the `kdevplatform_shell_environment.sh` file, in directory,
where stored kdevelop! `whereis kdevelop\!`

-- 
You are receiving this mail because:
You are watching all bug changes.