[kdevelop] [Bug 373004] Segfault when switchin compiler

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=373004

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 373004] Segfault when switchin compiler

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=373004

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kco
   |velop/e6ee67c23ae333d2ea412 |mpletion/31f226116f99bcf40d
   |9bf507c5a389684c960 |dc67fe6328594d5fb46222

--- Comment #3 from David Faure  ---
Git commit 31f226116f99bcf40ddc67fe6328594d5fb46222 by David Faure, on behalf
of Dan Weatherill.
Committed on 19/01/2018 at 08:48.
Pushed by dfaure into branch 'master'.

Fix incorrect emission of textEdited() by KLineEdit

The unit test of kLineEdit was previously checking incorrectly that
textEdited _HAD_ been emitted when the text is changed with setText().
This is undesired behaviour.
This patch fixes the unit test, and changes the problematic behaviour by
removing the extra emission of textEdited in the private signal
_k_textChanged.
In addition this is the underlying cause of a bug in kdevelop (and
probably several others).
Related: bug 388798

M  +28   -3autotests/klineedit_unittest.cpp
M  +0-1src/klineedit.cpp

https://commits.kde.org/kcompletion/31f226116f99bcf40ddc67fe6328594d5fb46222

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 373004] Segfault when switchin compiler

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=373004

Kevin Funk  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||velop/e6ee67c23ae333d2ea412
   ||9bf507c5a389684c960
   Version Fixed In||5.2.2
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Kevin Funk  ---
Git commit e6ee67c23ae333d2ea4129bf507c5a389684c960 by Kevin Funk, on behalf of
Dan Weatherill.
Committed on 15/01/2018 at 20:03.
Pushed by kfunk into branch '5.2'.

work around bug in kLineEdit

Summary:
a bug in kLineEdit causes spurious emission of textEdited signals when calling
setText().

This in turn causes spurious calls of compilerEdited() when selecting a
compiler in the compilers window,
 which leads to a segfault (e.g. this bug
https://bugs.kde.org/show_bug.cgi?id=373004) and I think some duplicates also.

I have submitted also a patch to kcompletion, https://phabricator.kde.org/D9808

This is a workaround for those systems until that is fixed

Reviewers: #kdevelop, apol, mwolff

Reviewed By: #kdevelop, mwolff

Subscribers: mwolff, anthonyfieroni, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D9809
FIXED-IN: 5.2.2

M  +1-0   
plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp
M  +13   -0   
plugins/custom-definesandincludes/compilerprovider/widget/compilerswidget.cpp

https://commits.kde.org/kdevelop/e6ee67c23ae333d2ea4129bf507c5a389684c960

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 373004] Segfault when switchin compiler

[Dan Weatherill]

https://bugs.kde.org/show_bug.cgi?id=373004

Dan Weatherill  changed:

   What|Removed |Added

 CC||plasteredpar...@gmail.com

--- Comment #1 from Dan Weatherill  ---
Created attachment 109797
  --> https://bugs.kde.org/attachment.cgi?id=109797=edit
improved backtrace

this is an improved backtrace with more symbols included. In thread#1 the crash
can clearly be seen to occur within compilerEdited. (note that the compiler has
not been edited, just selected).

-- 
You are receiving this mail because:
You are watching all bug changes.