[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=384162

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

Kevin Funk  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||velop/6d4591fb1733f4490d77d
   ||9e6a1e619b31767d49b
   Version Fixed In||5.2.1

--- Comment #6 from Kevin Funk  ---
Git commit 6d4591fb1733f4490d77d9e6a1e619b31767d49b by Kevin Funk.
Committed on 20/11/2017 at 20:30.
Pushed by kfunk into branch '5.2'.

Fix crash deep inside VcsOverlayProxyModel::data()

Summary:
VcsOverlayProxyModel::data() calls ProjectController::changesModel()
which currently is a non-const method which might create an instance
of ProjectChangesModel which in turn triggers some KJobs.

Avoid that by instantiating ProjectChangesModel() immediately during
startup. I don't think that has a real performance impact.
FIXED-IN: 5.2.1

Reviewers: apol

Reviewed By: apol

Subscribers: mwolff, dfaure, brauch, apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D8852

M  +3-4kdevplatform/shell/projectcontroller.cpp

https://commits.kde.org/kdevelop/6d4591fb1733f4490d77d9e6a1e619b31767d49b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=384162

--- Comment #5 from David Faure  ---
I confirm that the patch fixes the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

--- Comment #4 from Kevin Funk  ---
Hm. I can't reproduce this issue here. :|

For those who can reproduce every time, could you please check if this patch
fixes the issue for you?
  https://phabricator.kde.org/D8852

David maybe? Thanks a lot in advance -- and sorry for taking your time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

Kevin Funk  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D8852

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

Kevin Funk  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

Kevin Funk  changed:

   What|Removed |Added

 CC||aleix...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=384162

--- Comment #3 from David Faure  ---
VcsOverlayProxyModel::data (called from painting code) calls
KDevSvnPlugin::isVersionControlled which calls KJob::exec (!!!), whose nested
event loop ends up in painting code again (!).

I don't think it's good design for a model to be doing such operations from
data(), it should rather do it async and notify of changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=384162

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #2 from David Faure  ---
Created attachment 108894
  --> https://bugs.kde.org/attachment.cgi?id=108894=edit
backtrace

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=384162

David Faure  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384162] Crash just after switching session [KDevelop::ProjectChangesModel::repositoryBranchChanged]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=384162

Kevin Funk  changed:

   What|Removed |Added

Summary|Crash just after switching  |Crash just after switching
   |session |session
   ||[KDevelop::ProjectChangesMo
   ||del::repositoryBranchChange
   ||d]

-- 
You are receiving this mail because:
You are watching all bug changes.