[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2018-10-23 Thread RJVB
https://bugs.kde.org/show_bug.cgi?id=384710

--- Comment #6 from RJVB  ---
Applies and builds in the 5.3 branch too. Can't yet say if it also has the
desired effect but why wouldn't it... So thanks, it was quite annoying for a
minor nuisance.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2018-10-23 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=384710

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||5.4.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2018-10-23 Thread Amish Naidu
https://bugs.kde.org/show_bug.cgi?id=384710

Amish Naidu  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||velop/4f2fc9e32452b3dc7f017
   ||d57c0bcc98b73cb0370
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Amish Naidu  ---
Git commit 4f2fc9e32452b3dc7f017d57c0bcc98b73cb0370 by Amish Naidu.
Committed on 23/10/2018 at 07:54.
Pushed by anaidu into branch 'master'.

Replace leading typed text when completing function implementation

Summary:
When executing function-implementation auto-completion, this will now
replace and leading typed text that matches the proposed completion
instead of duplicating it.

Test Plan:
```
int Foo(int thing);
struct Bar
{
  void Method(int thing);
}
```
Start typing `int Foo` or `Bar::Meth` and then execute the offered completion.

Reviewers: #kdevelop, mwolff

Reviewed By: #kdevelop, mwolff

Subscribers: kfunk, brauch, mwolff, apol, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16326

M  +6-0kdevplatform/language/duchain/stringhelpers.cpp
M  +5-0kdevplatform/language/duchain/stringhelpers.h
M  +16   -1plugins/clang/codecompletion/context.cpp
M  +24   -0plugins/clang/tests/test_codecompletion.cpp

https://commits.kde.org/kdevelop/4f2fc9e32452b3dc7f017d57c0bcc98b73cb0370

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2018-10-19 Thread Amish Naidu
https://bugs.kde.org/show_bug.cgi?id=384710

Amish Naidu  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #4 from Amish Naidu  ---
*** Bug 385217 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2018-10-19 Thread Amish Naidu
https://bugs.kde.org/show_bug.cgi?id=384710

Amish Naidu  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #3 from Amish Naidu  ---
*** Bug 363057 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2017-09-18 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=384710

Sven Brauch  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #2 from Sven Brauch  ---
I'm fairly sure I've seen this before 5.2, i.e. like always.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2017-09-18 Thread Francis Herne
https://bugs.kde.org/show_bug.cgi?id=384710

Francis Herne  changed:

   What|Removed |Added

 CC||[email protected]
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Francis Herne  ---
Yes, I've noticed this also; it's still a problem with the 5.2 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 384710] "Magic function completion" ignores existing text

2017-09-18 Thread TheComet
https://bugs.kde.org/show_bug.cgi?id=384710

TheComet  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.