[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Ilya Bizyaev]

https://bugs.kde.org/show_bug.cgi?id=220496

Ilya Bizyaev  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #27 from Ilya Bizyaev  ---
Still have this bug

Operating System: openSUSE Leap 15.3
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Ilya Bizyaev]

https://bugs.kde.org/show_bug.cgi?id=220496

Ilya Bizyaev  changed:

   What|Removed |Added

 CC||bizy...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=220496

Patrick Silva  changed:

   What|Removed |Added

Version|unspecified |19.08.1
   Platform|Ubuntu Packages |Archlinux Packages

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #26 from Nate Graham  ---
That's odd. Thanks folks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=220496

Christoph Feck  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|FIXED   |---
 Status|RESOLVED|REPORTED

--- Comment #25 from Christoph Feck  ---
I can confirm comment #23. Only the reverse case works (renaming .jpeg to .png
still shows the thumbnail).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #24 from Patrick Silva  ---
ops, I meant Dolphin 19.04 beta.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #23 from Patrick Silva  ---
It's not working with Dolphin 18.04 beta. I changed the extension of a
screenshot taken with spectacle from .png to .jpg and Dolphin does not show the
thumbnail of the screenshot.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.13.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Bruno Léon]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #22 from Bruno Léon  ---
Thanks for your work !

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=220496

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||19.04.0

--- Comment #21 from Nate Graham  ---
No, updated the "version fixed in" field appropriately.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #20 from Patrick Silva  ---
does dolphin 18.12.2 include this fix?
png files with jpg extension are still without thumbnail here.

SOFTWARE/OS VERSIONS
dolphin 18.12.2
Operating System: Arch Linux 
KDE Plasma Version: 5.15.0
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #19 from Nate Graham  ---
Git commit 880a09adae2abbf18f92c008fd4c109876a96581 by Nate Graham, on behalf
of Miklós Máté.
Committed on 19/01/2019 at 16:00.
Pushed by ngraham into branch 'master'.

manually set format in jpeg thumbnail creator

Summary:
Otherwise the QImageReader sets the format based on the file name suffix, which
might be misleading, e.g. a jpeg file named image.png.

Reviewers: dfaure, elvisangelaccio, #frameworks

Reviewed By: dfaure, elvisangelaccio

Subscribers: kde-frameworks-devel, kfm-devel, ngraham

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D13316

M  +1-1thumbnail/jpegcreator.cpp

https://commits.kde.org/kio-extras/880a09adae2abbf18f92c008fd4c109876a96581

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=220496

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kio
   ||-extras/0be80392f01e0ec0117
   ||4990c430dcd8f1ed35d9e

--- Comment #18 from Albert Astals Cid  ---
Git commit 0be80392f01e0ec01174990c430dcd8f1ed35d9e by Albert Astals Cid, on
behalf of Miklós Máté.
Committed on 16/01/2019 at 23:53.
Pushed by aacid into branch 'master'.

image thumbnailer: instruct Qt to look at the file contents when detecting its
format

This enables thumbnails in Dolphin for a png file named image.jpg for example.

M  +5-2thumbnail/imagecreator.cpp

https://commits.kde.org/kio-extras/0be80392f01e0ec01174990c430dcd8f1ed35d9e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=220496

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

--- Comment #17 from Elvis Angelaccio  ---
(In reply to miklos from comment #13)
> Now I found this again, and I had some time to debug it.
> 
> The file metadata is gathered by FileMetaDataWidget of baloo-widgets, which
> launches an external program (baloo_filemetadata_temp_extractor) to parse
> the file and return its properties, so the file description in the tooltip
> and the information panel is always correct.
> 
> The preview is generated with KIO::PreviewJob(), which gets the mime type of
> the file from its name: kio/src/widgets/previewjob.cpp:304 calls
> kio/src/core/kfileitem.cpp:732, where QMimeDatabase is asked for the mime
> type based on the file name. This is wrong when the file suffix is wrong,
> and apparently there is a different preview generator for jpeg and png.
> 
> I see three possible solutions:
> - QMimeDatabase supports parsing the file to find out its type

Just for the record, QMimeDatabase already has this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Mircea Kitsune]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #16 from Mircea Kitsune  ---
(In reply to miklos from comment #15)

It's amazing to finally see this solved after so long. Thank you! I hope the
solution sticks this time and it doesn't break again in the future... ideally
you can add code comments as well to make sure future developers know. Can't
wait to see this fix in the next system updates :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[miklos]

https://bugs.kde.org/show_bug.cgi?id=220496

--- Comment #15 from miklos  ---
I finally had the time to dig into the rabbit hole and fix all the stupid code
trying to detect the file type based on the file name suffix. These patches
should fix the previews in Dolphin:
https://codereview.qt-project.org/#/c/231308/
https://phabricator.kde.org/D13314
https://phabricator.kde.org/D13315
https://phabricator.kde.org/D13316

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 220496] Preview of pictures when content type does not match extension

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=220496

Nate Graham  changed:

   What|Removed |Added

  Component|Thumbnails and previews |Thumbnails and previews
Product|frameworks-kio  |kio-extras

-- 
You are receiving this mail because:
You are watching all bug changes.