[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Laurent Montel  changed:

   What|Removed |Added

   Version Fixed In|3.4.0   |5.3.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Laurent Montel  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/mess |http://commits.kde.org/mess
   |agelib/c1d1b7fb6ebeb6c060b1 |agelib/9c764eaa3995be89b3bc
   |72567aa6df9104a6aeed|b94822ec9446d47a9b1c
   Version Fixed In|5.3.3   |3.4.0

--- Comment #9 from Laurent Montel  ---
Git commit 9c764eaa3995be89b3bcb94822ec9446d47a9b1c by Montel Laurent.
Committed on 25/10/2016 at 04:49.
Pushed by mlaurent into branch 'Applications/16.08'.

Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed
up

FIXED-IN: 3.4.0
(cherry picked from commit c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed)

M  +2-2   
messageviewer/src/messagepartthemes/default/autotests/quotehtmltest.cpp
M  +0-1messageviewer/src/messagepartthemes/default/defaultrenderer.cpp

http://commits.kde.org/messagelib/9c764eaa3995be89b3bcb94822ec9446d47a9b1c

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org
   Version Fixed In|5.3.4   |5.3.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Gunter Ohrner  changed:

   What|Removed |Added

   Version Fixed In|3.4.0   |5.3.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

--- Comment #8 from Gunter Ohrner  ---
I guess you meant version 5.3.4 - not 3.4.0?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Laurent Montel  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit|http://commits.kde.org/mess |http://commits.kde.org/mess
   |agelib/cea1557b67d87709091a |agelib/c1d1b7fb6ebeb6c060b1
   |cdae49987e0278a7c384|72567aa6df9104a6aeed
   Version Fixed In|5.3.2   |3.4.0

--- Comment #7 from Laurent Montel  ---
Git commit c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed by Montel Laurent.
Committed on 24/10/2016 at 19:03.
Pushed by mlaurent into branch 'master'.

Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed
up

FIXED-IN: 3.4.0

M  +2-2   
messageviewer/src/messagepartthemes/default/autotests/quotehtmltest.cpp
M  +0-1messageviewer/src/messagepartthemes/default/defaultrenderer.cpp

http://commits.kde.org/messagelib/c1d1b7fb6ebeb6c060b172567aa6df9104a6aeed

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

--- Comment #6 from Laurent Montel  ---
Git commit c812e79789d6991fc011d8e93b46efec89ac4544 by Montel Laurent.
Committed on 23/10/2016 at 19:21.
Pushed by mlaurent into branch 'Applications/16.08'.

Start to fix quoting display.

Still not perfect.

M  +5-5messageviewer/src/messagepartthemes/default/defaultrenderer.cpp

http://commits.kde.org/messagelib/c812e79789d6991fc011d8e93b46efec89ac4544

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

--- Comment #5 from Gunter Ohrner  ---
In more detail: The mail is currently displayed as follows:

Am Montag, 19. September 2016, 21:01:11 CEST schrieb Gunter Ohrner:
| Am Montag, 19. September 2016, 21:00:44 CEST schrieb Gunter Ohrner:
| Am Montag, 19. September 2016, 21:00:25 CEST schrieb Gunter Ohrner:
| Text Level 1
Text Level 2
Text Level 3
Text Level 4

This does not really make sense and you still cannot determine that "Text Level
3" is an answer to "Text Level 2", but "Text Level 4" is not, and you also
cannot determine that "Text Level 2" belongs to the introduction line from
"21:00:44" and "Text Level 3" belongs to the introduction line from "21:01:11".

You cannot even easily see that "Text Level 2" and 3 are quoted but "Text Level
4" is not. (Except possibly due to font face and color, if configured
accordingly, which is applied correctly.)

It should look as follows however to make clear which part belongs to what and
what part is an answer to which:

Am Montag, 19. September 2016, 21:01:11 CEST schrieb Gunter Ohrner:
| Am Montag, 19. September 2016, 21:00:44 CEST schrieb Gunter Ohrner:
| | Am Montag, 19. September 2016, 21:00:25 CEST schrieb Gunter Ohrner:
| | | Text Level 1
| | Text Level 2
| Text Level 3
Text Level 4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Gunter Ohrner  changed:

   What|Removed |Added

 Attachment #101186|0   |1
is obsolete||

--- Comment #4 from Gunter Ohrner  ---
Created attachment 101597
  --> https://bugs.kde.org/attachment.cgi?id=101597=edit
Screenshot showing the bug after the 5.3.2 patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Gunter Ohrner  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #3 from Gunter Ohrner  ---
Unfortunately, the quoted parts still do not look correctly. You still cannot
determine the context / quoting levels.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

Laurent Montel  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/mess
   ||agelib/cea1557b67d87709091a
   ||cdae49987e0278a7c384
   Version Fixed In||5.3.2
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Laurent Montel  ---
Git commit cea1557b67d87709091acdae49987e0278a7c384 by Montel Laurent.
Committed on 03/10/2016 at 05:19.
Pushed by mlaurent into branch 'Applications/16.08'.

Fix Bug 369072 - Regression kMail 5.3.x: Plain-text quoting display is messed
up

FIXED-IN: 5.3.2

M  +5-0messageviewer/src/messagepartthemes/default/defaultrenderer.cpp

http://commits.kde.org/messagelib/cea1557b67d87709091acdae49987e0278a7c384

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 369072] Regression kMail 5.3.x: Plain-text quoting display is messed up

[Gunter Ohrner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369072

--- Comment #1 from Gunter Ohrner  ---
Created attachment 101186
  --> https://bugs.kde.org/attachment.cgi?id=101186=edit
Screenshot with messed-up rendering of quoted text. (No indication of a line's
quoting level.)

-- 
You are receiving this mail because:
You are watching all bug changes.