[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Thilo Molitor]

https://bugs.kde.org/show_bug.cgi?id=377521

Thilo Molitor  changed:

   What|Removed |Added

 CC||th...@eightysoft.de

--- Comment #35 from Thilo Molitor  ---
It's really a shame that this wonderful client lacks such a vital feature :(

I did a patch series against different stable releases of debian, based on the
wonderful work of Éric Brunet.
The patches can be found on github over here:
https://github.com/tmolitor-stud-tu/debian-patches/tree/master/kmail-systray-number

I'll publish new patches every time I update my system to a newer kmail
version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Grósz Dániel]

https://bugs.kde.org/show_bug.cgi?id=377521

Grósz Dániel  changed:

   What|Removed |Added

 CC||groszdaniel...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=377521

Laurent Montel  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INTENTIONAL

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Dmitri Koulikoff]

https://bugs.kde.org/show_bug.cgi?id=377521

Dmitri Koulikoff  changed:

   What|Removed |Added

 Resolution|INTENTIONAL |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #34 from Dmitri Koulikoff  ---
I need this patch too to be implemented for all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #33 from Kamil Dudka  ---
Created attachment 146946
  --> https://bugs.kde.org/attachment.cgi?id=146946=edit
patch to reenable numbers, v21.08.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #32 from davidblunkett  ---
Is the patch shipping? or is this bug still current? I can't see a fix in
5.13...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=377521

Jonathan Marten  changed:

   What|Removed |Added

 CC||k...@mitrah.ru

--- Comment #31 from Jonathan Marten  ---
*** Bug 430915 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #30 from Kamil Dudka  ---
I just discovered that #include  needs to be added to
src/kmsystemtray.cpp when compiling kmail-19.12.3 with the attached patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #29 from Éric Brunet  ---
Created attachment 121110
  --> https://bugs.kde.org/attachment.cgi?id=121110=edit
patch to reenable numbers, v19.04

Updated version of the patch to re-enable numbers in systray for kmail.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #28 from Christoph Feck  ---
The name was replaced because it was wrong. It didn't return the width, but the
number of pixels the cursor advances.

If you wanted the width, you had to use boundingRect().width().

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #27 from Kamil Dudka  ---
Comment on attachment 118961
  --> https://bugs.kde.org/attachment.cgi?id=118961
patch to reenable numbers, v18.12

Works perfectly.  Thanks for the quick fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #26 from Éric Brunet  ---
Created attachment 118961
  --> https://bugs.kde.org/attachment.cgi?id=118961=edit
patch to reenable numbers, v18.12

Sorry, I was slow with updating this patch.

The method horizontalAdvance seems to replace nicely the method width. Probably
that they changed it because "width" was so difficult to remember...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #25 from Kamil Dudka  ---
Comment on attachment 114942
  --> https://bugs.kde.org/attachment.cgi?id=114942
patch to reenable numbers, v18.04.3

I am not able to compile kmail-18.12.3 with this patch against up2date qt.  The
build fails with this error:

/var/tmp/paludis/kde-apps-kmail-18.12.3/work/kmail-18.12.3/src/kmsystemtray.cpp:
In member function 'void KMail::KMSystemTray::updateCount(int)':
/var/tmp/paludis/kde-apps-kmail-18.12.3/work/kmail-18.12.3/src/kmsystemtray.cpp:175:31:
error: 'class QFontMetrics' has no member named 'width'; did you mean
'maxWidth'?
 const int width = qfm.width(count < 100 ? QStringLiteral("99")
   ^
   maxWidth

I was able to google up a page saying that QFontMetrics::width() is obsolete:

https://doc.qt.io/qt-5/qfontmetrics-obsolete.html

... but the page does not suggest any replacement for that method.

Any idea how to make it build again?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #24 from davidblunkett  ---

> As I have already said, if this is rolled back into kmail, I am willing to
> answer bug reports regarding this feature. I think it should be rolled back;
> kmail must be the only graphical mail reader without this feature...

Thanks - I'd very much like to see this back-ported

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #23 from Éric Brunet  ---
Created attachment 114942
  --> https://bugs.kde.org/attachment.cgi?id=114942=edit
patch to reenable numbers, v18.04.3

This is an updated version of my patch to re-enable numbers in the tray icon
for kmail. It is for kmail version 5.8.3 shipped with kde 18.04.3, as found in
fedora 28.

As I have already said, if this is rolled back into kmail, I am willing to
answer bug reports regarding this feature. I think it should be rolled back;
kmail must be the only graphical mail reader without this feature...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #22 from davidblunkett  ---

I see a problem
I see a patch
I see "resolved wontfix"

What is the status here? Is this patch accepted or is this remaining unfixed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #21 from Éric Brunet  ---
The patch for 17.12.0 also applies to 17.12.2 which has just been shiped by
fedora.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #20 from Christophe Giboudeaux  ---
(In reply to Kamil Dudka from comment #16)
> The only reason was incompetence of a single person who happened to have
> commit access to the upstream kmail repository. 

The KDE Code of Conduct also applies to Redhat employees:
https://www.kde.org/code-of-conduct/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #18 from Kamil Dudka  ---
(In reply to Christoph Feck from comment #17)
> but the systray number display had
> several issues, including, but not limited to, color readability and HiDPI
> scaling.

See comment #10.  Attachment #109488 works perfectly for me.  If somebody has
issues with that feature, nobody forces him/her to have it enabled.  AFAIK it
has always been optional.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=377521

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=377485

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #17 from Christoph Feck  ---
According to https://phabricator.kde.org/D9841 Plasma developers contributed a
'unread email count' to the KMail launcher icon when pinned to taskbar. This
isn't a complete replacement, but the systray number display had several
issues, including, but not limited to, color readability and HiDPI scaling.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #16 from Kamil Dudka  ---
The only reason was incompetence of a single person who happened to have commit
access to the upstream kmail repository.  For me it is not a big deal to fix it
locally when there is a working patch available.  Unfortunately, it might be a
showstopper for non-technical users of kmail.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #15 from davidblunkett  ---
I see that this "bug" is an intentional change:

Please change it back, it is a useful and valuable feature and the loss is a
significant lowering in usability.

Just make it an option - having read the threads back I can see no good reason
note to fix this (only reason given is, "I'm not fixing it, so there").

I note there is also a patch available - please make this mainstream ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=377521

Jonathan Marten  changed:

   What|Removed |Added

 CC||dav1dblunk...@hotmail.com

--- Comment #13 from Jonathan Marten  ---
*** Bug 389407 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=377521

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #12 from Éric Brunet  ---
The patch for 17.12.0 also applies to 17.12.1 witho no modification, the
version that appeared this week in fedora 27.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #11 from Éric Brunet  ---
Created attachment 109722
  --> https://bugs.kde.org/attachment.cgi?id=109722=edit
patch to reenable numbers, v17.12.0

Hi Kamil, I am happy this is useful to someone. I'll post updated patches in a
more timely way.

Here is the patch to re-enable numbers for kmail 5.7.0, as found in kde
17.12.0,
as shipped by the latest fedora 27 updates

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #10 from Kamil Dudka  ---
Comment on attachment 109488
  --> https://bugs.kde.org/attachment.cgi?id=109488
patch to reenable numbers, v17.08.3

Works perfectly.  Thanks for sharing!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #9 from Éric Brunet  ---
Created attachment 109488
  --> https://bugs.kde.org/attachment.cgi?id=109488=edit
patch to reenable numbers, v17.08.3

This is an updated version of my patch to re-enable numbers in the tray icon
for kmail. It is for kmail version 5.6.3 shipped with kde 17.08.3, as found in
fedora 27.

I have also a version for the kmail that shipped with fedora 26 that I forgot
to post here. Contact me if anyone needs it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Kamil Dudka]

https://bugs.kde.org/show_bug.cgi?id=377521

Kamil Dudka  changed:

   What|Removed |Added

 CC||kdu...@redhat.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=377521

Jonathan Marten  changed:

   What|Removed |Added

 CC||j...@keelhaul.me.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #8 from Éric Brunet  ---
This is the patch I have been using for two weeks to re-enable nulbers in
systray. It works fine. It is against kmail 16.12.3, which is the version
shipped by fedora 25.

It is not a simple revert of the feature removal: the displayed was small and
ugly. The reason is that kmail sends a pixmap of size 32x32 which is scaled
down by systray to 22x22 (in standard theme). I am not sure how to ask the
theme what the correct icon size should be. I think the problem is also present
in the unpatched kmail.

Please? You could put me in the loop and I would answer bug reports about this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #7 from Éric Brunet  ---
Created attachment 105670
  --> https://bugs.kde.org/attachment.cgi?id=105670=edit
patch to reenable numbers

patch against kmail 16.12.3 to re-enable showing number of unread emails in
systray

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Éric Brunet]

https://bugs.kde.org/show_bug.cgi?id=377521

Éric Brunet  changed:

   What|Removed |Added

 CC||eric.bru...@lps.ens.fr

--- Comment #6 from Éric Brunet  ---
Please, would you reconsider your decision ? I have just upgraded my fedora 23
into a fedora 25, and had the bad surprise to see that the number of unread
emails was gone in the system tray icon.

Having this number of emails displayed was a useful feature. I thought it was a
configuration bug and I spent a long time trying to re-enable it, and then I
have seen this bug. (I thought of a configuration bug because the icon when
there are no unread mail is the simple breeze envelope outline, while the icon
when there are unread mails is a solid white envelope with shading and a yellow
star. I understand the yellow star, but why does the envelope changes ?)

People choose kde over gnome for its flexibility and configurability. Your
users are not afraid of an extra config option!

Thanks anyway for all the work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #5 from Laurent Montel  ---
nope 
I worked to reduce config so I removed it.
Sorry but I will not readd it.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Martin Koller]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #4 from Martin Koller  ---
Then what about an option whether to include the number display or not ?
The option makes it obvious if the user wants it or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #3 from Laurent Montel  ---
nope.
After that a user will report me a bug because we can't see number in some
case.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Martin Koller]

https://bugs.kde.org/show_bug.cgi?id=377521

--- Comment #2 from Martin Koller  ---
As I wrote, I can understand why you removed it in akregator, since there is
usually a large number of unread articles.

However, this is not true for mails (at least how I use it).

If you see the problem with not being able to read a large number, what about
the following idea:
Display the number if its less than 100, else do not display it.

Would you agree with such a patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=377521

Laurent Montel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 377521] regression: system tray icon no longer shows number of new mails

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=377521

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org

--- Comment #1 from Laurent Montel  ---
hi
it's intentional and I will not re-add it.
Same answer that I gave in akregator
Regards

-- 
You are receiving this mail because:
You are watching all bug changes.