[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=352616

Kurt Hindenburg  changed:

   What|Removed |Added

   Version Fixed In||18.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=352616

Kurt Hindenburg  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kon |https://commits.kde.org/kon
   |sole/10a41f41b090a485b041c8 |sole/9fa8c11d1feab41ec5f114
   |3b891c78aacf034f80  |757e3acf27a428a117

--- Comment #4 from Kurt Hindenburg  ---
Git commit 9fa8c11d1feab41ec5f114757e3acf27a428a117 by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 10/04/2018 at 14:05.
Pushed by hindenburg into branch 'Applications/18.04'.

Always preserve line breaks on "Select All" action

Summary:
`_preserveLineBreaks` was set/reset only in mousePressEvent, and was
initially disabled. This led to use of the last setting from mouse
selection, or initial value, by "Select All".

Test Plan:
* Start Konsole
* Run `seq 100`
* (optional, test should give the same effect with and without this step)
  Press {key Ctrl} and select some text
* Edit → Select All
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
Konsole screen)
**Actual result:** text is pasted as one line

=== Regression tests ===

* Run `seq 100`
* Select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
   Konsole screen)

* Run `seq 100`
* Press {key Ctrl} and select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be pasted as one line

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D12058

(cherry picked from commit 10a41f41b090a485b041c83b891c78aacf034f80)

M  +1-3src/SessionController.cpp
M  +12   -1src/TerminalDisplay.cpp
M  +5-0src/TerminalDisplay.h

https://commits.kde.org/konsole/9fa8c11d1feab41ec5f114757e3acf27a428a117

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=352616

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kon
   ||sole/10a41f41b090a485b041c8
   ||3b891c78aacf034f80
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Kurt Hindenburg  ---
Git commit 10a41f41b090a485b041c83b891c78aacf034f80 by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 10/04/2018 at 13:33.
Pushed by hindenburg into branch 'master'.

Always preserve line breaks on "Select All" action

Summary:
`_preserveLineBreaks` was set/reset only in mousePressEvent, and was
initially disabled. This led to use of the last setting from mouse
selection, or initial value, by "Select All".

Test Plan:
* Start Konsole
* Run `seq 100`
* (optional, test should give the same effect with and without this step)
  Press {key Ctrl} and select some text
* Edit → Select All
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
Konsole screen)
**Actual result:** text is pasted as one line

=== Regression tests ===

* Run `seq 100`
* Select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be in multiple lines (like on
   Konsole screen)

* Run `seq 100`
* Press {key Ctrl} and select few lines using mouse
* Copy
* Paste in any text editor

**Expected result:** text should be pasted as one line

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D12058

M  +1-3src/SessionController.cpp
M  +12   -1src/TerminalDisplay.cpp
M  +5-0src/TerminalDisplay.h

https://commits.kde.org/konsole/10a41f41b090a485b041c83b891c78aacf034f80

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Mariusz Glebocki]

https://bugs.kde.org/show_bug.cgi?id=352616

Mariusz Glebocki  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||m...@arccos-1.net
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Mariusz Glebocki  ---
Confirming on master (fb812c75).

Select All starts working properly after any manual selection.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 352616] konsole sometimes copies long text as a single line

[Paul Pogonyshev]

https://bugs.kde.org/show_bug.cgi?id=352616

Paul Pogonyshev  changed:

   What|Removed |Added

Version|15.04.0 |16.08.2

--- Comment #1 from Paul Pogonyshev  ---
Certain way to reproduce it.

Make sure that "Select All" has a shortcut, e.g. Ctrl+Shift+A.

1. Open a new Konsole tab, window, or start a new application instance.
2. Type Enter so that there are two lines with the shell prompt.
3. Press Ctrl+Shift+A, i.e. the shortcut for "Select All".
4. Press Ctrl+Shift+C, i.e. the shortcut for "Copy".
5. Paste the copied text somewhere else.

The pasted text contains *single line* with two times the shell prompt at the
beginning and many-many spaces at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.