[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=370566

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/krit
   ||a/de5852d8ad6be191b83fe5f51
   ||c0f84d9781223cc
 Status|UNCONFIRMED |RESOLVED

--- Comment #10 from Boudewijn Rempt  ---
Git commit de5852d8ad6be191b83fe5f51c0f84d9781223cc by Boudewijn Rempt.
Committed on 04/11/2016 at 09:51.
Pushed by rempt into branch 'rempt/bug-370566'.

This gets rid of both the delayed save dialog in KisMainWindow
(which offered a cancel button that didn't work to cancel the
runnin strokes), and the locking in KisDocument (which dead-locked
Krita and caused dataloss).

Instead, a shallow clone of the image is created that can be safely
used to save. The strokes will run on the original image, which means
that the result of still-running strokes is not saved. The user is
warned about that. (That means a new message has been added.)

M  +13   -0libs/image/kis_annotation.h
M  +98   -39   libs/image/kis_image.cc
M  +13   -1libs/image/kis_image.h
M  +38   -0libs/image/kis_layer_composition.cpp
M  +2-0libs/image/kis_layer_composition.h
M  +10   -0libs/image/kis_layer_utils.cpp
M  +6-0libs/image/kis_layer_utils.h
M  +0-1libs/image/kis_name_server.h
M  +0-1libs/image/kis_node_facade.cpp
M  +3-1libs/image/kis_node_facade.h
M  +0-1libs/image/kis_node_graph_listener.cpp
M  +4-1libs/image/kis_node_graph_listener.h
M  +8-0libs/image/recorder/kis_node_query_path.cc
M  +1-0libs/image/recorder/kis_node_query_path.h
M  +113  -2libs/image/tests/kis_image_test.cpp
M  +1-0libs/image/tests/kis_image_test.h
M  +0-2libs/ui/CMakeLists.txt
M  +24   -78   libs/ui/KisDocument.cpp
M  +10   -0libs/ui/KisDocument.h
M  +2-6libs/ui/KisMainWindow.cpp
D  +0-82   libs/ui/dialogs/kis_delayed_save_dialog.cpp
D  +0-52   libs/ui/dialogs/kis_delayed_save_dialog.h
D  +0-74   libs/ui/dialogs/kis_delayed_save_dialog.ui
M  +3-1libs/ui/kra/kis_kra_save_visitor.cpp
M  +2-4plugins/impex/bmp/kis_bmp_export.cpp
M  +3-0plugins/impex/brush/KisAnimatedBrushAnnotation.h
M  +16   -19   plugins/impex/brush/kis_brush_export.cpp
M  +1-1plugins/impex/csv/kis_csv_export.cpp
M  +1-6plugins/impex/exr/exr_export.cc
M  +7-9plugins/impex/heightmap/kis_heightmap_export.cpp
M  +1-3plugins/impex/jpeg/kis_jpeg_export.cc
M  +1-1plugins/impex/ora/ora_export.cc
M  +1-5plugins/impex/png/kis_png_export.cc
M  +1-3plugins/impex/ppm/kis_ppm_export.cpp
M  +2-2plugins/impex/psd/psd_export.cc
M  +1-1plugins/impex/psd/psd_resource_block.cpp
M  +14   -2plugins/impex/psd/psd_resource_block.h
M  +1-1plugins/impex/psd/psd_saver.cpp
M  +1-1plugins/impex/qml/qml_export.cc
M  +3-3plugins/impex/spriter/kis_spriter_export.cpp
M  +2-5plugins/impex/tga/kis_tga_export.cpp
M  +5-8plugins/impex/tiff/kis_tiff_export.cc

http://commits.kde.org/krita/de5852d8ad6be191b83fe5f51c0f84d9781223cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Bollebib]

https://bugs.kde.org/show_bug.cgi?id=370566

Bollebib  changed:

   What|Removed |Added

 CC||kwadraatn...@hotmail.com

--- Comment #9 from Bollebib  ---
I have this problem kn windowed 10

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=370566

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||katearche...@yandex.ru

--- Comment #8 from Boudewijn Rempt  ---
*** Bug 369368 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=370566

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||bunf2014@apps.opensourcelaw
   ||.biz

--- Comment #7 from Boudewijn Rempt  ---
*** Bug 370193 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

--- Comment #6 from Boudewijn Rempt  ---
I suspect it's rather that Krita is confused because it thinks the image is
still busy processing something.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[radian via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

radian  changed:

   What|Removed |Added

 CC||xe...@e1.ru

--- Comment #5 from radian  ---
This have happened with me on win10, not each time though. Maybe it depends on
file size and complexity?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

--- Comment #4 from Boudewijn Rempt  ---
It could be the same thing, but it's still strange that it always happens for
you -- and never for other people :-(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Miia Jalkanen via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

--- Comment #3 from Miia Jalkanen  ---
Looks like this a duplicate of this issue:
https://bugs.kde.org/show_bug.cgi?id=369368. 

Same behaviour with the saving dialog, menus and canvas, and also on Win 7.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Miia Jalkanen via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

--- Comment #2 from Miia Jalkanen  ---
Yes, every time. I have only Windows 7 on which I can test currently. Is there
anything else I could try, besides removing the kritarc file, or any other
information I could collect to help with this? Obviously, if both of these only
happen on my pc, there has to be something wrong with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 370566] Larger documents do not get saved with Save as

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370566

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #1 from Boudewijn Rempt  ---
Hi Miia,

Does this happen every time? Just like with
https://bugs.kde.org/show_bug.cgi?id=369497, I'm unable to reproduce the issue
on any of my Windows 10 systems :-(

-- 
You are receiving this mail because:
You are watching all bug changes.