[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=376086

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/1b156600aac2e4 |krita/commit/1ed14db7a6e320
   |2942bf1772b9c418d155061fc4  |31cffb98d97634360d9d52a197

--- Comment #7 from Boudewijn Rempt  ---
Git commit 1ed14db7a6e32031cffb98d97634360d9d52a197 by Boudewijn Rempt, on
behalf of Ivan Yossi.
Committed on 08/07/2019 at 14:59.
Pushed by rempt into branch 'krita/4.2'.

Enable Shift + Click to show only current layer

Differential Revision: https://phabricator.kde.org/D20591

M  +159  -55   plugins/dockers/layerdocker/NodeDelegate.cpp

https://invent.kde.org/kde/krita/commit/1ed14db7a6e32031cffb98d97634360d9d52a197

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=376086

vanyossi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/1b156600aac2e4
   ||2942bf1772b9c418d155061fc4
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from vanyossi  ---
Git commit 1b156600aac2e42942bf1772b9c418d155061fc4 by Ivan Yossi.
Committed on 28/06/2019 at 13:26.
Pushed by ivany into branch 'master'.

Enable Shift + Click to show only current layer

Differential Revision: https://phabricator.kde.org/D20591

M  +159  -55   plugins/dockers/layerdocker/NodeDelegate.cpp

https://invent.kde.org/kde/krita/commit/1b156600aac2e42942bf1772b9c418d155061fc4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=376086

--- Comment #5 from vanyossi  ---
Current patch in revision

https://invent.kde.org/kde/krita/merge_requests/5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=376086

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=376086

--- Comment #4 from vanyossi  ---
I made an implementation (currrently on merge request) But now Im doubtfull
this feature make sense when "isolate layer" does something very similar.

The shift + click on the patch hides all layers except the layers needed for
the  clicked layer to be visible (it will not hide their children also). A scon
dclick restores the state as it was before. However because there are some
other eyes present dmitry found it very confusing.

I don't know how this feature is supposed to look, should we disable all eye
icons except the one that was clicked?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=376086

vanyossi  changed:

   What|Removed |Added

 CC||ghe...@gmail.com
   Assignee|krita-bugs-n...@kde.org |ghe...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[Scott Petrovic]

https://bugs.kde.org/show_bug.cgi?id=376086

Scott Petrovic  changed:

   What|Removed |Added

 CC||scottpetro...@gmail.com

--- Comment #3 from Scott Petrovic  ---
I was talking with Dmitry and it sounds like this was removed as Wolthera
pointed out. It also sounds like it wasn't working correctly before as well.
The behavior should be the following:

1. Shift + Clicking an eye icon on a layer hides all layers except the one 
clicked on
2. Shift + Clicking an eye icon again will restore the layers to its previous
state

It doesn't sound like there is a state management right now for the layers, so
there isn't a way to restore the layer visibility to what it was previously.
That will have to be added as well with this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=376086

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com

--- Comment #2 from wolthera  ---
(In reply to Boudewijn Rempt from comment #1)
> I wonder when this broke, and whether it broke when we started using
> shift-click to select multiple layers, but it is broken...

I think it disappeared with the new layers docker.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376086] Shift + Clicking a layer eye icon does not hide other layers

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=376086

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Boudewijn Rempt  ---
I wonder when this broke, and whether it broke when we started using
shift-click to select multiple layers, but it is broken...

-- 
You are receiving this mail because:
You are watching all bug changes.