[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=381917

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/5507353d0768d9b1e177032a
   ||f7bdfa285768aed3
 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/5507353d0768d9b1e177032a |ta/92aeb4d9365f44acace741f5
   |f7bdfa285768aed3|18978005b6698213

--- Comment #5 from Dmitry Kazakov  ---
Git commit 5507353d0768d9b1e177032af7bdfa285768aed3 by Dmitry Kazakov.
Committed on 20/02/2018 at 20:41.
Pushed by dkazakov into branch 'master'.

Fix colors for the highlight in the path shape handles

One can always change the color in:

* KisHandleStyle::highlightedPrimaryHandles()
* KisHandleStyle::partiallyHighlightedPrimaryHandles()
* KisHandleStyle::selectedPrimaryHandles()

M  +1-0libs/flake/KoPathPoint.h
M  +11   -2libs/flake/tools/KoPathToolHandle.cpp
M  +15   -2libs/global/KisHandleStyle.cpp
M  +6-0libs/global/KisHandleStyle.h

https://commits.kde.org/krita/5507353d0768d9b1e177032af7bdfa285768aed3

--- Comment #6 from Dmitry Kazakov  ---
Git commit 92aeb4d9365f44acace741f518978005b6698213 by Dmitry Kazakov.
Committed on 20/02/2018 at 20:41.
Pushed by dkazakov into branch 'master'.

Highlight only control point that is really hovered

And paint in **on the top** so the user would see it

M  +12   -3libs/flake/tools/KoPathToolHandle.cpp

https://commits.kde.org/krita/92aeb4d9365f44acace741f518978005b6698213

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=381917

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/5507353d0768d9b1e177032a
   ||f7bdfa285768aed3
 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/5507353d0768d9b1e177032a |ta/92aeb4d9365f44acace741f5
   |f7bdfa285768aed3|18978005b6698213

--- Comment #5 from Dmitry Kazakov  ---
Git commit 5507353d0768d9b1e177032af7bdfa285768aed3 by Dmitry Kazakov.
Committed on 20/02/2018 at 20:41.
Pushed by dkazakov into branch 'master'.

Fix colors for the highlight in the path shape handles

One can always change the color in:

* KisHandleStyle::highlightedPrimaryHandles()
* KisHandleStyle::partiallyHighlightedPrimaryHandles()
* KisHandleStyle::selectedPrimaryHandles()

M  +1-0libs/flake/KoPathPoint.h
M  +11   -2libs/flake/tools/KoPathToolHandle.cpp
M  +15   -2libs/global/KisHandleStyle.cpp
M  +6-0libs/global/KisHandleStyle.h

https://commits.kde.org/krita/5507353d0768d9b1e177032af7bdfa285768aed3

--- Comment #6 from Dmitry Kazakov  ---
Git commit 92aeb4d9365f44acace741f518978005b6698213 by Dmitry Kazakov.
Committed on 20/02/2018 at 20:41.
Pushed by dkazakov into branch 'master'.

Highlight only control point that is really hovered

And paint in **on the top** so the user would see it

M  +12   -3libs/flake/tools/KoPathToolHandle.cpp

https://commits.kde.org/krita/92aeb4d9365f44acace741f518978005b6698213

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=381917

--- Comment #4 from wolthera  ---
go with the second, I think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=381917

--- Comment #3 from wolthera  ---
Okay, so, Inkscape uses Blue for selected and Red for hover over.

Our options are either

1. Node selected blue
2. Node hovered control point: cyan (or a 50% mix between selected and hovered)
3. controlpoint hovered: green

Or

1. Node selected green
2. Node hovered control point: cyan (or a 50% mix between selected and hovered)
3. controlpoint hovered: blue

Or


1. Node selected blue
2. Node hovered control point: purple/fuchsia/magenta (or a 50% mix between
selected and hovered)
3. controlpoint hovered: red

Or


1. Node selected red
2. Node hovered control point: purple/fuchsia/magenta (or a 50% mix between
selected and hovered)
3. controlpoint hovered: blue

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=381917

--- Comment #2 from Dmitry Kazakov  ---
Created attachment 110847
  --> https://bugs.kde.org/attachment.cgi?id=110847&action=edit
Screenshot for color scheme

Basically, if someone provides me with colors for the node types (see attached
screenshot), I will easily translate it into code:

Color 1) Node point, which control point is hovered
Color 2) Hovered point color
Color 3) Non-hovered point or control point

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=381917

--- Comment #1 from Dmitry Kazakov  ---
Created attachment 110845
  --> https://bugs.kde.org/attachment.cgi?id=110845&action=edit
Proposed patch

The patch does:
1) Highlights only the point (control point) that is actually hovered

The patch does not:
1) Not highlight the node point of the currently hovered control point (needs
color choice)
2) Not fix color-blinded people problem (needs color choice)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2018-02-12 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=381917

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 381917] Control points are very hard to select when they are occupying nearly the same space as their node.

2017-11-27 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=381917

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||b...@valdyas.org
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.