[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-09-14 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

Tymond  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/542da22bbbdcdb |krita/commit/a2a86bd9a7c0c5
   |68e015bdb3b47e3f46c83c6214  |95fa6f7e6a7bcfb44144c00e4c

--- Comment #8 from Tymond  ---
Git commit a2a86bd9a7c0c595fa6f7e6a7bcfb44144c00e4c by Agata Cacko.
Committed on 14/09/2019 at 15:25.
Pushed by tymond into branch 'krita/4.2'.

Fix curve changing with sensors w/ Use Same Curve

Before this commit, curve would change semi-randomly in some cases
if you change from some specific sensors to some other specific sensors
(having a complex curve and clicking randomly should show a bug though)
when "Share curve across all settings" is selected.
This commit fixes that behaviour.
Related: bug 410158

M  +3-3libs/global/kis_signal_compressor.h
M  +18   -1libs/ui/widgets/kis_curve_widget.cpp
M  +17   -0libs/ui/widgets/kis_curve_widget.h
M  +6-2libs/ui/widgets/kis_curve_widget_p.h
M  +4-0plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +27   -22   plugins/paintops/libpaintop/kis_curve_option.cpp
M  +6-2plugins/paintops/libpaintop/kis_curve_option.h
M  +35   -15   plugins/paintops/libpaintop/kis_curve_option_widget.cpp
M  +5-2plugins/paintops/libpaintop/kis_curve_option_widget.h

https://invent.kde.org/kde/krita/commit/a2a86bd9a7c0c595fa6f7e6a7bcfb44144c00e4c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-09-13 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

Tymond  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/b915ac470f148a |krita/commit/542da22bbbdcdb
   |3f4787b1689865a0c4d434ca72  |68e015bdb3b47e3f46c83c6214
 Status|REOPENED|RESOLVED

--- Comment #7 from Tymond  ---
Git commit 542da22bbbdcdb68e015bdb3b47e3f46c83c6214 by Agata Cacko.
Committed on 13/09/2019 at 23:23.
Pushed by tymond into branch 'master'.

Fix curve changing with sensors w/ Use Same Curve

Before this commit, curve would change semi-randomly in some cases
if you change from some specific sensors to some other specific sensors
(having a complex curve and clicking randomly should show a bug though)
when "Share curve across all settings" is selected.
This commit fixes that behaviour.
Related: bug 410158

M  +3-3libs/global/kis_signal_compressor.h
M  +18   -1libs/ui/widgets/kis_curve_widget.cpp
M  +17   -0libs/ui/widgets/kis_curve_widget.h
M  +6-2libs/ui/widgets/kis_curve_widget_p.h
M  +4-0plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +27   -22   plugins/paintops/libpaintop/kis_curve_option.cpp
M  +6-2plugins/paintops/libpaintop/kis_curve_option.h
M  +35   -15   plugins/paintops/libpaintop/kis_curve_option_widget.cpp
M  +5-2plugins/paintops/libpaintop/kis_curve_option_widget.h

https://invent.kde.org/kde/krita/commit/542da22bbbdcdb68e015bdb3b47e3f46c83c6214

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-08-15 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

--- Comment #6 from Tymond  ---
Created attachment 122145
  --> https://bugs.kde.org/attachment.cgi?id=122145=edit
Brush B

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-08-15 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

--- Comment #5 from Tymond  ---
Created attachment 122144
  --> https://bugs.kde.org/attachment.cgi?id=122144=edit
Brush A

I believe the fix I provided is only partial. Before when you switched to
another preset, it would turned to the default curve. Now it won't switch to
another curve, but still if you switch between some specific sensors, then
because of the mismatch of ranges in the curve it will change the curve anyway.

I still can see at least two issues:

Brush A: if you go to Rotation and then switch between Fuzzy Dab, then Drawing
Angle, then again Fuzzy Dab, the curve will change.

Brush B: if you go to Size and switch between Pressure, Drawing Angle and then
Pressure again, it will mark the brush as "modified" even though the curve
doesn't change.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-08-15 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

Tymond  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-08-15 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=383909

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/47a5716210f2f3 |krita/commit/b915ac470f148a
   |0c3ae4c9ff22e590d1a25b877a  |3f4787b1689865a0c4d434ca72

--- Comment #4 from Boudewijn Rempt  ---
Git commit b915ac470f148a3f4787b1689865a0c4d434ca72 by Boudewijn Rempt, on
behalf of Agata Cacko.
Committed on 15/08/2019 at 07:46.
Pushed by rempt into branch 'krita/4.2'.

Fix curve change despite 'Use same curve' checked

Before this commit, if you have a preset like Fill_circle
that has "Use the same curve" checkbox checked and you were
clicking on other sensors, the curve would be back to the default
curve (the one that other sensors had) if you switch back and forth
between some sensors (like Pressure -> X-Tilt-> Pressure).

Also before this commit if you have the default uprising curve
and you switched Rotation -> Tilt elevation, the curve would change.

This commit fixes both behaviours (first by adding transferCurve(),
second by switching the line in kis_curve_widget).

This commit also includes two slot functions instead of one function
that were used as a slot for two different signals. It helps with
debugging signals and keeping stuff clear and ordered.

There is one problem left: if you switch Tilt elevation -> Distance
(using the 'hill' curve), the preset is set to modified even though
the curve doesn't change.
BACKPORT:krita/4.2

M  +1-1libs/ui/widgets/kis_curve_widget.cpp
M  +18   -2plugins/paintops/libpaintop/kis_curve_option_widget.cpp
M  +3-0plugins/paintops/libpaintop/kis_curve_option_widget.h

https://invent.kde.org/kde/krita/commit/b915ac470f148a3f4787b1689865a0c4d434ca72

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-08-14 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

Tymond  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/47a5716210f2f3
   ||0c3ae4c9ff22e590d1a25b877a
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Tymond  ---
Git commit 47a5716210f2f30c3ae4c9ff22e590d1a25b877a by Agata Cacko.
Committed on 14/08/2019 at 19:49.
Pushed by tymond into branch 'master'.

Fix curve change despite 'Use same curve' checked

Before this commit, if you have a preset like Fill_circle
that has "Use the same curve" checkbox checked and you were
clicking on other sensors, the curve would be back to the default
curve (the one that other sensors had) if you switch back and forth
between some sensors (like Pressure -> X-Tilt-> Pressure).

Also before this commit if you have the default uprising curve
and you switched Rotation -> Tilt elevation, the curve would change.

This commit fixes both behaviours (first by adding transferCurve(),
second by switching the line in kis_curve_widget).

This commit also includes two slot functions instead of one function
that were used as a slot for two different signals. It helps with
debugging signals and keeping stuff clear and ordered.

There is one problem left: if you switch Tilt elevation -> Distance
(using the 'hill' curve), the preset is set to modified even though
the curve doesn't change.
BACKPORT:krita/4.2

M  +1-1libs/ui/widgets/kis_curve_widget.cpp
M  +18   -2plugins/paintops/libpaintop/kis_curve_option_widget.cpp
M  +3-0plugins/paintops/libpaintop/kis_curve_option_widget.h

https://invent.kde.org/kde/krita/commit/47a5716210f2f30c3ae4c9ff22e590d1a25b877a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2019-06-21 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=383909

Tymond  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com
 CC||tamtamy.tym...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2018-01-20 Thread mvowada
https://bugs.kde.org/show_bug.cgi?id=383909

mvowada  changed:

   What|Removed |Added

 CC||freebo...@tiscali.it

--- Comment #2 from mvowada  ---
(I can confirm on Ubuntu 14.04 - Krita 4.0.0-beta1.1.appimage)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2017-11-23 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=383909

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 383909] Checkbox «Share curve across all settings» doesn’t save the curve if it’s not changed

2017-08-23 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=383909

Boudewijn Rempt  changed:

   What|Removed |Added

   Severity|wishlist|normal
 CC||b...@valdyas.org

--- Comment #1 from Boudewijn Rempt  ---
Thanks, I'm changing this from Wish to Normal, though, since it does sound like
a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.