[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #15 from David REVOY  ---
s/Boys/Boud 
(autocorrect issue on smartphone 's keyboard, sorry)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #14 from David REVOY  ---
Thank you very much Boys!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=388976

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/0bb8b52570f54b
   ||d0a1b11d9309713edb0838d05f

--- Comment #13 from Boudewijn Rempt  ---
Git commit 0bb8b52570f54bd0a1b11d9309713edb0838d05f by Boudewijn Rempt.
Committed on 02/05/2019 at 10:22.
Pushed by rempt into branch 'master'.

Use KisDomUtils to read and write floats in gradients

M  +15   -14   libs/pigment/resources/KoSegmentGradient.cpp
M  +7-5libs/pigment/resources/KoStopGradient.cpp

https://invent.kde.org/kde/krita/commit/0bb8b52570f54bd0a1b11d9309713edb0838d05f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=388976

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #12 from David REVOY  ---
Created attachment 113608
  --> https://bugs.kde.org/attachment.cgi?id=113608=edit
[^ screenshot of the bug solved (workaround) with new locales]

@boud:  big thumb up! It is a local issue with numeric and XML as
Wolthera_laptop thought. It is now working after switching my numeric to US.
(proof in attachement). There is certainly a bad comma/dot conversion
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #11 from David REVOY  ---
@boud: good idea. I have a mix; English lang, but French
time/numeric/monetary... 

$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC=fr_FR.UTF-8
LC_TIME=fr_FR.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_MONETARY=fr_FR.UTF-8
LC_MESSAGES="en_US.UTF-8"
LC_PAPER=fr_FR.UTF-8
LC_NAME=fr_FR.UTF-8
LC_ADDRESS=fr_FR.UTF-8
LC_TELEPHONE=fr_FR.UTF-8
LC_MEASUREMENT=fr_FR.UTF-8
LC_IDENTIFICATION=fr_FR.UTF-8
LC_ALL=

Could it be a problem of numeric? French write them 0,5 instead of 0.5; maybe
this could lead the XML of the filter to reset all the offset to 0 if it tries
to write them in respect to my locale, with comma...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #10 from Boudewijn Rempt  ---
Could it be a localisation issue? Deevad, is your system set to French?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #9 from wolthera  ---
So, there's something weird going on with the serialisation of the gradient
into xml.

What that means is that on my system, it does always store the offsets
properly, but they seem to get lost on deevad's system.

My system:
--

Krita
  Version: 4.2.0-pre-alpha (git cb3736e)

OS Information
  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.13.0-45-generic
  Pretty Productname: Ubuntu 17.10
  Product Type: ubuntu
  Product Version: 17.10

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #8 from David REVOY  ---
I wonder if it is not a bug related to a bug in Little CMS; I'm using:

> Found lcms version 2.08, /usr/lib/x86_64-linux-gnu/liblcms2.so

I'll try to build a newer version of liblcms, and rebuild Krita after that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Paul]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #7 from Paul  ---
Hi,

Like David I am also working on Linux. I am using the appimage of Krita 4.0.0.

Seems that this bug is specific to Linux.

Rgds,
Paul

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=388976

vanyossi  changed:

   What|Removed |Added

 CC||ghe...@gmail.com

--- Comment #6 from vanyossi  ---
Created attachment 113498
  --> https://bugs.kde.org/attachment.cgi?id=113498=edit
testing gradient map with 3 stops

I could not reproduce this bug, neither in master nor in 4.0.4 on the Mac
builds.

I tested in many color spaces and bit depths and the resulting gradient map
image is shown correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #5 from David REVOY  ---
I still can confirm this bug in Git~master of today. 
New information:

Gradient with only two color markers will work:
eg:
https://www.peppercarrot.com/extras/temp/2018-06-13_screenshot_164426_net.jpg

If a third color or more is introduced, this new colors will be ignored:
eg:
https://www.peppercarrot.com/extras/temp/2018-06-13_screenshot_164537_net.jpg

The two markers on right of the gradient are the only color affecting the
gradient applied on canvas.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

David REVOY  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=388976

--- Comment #4 from David REVOY  ---
Created attachment 112837
  --> https://bugs.kde.org/attachment.cgi?id=112837=edit
[^ screenshot of the bug: Krita 4.0.3appimage ]

Hi Paul, 
Thanks for poking this bug-report.
I could easily reproduce it with Krita 4.0.3 appimage and with Krita~master
(git a0899ca) on Linux using the same PNG as in the first post of this thread.
(see screenshot in attachment). The default rainbow gradient is a good gradient
to test this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Paul]

https://bugs.kde.org/show_bug.cgi?id=388976

Paul  changed:

   What|Removed |Added

 CC||paul.gie...@gmail.com

--- Comment #3 from Paul  ---
FYI I have the same issue as David. The gradient seems to map only between the
gradient stops corresponding to the two lightest values.

Example:

https://drive.google.com/open?id=1j-WbGxKMJ57JnUqdbO_oeXB2LXsKiHZY
 - only the green to red part of the spectrum is mapped
 - blue to green part of the spectrum is ignored

To reproduce:
=
1. Create a white to black spectrum
2. Add a gradient map filter with at least 3 stops

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=388976

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #2 from Boudewijn Rempt  ---
Created attachment 109927
  --> https://bugs.kde.org/attachment.cgi?id=109927=edit
boud's result

Hm, I get a completely different result from Deevad; but the same result both
with the beta 1 appimage and my master build

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388976] [Gradient Map Filter] color mapping issue

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=388976

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com

--- Comment #1 from wolthera  ---
I can reproduce it on the appimage, but not my local build, which makes it near
impossible for me to figure out what is going on...

-- 
You are receiving this mail because:
You are watching all bug changes.