[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/b832b5f508c6f2378e47732f |ta/39e28e703aa8144c403c1ee5
   |7615bd13fa41a48d|3afc47c0121908c1

--- Comment #10 from Boudewijn Rempt  ---
Git commit 39e28e703aa8144c403c1ee53afc47c0121908c1 by Boudewijn Rempt.
Committed on 11/04/2018 at 17:25.
Pushed by rempt into branch 'rempt/update-frameworks'.

Fix build on ARM (partly)

M  +1-1CMakeLists.txt

https://commits.kde.org/krita/39e28e703aa8144c403c1ee53afc47c0121908c1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/d3eb595b444d5b1981894044 |ta/b832b5f508c6f2378e47732f
   |48e93121d7796d17|7615bd13fa41a48d

--- Comment #9 from Boudewijn Rempt  ---
Git commit b832b5f508c6f2378e47732f7615bd13fa41a48d by Boudewijn Rempt.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Fix build on ARM (partly)
(cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1)
(cherry picked from commit 55e1d8deaf98721ed3fdaf72e4a6f942ea5b93a7)

M  +1-1CMakeLists.txt

https://commits.kde.org/krita/b832b5f508c6f2378e47732f7615bd13fa41a48d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

--- Comment #8 from Boudewijn Rempt  ---
Yes, definitely.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=393010

--- Comment #7 from Wolfgang Bauer  ---
Thanks.

FYI:
The other build failure I mentioned (related to OpenGL) may be related to how
Qt is built on openSUSE AFAIK.
Our ARM guys are aware of the issue though, I'll let them handle it.

I just noticed this new problem when I updated krita today, and thought it was
a good idea to get it fixed. ;-)

And IMHO, it just seems logical to have config-vc.h created in any case, as
that defines HAVE_VC for the rest of the source.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/d3eb595b444d5b1981894044
   ||48e93121d7796d17
 Resolution|--- |FIXED

--- Comment #5 from Boudewijn Rempt  ---
Git commit d3eb595b444d5b198189404448e93121d7796d17 by Boudewijn Rempt.
Committed on 11/04/2018 at 17:26.
Pushed by rempt into branch 'master'.

Fix build on ARM (partly)
(cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1)

M  +1-1CMakeLists.txt

https://commits.kde.org/krita/d3eb595b444d5b198189404448e93121d7796d17

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

--- Comment #6 from Boudewijn Rempt  ---
Thanks. I've pushed that change.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=393010

Wolfgang Bauer  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |UNCONFIRMED

--- Comment #4 from Wolfgang Bauer  ---
Confirmed.

This patch gets rid of the error:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bef818bc0f..f8658a11d1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -630,8 +630,8 @@ if (NOT ${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
 PURPOSE "Required by the Krita for vectorization")
 macro_bool_to_01(Vc_FOUND HAVE_VC)
 endif()
-configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )
 endif()
+configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )

 if(HAVE_VC)
 message(STATUS "Vc found!")

The build still fails, but that's a different story, something related to
OpenGL... (that happened before)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

--- Comment #3 from Boudewijn Rempt  ---
Yes, I mean that you should try the change moving the line. I cannot test with
arm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=393010

--- Comment #2 from Wolfgang Bauer  ---
(In reply to Boudewijn Rempt from comment #1)
> Did you try that change? If so, we can simply push it.

I don't understand, that change is already in 4.0.1, it causes the failure
AFAICT.

Or do you mean I should try to move the line below the endif()?
Haven't done that yet, but will.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 393010] Krita 4.0.1 fails to build on armv7l

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=393010

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||b...@valdyas.org

--- Comment #1 from Boudewijn Rempt  ---
Did you try that change? If so, we can simply push it.

-- 
You are receiving this mail because:
You are watching all bug changes.