[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2021-09-24 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=399419

Tiar  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/0da91363b |hics/krita/commit/476806ba2
   |998f02deb309f3581b1a88aa8a6 |007faaad18df7fc9fa57dd4c3be
   |1edb|9290

--- Comment #9 from Tiar  ---
Git commit 476806ba2007faaad18df7fc9fa57dd4c3be9290 by Agata Cacko.
Committed on 24/09/2021 at 13:45.
Pushed by tymond into branch 'krita/5.0'.

Fix Show Painting Assistants to update correctly

Before this commit, if you opened two files with assistants,
and in one turned the View -> Show Painting Assistants off,
and then switch to the other file and to that same file again,
the View -> Show Painting Assistant would be "on" even though
the painting assistants wouldn't be drawn on the canvas
(only preview would be visible). And then switching it off
would actually turn the drawing of the assistants on.

Another way to reproduce this issue would be to open a new document,
create a new assistant, turn off Show Painting Assistant,
then create a new assistant. Show Painting Assistant now looks "on"
but the drawing of the assistants is still actually off (which is
correct and it's just the checkbox that should stay "off").

This commit fixes this behaviour and now the checkbox in the View menu
reflects correctly the current state of drawing the assistant.
Related: bug 417792

M  +1-1libs/ui/KisDecorationsManager.cpp
M  +1-0libs/ui/kis_painting_assistants_decoration.cpp

https://invent.kde.org/graphics/krita/commit/476806ba2007faaad18df7fc9fa57dd4c3be9290

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2021-09-22 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=399419

Tiar  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/0da91363b
   ||998f02deb309f3581b1a88aa8a6
   ||1edb
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Tiar  ---
Git commit 0da91363b998f02deb309f3581b1a88aa8a61edb by Agata Cacko.
Committed on 22/09/2021 at 11:57.
Pushed by tymond into branch 'master'.

Fix Show Painting Assistants to update correctly

Before this commit, if you opened two files with assistants,
and in one turned the View -> Show Painting Assistants off,
and then switch to the other file and to that same file again,
the View -> Show Painting Assistant would be "on" even though
the painting assistants wouldn't be drawn on the canvas
(only preview would be visible). And then switching it off
would actually turn the drawing of the assistants on.

Another way to reproduce this issue would be to open a new document,
create a new assistant, turn off Show Painting Assistant,
then create a new assistant. Show Painting Assistant now looks "on"
but the drawing of the assistants is still actually off (which is
correct and it's just the checkbox that should stay "off").

This commit fixes this behaviour and now the checkbox in the View menu
reflects correctly the current state of drawing the assistant.
Related: bug 417792

M  +1-1libs/ui/KisDecorationsManager.cpp
M  +1-0libs/ui/kis_painting_assistants_decoration.cpp

https://invent.kde.org/graphics/krita/commit/0da91363b998f02deb309f3581b1a88aa8a61edb

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2021-09-21 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=399419

Tiar  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
 CC||tamtamy.tym...@gmail.com
   Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2020-05-04 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399419

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2019-08-27 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=399419

Emmet O'Neill  changed:

   What|Removed |Added

   Assignee|emmetoneill@gmail.com   |krita-bugs-n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-11 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399419

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |emmetoneill@gmail.com

--- Comment #7 from Boudewijn Rempt  ---
Emmet is going to take a stab at reproducing it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-10 Thread mvowada
https://bugs.kde.org/show_bug.cgi?id=399419

mvowada  changed:

   What|Removed |Added

 CC||freebo...@tiscali.it

--- Comment #6 from mvowada  ---
(In reply to Boudewijn Rempt from comment #4)
> That
> looks like an interesting comic, btw...

Oh yes, agree :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-10 Thread Autumn Lansing
https://bugs.kde.org/show_bug.cgi?id=399419

--- Comment #5 from Autumn Lansing  ---
Thanks. :) It's currently a work in progress.

I played around with it more today in various scenarios, and the bug happens
every single time in the exact way that I described. I'm unsure what might be
different in my setup that would cause it. It's not a critical bug, though, by
any means. It's just an annoyance. I'll add to the report if I discover any new
facts or if it stops happening in a new version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-09 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399419

--- Comment #4 from Boudewijn Rempt  ---
Right... But I still don't know how to reproduce it for myself :-). That looks
like an interesting comic, btw...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-09 Thread Autumn Lansing
https://bugs.kde.org/show_bug.cgi?id=399419

--- Comment #3 from Autumn Lansing  ---
Created attachment 115523
  --> https://bugs.kde.org/attachment.cgi?id=115523&action=edit
Image of painting assistant bug

Here's an image of the bug. You'll notice that the assistants are visible even
though the view option is toggled off.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-09 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399419

Boudewijn Rempt  changed:

   What|Removed |Added

   Keywords||triaged
 CC||b...@valdyas.org

--- Comment #2 from Boudewijn Rempt  ---
Hi Autumn,

I'm also not able to reproduce this, I'm afraid. Using sessions shouldn't be
related in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399419] Show Painting Assistants toggle is inconsistent between windows

2018-10-06 Thread vanyossi
https://bugs.kde.org/show_bug.cgi?id=399419

vanyossi  changed:

   What|Removed |Added

 CC||ghe...@gmail.com

--- Comment #1 from vanyossi  ---
I cannot reproduce this in OSX

-- 
You are receiving this mail because:
You are watching all bug changes.