[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2020-07-28 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=404519

Eoin O'Neill  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/d76c59fca |hics/krita/commit/68a0cf3e3
   |3fad96ddf299b4f36d951fb1010 |2e6ad857ac275a65a5719930bad
   |5259|74cd

--- Comment #7 from Eoin O'Neill  ---
Git commit 68a0cf3e32e6ad857ac275a65a5719930bad74cd by Eoin O'Neill.
Committed on 29/07/2020 at 03:42.
Pushed by eoinoneill into branch 'master'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold
Frames.

Related Feature: Preserve multi-frame selection when active frame changes.
Useful
for preserving the users selection on scrub, but also less error-prone when
dealing
with modifying the user selection while concurrent "switch-time" operation is
running.

Insert Keyframe Bug:
Related: bug 388779

Maintain Multiframe Selection Wishlist:

(commit cherry-picked from krita/4.3 d76c59fca3fad96ddf299b4f36d951fb10105259)

M  +1-1plugins/dockers/animation/timeline_frames_model.cpp
M  +1-1plugins/dockers/animation/timeline_frames_model.h
M  +36   -0plugins/dockers/animation/timeline_frames_view.cpp
M  +1-0plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/68a0cf3e32e6ad857ac275a65a5719930bad74cd

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2020-07-28 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=404519

Eoin O'Neill  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/d76c59fca
   ||3fad96ddf299b4f36d951fb1010
   ||5259

--- Comment #6 from Eoin O'Neill  ---
Git commit d76c59fca3fad96ddf299b4f36d951fb10105259 by Eoin O'Neill.
Committed on 29/07/2020 at 03:40.
Pushed by eoinoneill into branch 'krita/4.3'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold
Frames.

Related Feature: Preserve multi-frame selection when active frame changes.
Useful
for preserving the users selection on scrub, but also less error-prone when
dealing
with modifying the user selection while concurrent "switch-time" operation is
running.

Insert Keyframe Bug:
Related: bug 388779

Maintain Multiframe Selection Wishlist:

M  +1-1plugins/dockers/animation/timeline_frames_model.cpp
M  +1-1plugins/dockers/animation/timeline_frames_model.h
M  +37   -1plugins/dockers/animation/timeline_frames_view.cpp
M  +1-0plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/d76c59fca3fad96ddf299b4f36d951fb10105259

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2020-07-28 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=404519

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com
   Assignee|joup...@gmail.com   |eoinoneill1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2020-07-28 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=404519

--- Comment #5 from Eoin O'Neill  ---
I'm going to address this issue now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2019-09-27 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=404519

wolthera  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |joup...@gmail.com
 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from wolthera  ---
Assigning this to Tyyppi

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2019-09-21 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=404519

wolthera  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from wolthera  ---
Yeah, seeing it now, I can confirm this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2019-03-13 Thread Bollebib
https://bugs.kde.org/show_bug.cgi?id=404519

Bollebib  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #2 from Bollebib  ---
https://www.youtube.com/watch?v=VuL3ZRMttsg=youtu.be



It still happens in today's nightly

At a certain moment I DID get to keep the selection. But then another issue
arose


if you ADD to the selection
then the later selected frames go out of bounds of the selection

The selection should grow and shrink with the frames for the most consitant
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 404519] Adding Hold Frames to a horizontal range often removes selection

2019-03-06 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=404519

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com
   Keywords||triaged
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from wolthera  ---
I can't reproduce this in the nightly builds, can you?

-- 
You are receiving this mail because:
You are watching all bug changes.