[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/eb61160966ddc7 |krita/commit/94065177379800 |94cfd02a9225e577f0844e51e0 |0c7fcdc7e6d811f52fe4c2a117 --- Comment #16 from Boudewijn Rempt --- Git commit 940651773798000c7fcdc7e6d811f52fe4c2a117 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 13/06/2019 at 05:59. Pushed by rempt into branch 'krita/4.2'. Fix a crash when creating a text shape Every KoShapeController used to reset the global "shape document" in its KoDocumentResourceManager. The problem is that in Krita we have multiple KoShapeController-s, but the resource manager is the only one. It means that every shape selection or shape layer used to reset the pointer to the global "shape document" to its own one. The only reason why we didn't have too many crashes is that almost noone uses this "shape document". Ideally we should: 1) Remove KoDocumentResourceManager::GlobalShapeController resource. This resource is not global to the document, but is created per-layer. The only user of it atm is the legacy text tool, which should be deprecated. 2) Remove KoDocumentResourceManager at all. There is no much use of it anymore. Its main user is legacy text tool. M +18 -5libs/flake/KoDocumentResourceManager.cpp M +13 -3libs/flake/KoDocumentResourceManager.h M +0-3libs/flake/KoShapeController.cpp M +1-1libs/flake/KoShapeRegistry.cpp M +1-1libs/flake/tests/TestKoShapeRegistry.cpp M +2-4libs/flake/text/KoSvgTextShape.cpp M +9-6libs/ui/KisDocument.cpp M +1-1libs/ui/flake/kis_dummies_facade_base.h M +26 -0libs/ui/flake/kis_shape_controller.cpp M +6-0libs/ui/flake/kis_shape_controller.h M +1-1plugins/flake/textshape/TextShapeFactory.cpp https://invent.kde.org/kde/krita/commit/940651773798000c7fcdc7e6d811f52fe4c2a117 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Dmitry Kazakov changed: What|Removed |Added CC||epicwraths...@yandex.ru --- Comment #15 from Dmitry Kazakov --- *** Bug 408459 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/ ||krita/commit/eb61160966ddc7 ||94cfd02a9225e577f0844e51e0 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #14 from Dmitry Kazakov --- Git commit eb61160966ddc794cfd02a9225e577f0844e51e0 by Dmitry Kazakov. Committed on 07/06/2019 at 10:46. Pushed by dkazakov into branch 'master'. Fix a crash when creating a text shape Every KoShapeController used to reset the global "shape document" in its KoDocumentResourceManager. The problem is that in Krita we have multiple KoShapeController-s, but the resource manager is the only one. It means that every shape selection or shape layer used to reset the pointer to the global "shape document" to its own one. The only reason why we didn't have too many crashes is that almost noone uses this "shape document". Ideally we should: 1) Remove KoDocumentResourceManager::GlobalShapeController resource. This resource is not global to the document, but is created per-layer. The only user of it atm is the legacy text tool, which should be deprecated. 2) Remove KoDocumentResourceManager at all. There is no much use of it anymore. Its main user is legacy text tool. M +18 -5libs/flake/KoDocumentResourceManager.cpp M +13 -3libs/flake/KoDocumentResourceManager.h M +0-3libs/flake/KoShapeController.cpp M +1-1libs/flake/KoShapeRegistry.cpp M +1-1libs/flake/tests/TestKoShapeRegistry.cpp M +2-4libs/flake/text/KoSvgTextShape.cpp M +9-6libs/ui/KisDocument.cpp M +1-1libs/ui/flake/kis_dummies_facade_base.h M +26 -0libs/ui/flake/kis_shape_controller.cpp M +6-0libs/ui/flake/kis_shape_controller.h M +1-1plugins/flake/textshape/TextShapeFactory.cpp https://invent.kde.org/kde/krita/commit/eb61160966ddc794cfd02a9225e577f0844e51e0 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #13 from Boudewijn Rempt --- Are you sure; the duplicate was on Kubuntu and the backtrace looked very similar. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #12 from Dmitry Kazakov --- This bug is Windows-only. It is not reproducible on Linux, but is reproducible on Windows -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Dmitry Kazakov changed: What|Removed |Added Keywords||release_blocker -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Boudewijn Rempt changed: What|Removed |Added CC||soli...@outlook.com --- Comment #11 from Boudewijn Rempt --- *** Bug 408276 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Boudewijn Rempt changed: What|Removed |Added Severity|normal |crash --- Comment #10 from Boudewijn Rempt --- I've asked Dmitry to take a look, but he's taking a few days off after the pre-release hectics. We'll try to have a fix for this in 4.2.1. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #9 from acc4commissi...@gmail.com --- It seems that you don't have to autosave the document... Make a selection > Save or Autosave > Stay or Deselect (Either ways it crashes) > Create a text > Crash And it doesn't seem to affect the other documents in current krita instance. The problem happens only in the document that the selection-save action has been done in. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Boudewijn Rempt changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #8 from acc4commissi...@gmail.com --- (In reply to acc4commissions from comment #6) > I don't know what happened but it doesn't seem to crash anymore in the > lastest nightly. (git 28fed10) I apologize. I mistook an old 4.1.7 nightly for the new 4.2 one. I'm really sorry for being idiotic on this. I'll think twice before repoting anything. :/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #7 from acc4commissi...@gmail.com --- (In reply to acc4commissions from comment #6) > I don't know what happened but it doesn't seem to crash anymore in the > lastest nightly. (git 28fed10) Still crash in the beta version though. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #6 from acc4commissi...@gmail.com --- I don't know what happened but it doesn't seem to crash anymore in the lastest nightly. (git 28fed10) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #5 from acc4commissi...@gmail.com --- It seems you don't need to hold your mouse button. Just 1. Make a selection 2. Autosave 3. Create a text always leads to crash. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 Boudewijn Rempt changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||b...@valdyas.org Ever confirmed|0 |1 --- Comment #4 from Boudewijn Rempt --- Good catch... I can reproduce the issue. Linux backtrace: Thread 1 "krita" received signal SIGSEGV, Segmentation fault. 0x725a7677 in QMetaObject::cast(QObject const*) const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 (gdb) bt #0 0x725a7677 in QMetaObject::cast(QObject const*) const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #1 0x7fffeef2ff16 in qobject_cast (object=) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:504 #2 QtPrivate::QVariantValueHelper::object (v=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvariant.h:734 #3 QtPrivate::ObjectInvoker, QVariant const&, KoShapeController*>::invoke (a=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvariant.h:106 #4 qvariant_cast (v=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvariant.h:860 #5 QVariant::value (this=0x7fffc090) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvariant.h:362 #6 KoDocumentResourceManager::shapeController (this=this@entry=0x603001c68d00) at /home/boud/dev/krita/libs/flake/KoDocumentResourceManager.cpp:193 #7 0x7fffef0c28ec in KoSvgTextShapeFactory::createShape (this=this@entry=0x603002200990, params=params@entry=0x60200037a770, documentResources=0x603001c68d00) at /home/boud/dev/krita/libs/flake/text/KoSvgTextShape.cpp:620 #8 0x7fffb73b37e6 in SvgTextTool::mouseReleaseEvent (this=0x60e4e1c0, event=0x7fffc2b0) at /home/boud/dev/krita/plugins/tools/svgtexttool/SvgTextTool.cpp:383 #9 0x7fffeefa150e in KoToolProxy::mouseReleaseEvent (this=this@entry=0x6140010b26a0, event=event@entry=0x7fffc2b0) at /home/boud/dev/krita/libs/flake/KoToolProxy.cpp:316 #10 0x7fffeefa1a4f in KoToolProxy::mouseReleaseEvent (this=0x6140010b26a0, event=, point=...) at /home/boud/dev/krita/libs/flake/KoToolProxy.cpp:305 #11 0x75841d96 in KisToolProxy::forwardEvent (this=0x6140010b26a0, state=state@entry=KisToolProxy::END, action=action@entry=KisTool::Primary, event=event@entry=0x7fffccc0, originalEvent=originalEvent@entry=0x7fffccc0) at /home/boud/dev/krita/libs/ui/canvas/kis_tool_proxy.cpp:134 #12 0x75c1e7be in KisToolInvocationAction::end (this=0x6030029f3f80, event=0x7fffccc0) at /home/boud/dev/krita/libs/ui/input/kis_tool_invocation_action.cpp:152 #13 0x75c2cc0f in KisShortcutMatcher::tryEndRunningShortcut (this=0x6110009de0b0, button=, event=0x7fffccc0) at /home/boud/dev/krita/libs/ui/input/kis_shortcut_matcher.cpp:568 #14 0x75c2d5f5 in KisShortcutMatcher::buttonReleased (this=0x6110009de0b0, button=, event=event@entry=0x7fffccc0) at /home/boud/dev/krita/libs/ui/input/kis_shortcut_matcher.cpp:233 #15 0x75c0c474 in KisInputManager::eventFilterImpl (this=0x61a6cb58, event=0x7fffccc0) at /home/boud/dev/krita/libs/ui/input/kis_input_manager.cpp:331 #16 0x7259e0ad in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #17 0x73394885 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #18 0x7339cd18 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #19 0x75c9a9c7 in KisApplication::notify (this=, receiver=0x60700093ec60, event=0x7fffccc0) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #20 0x7259e328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #21 0x7339b30f in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool, bool) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #22 0x733efaf0 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #23 0x733f257a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #24 0x733948ac in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #25 0x7339be40 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #26 0x75c9a9c7 in KisApplication::notify (this=, receiver=0x608000120520, event=0x7fffd1c0) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #27 0x7259e328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () ---Type to continue, or q to quit--- from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #28 0x72b6652b in
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #3 from acc4commissi...@gmail.com --- (In reply to acc4commissions from comment #2) > There has been a few backtraces on text tool crash starts with > "krita.exe caused an Access Violation at location DEP > violation at location ." > and not > "krita.exe caused an Access Violation at location 07FECE7C5687 in module > Qt5Core.dll Reading from location 036E." -which is always the > case when I make the krita crash in this particular way, but I wouldn't know > what it says... :/ * Oops, the "from location ." varies. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #2 from acc4commissi...@gmail.com --- There has been a few backtraces on text tool crash starts with "krita.exe caused an Access Violation at location DEP violation at location ." and not "krita.exe caused an Access Violation at location 07FECE7C5687 in module Qt5Core.dll Reading from location 036E." -which is always the case when I make the krita crash in this particular way, but I wouldn't know what it says... :/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407554] Crashed when creating a text after autosaving on a document has a selection somewhere
https://bugs.kde.org/show_bug.cgi?id=407554 --- Comment #1 from acc4commissi...@gmail.com --- A backtrace : Error occurred on Wednesday, May 15, 2019 at 19:22:23. krita.exe caused an Access Violation at location 07FECE7C5687 in module Qt5Core.dll Reading from location 036E. AddrPC Params 07FECE7C5687 0022B198 07FE0006 0006 Qt5Core.dll!0x205687 QMetaObject::cast+0x17 07FEC2438A51 30EFAA50 07FEFEEA13D2 0002 libkritaflake.dll!0x8a51 KoDocumentResourceManager::shapeController+0x61 07FEC2527F7B 0022B378 007D 1C9FD630 libkritaflake.dll!0xf7f7b KoSvgTextShapeFactory::createShape+0x26b 07FEBDEFE631 0022B3C0 0022B3C0 3FF0 krita_tool_svgtext.dll!0xe631 SvgTextTool::mouseReleaseEvent+0x411 07FEC2480F10 8000 C095022F89F8E580 libkritaflake.dll!0x50f10 KoToolProxy::mouseReleaseEvent+0x60 07FEC24813C1 0001 07FEC16C4EB8 00484148 libkritaflake.dll!0x513c1 KoToolProxy::mouseReleaseEvent+0x21 07FEC01F54F3 1CB74470 1C78C8F0 18E42E10 libkritaui.dll!0x154f3 KisToolProxy::forwardEvent+0x193 07FEC044A94E 135C 0001 1CBA1780 libkritaui.dll!0x26a94e KisToolInvocationAction::end+0xae 07FEC0455E70 0F0B9050 00010003 3D1402C00201 libkritaui.dll!0x275e70 KisShortcutMatcher::tryEndRunningShortcut+0x70 07FEC0457DB5 07FE0001 0F0B9050 libkritaui.dll!0x277db5 KisShortcutMatcher::buttonReleased+0x215 07FEC04439A7 0CAEC160 07FECE650D90 0022B6F0 libkritaui.dll!0x2639a7 KisInputManager::eventFilterImpl+0x667 07FECE7BAA70 0022FBB0 0001 18E42E10 Qt5Core.dll!0x1faa70 QCoreApplication::applicationVersionChanged+0x1a0 07FEC1687BB5 0CAEA9E0 0003 02DF01F5 Qt5Widgets.dll!0x7bb5 QApplicationPrivate::notify_helper+0x75 07FEC168FC5A 07FECE5E215F Qt5Widgets.dll!0xfc5a QApplication::notify+0x13aa 07FEC049D9F6 3FF0 C0438000 libkritaui.dll!0x2bd9f6 KisApplication::notify+0x16 07FECE7BC0C8 3FF0 Qt5Core.dll!0x1fc0c8 QCoreApplication::sendSpontaneousEvent+0x1a8 07FEC168E058 006A0B18 0215 Qt5Widgets.dll!0xe058 QApplicationPrivate::sendMouseEvent+0x208 07FEC16DAA5D 07870E40 07FECE7BA971 Qt5Widgets.dll!0x5aa5d QDesktopWidget::qt_metacall+0x2a1d 07FEC16DD7E3 0022FBB0 023803B0 0001 Qt5Widgets.dll!0x5d7e3 QDesktopWidget::qt_metacall+0x57a3 07FEC1687BDC 0068 0068 003102E8 Qt5Widgets.dll!0x7bdc QApplicationPrivate::notify_helper+0x9c 07FEC168EC63 19E042D0 07FECE5E215F 0244ECD0 Qt5Widgets.dll!0xec63 QApplication::notify+0x3b3 07FEC049D9F6 0001 07FECEC4AD54 libkritaui.dll!0x2bd9f6 KisApplication::notify+0x16 07FECE7BC0C8 0202 Qt5Core.dll!0x1fc0c8 QCoreApplication::sendSpontaneousEvent+0x1a8 07FECEC37228 0022C428 07FECE7C1E82 0001 Qt5Gui.dll!0x37228 QGuiApplicationPrivate::processMouseEvent+0x858 07FECEC38465 0248E520 02380450 003B0B9A Qt5Gui.dll!0x38465 QGuiApplicationPrivate::processWindowSystemEvent+0x105 07FECEC103FC 772A6AF8 003B0B9A 0401 Qt5Gui.dll!0x103fc QWindowSystemInterface::sendWindowSystemEvents+0x44c 07FECE81689A 0038 0022C608 Qt5Core.dll!0x25689a QEventDispatcherWin32Private::sendTimerEvent+0x60a 77169BBD 0022C720 07FECE8163C0 USER32.dll!0x19bbd UserCallWinProcCheckWow+0x1ad 771698C2 0022C720 0022C720 07FECE8163C0 USER32.dll!0x198c2 DispatchMessageWorker+0x3b5 07FECE815D4B 02380450 0024 02448B20 Qt5Core.dll!0x255d4b QEventDispatcherWin32::processEvents+0x5db 6A8FB7D5 0080 0014 1C4FD4D0 qwindows.dll!0x7b7d5 qt_plugin_instance+0x2e15 07FECE7BA14F 07FEECA4CE60 07FEC1D2DA30 0022FB70 Qt5Core.dll!0x1fa14f QEventLoop::exec+0x13f 07FECE7C3417 0022FC00 0022FBB0 0008 Qt5Core.dll!0x203417 QCoreApplication::exec+0x77 000140006EE3 0001 023801B0 000140F7A978 krita.exe!0x6ee3 main+0x2143 0001400013C7 krita.exe!0x13c7 __tmainCRTStartup+0x247 0001400014CB krita.exe!0x14cb WinMainCRTStartup+0x1b 7704556D kernel32.dll!0x1556d
