[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/d779201edad488 |krita/commit/7104885cf0904d |79034ffd2121a1a1a0f0679bfd |bfe03cd04346a3b46d2547effb Status|CONFIRMED |RESOLVED --- Comment #22 from Boudewijn Rempt --- Git commit 7104885cf0904dbfe03cd04346a3b46d2547effb by Boudewijn Rempt. Committed on 07/11/2019 at 13:54. Pushed by rempt into branch 'master'. Make KoColorSet safer when accessing color groups M +11 -9libs/pigment/resources/KoColorSet.cpp M +1-1libs/pigment/resources/KoColorSet.h https://invent.kde.org/kde/krita/commit/7104885cf0904dbfe03cd04346a3b46d2547effb -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 M changed: What|Removed |Added CC||manuel.snudl.zeidler@gmail. ||com --- Comment #21 from M --- Created attachment 123765 --> https://bugs.kde.org/attachment.cgi?id=123765=edit GDB backtrace So strangely enough, I can reliably produce a hang / crash when I choose the Pastel 5x2 or PixelArt 16 palettes in the filter with my build from master (git 33bc57f), but on the newest AppImage (also git 33bc57f) I only managed to provoke the same crash twice in about 10 restarted sessions. I'll attach my GDB backtace in any case. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 wolthera changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #20 from wolthera --- Uhm, gonna set this to confirmed if people are making bugfixes to it, at the very least. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Status|RESOLVED|REPORTED Resolution|FIXED |--- Ever confirmed|1 |0 --- Comment #19 from Boudewijn Rempt --- Let's just remove that assert :-) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #18 from krzysio.ku...@wp.pl --- The code in 4.2 branch will only crash in debug due to a misplaced Q_ASSERT, should I backport it anyway? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #17 from Boudewijn Rempt --- Yes, should be fixed in 9fd34885fcc808e4e5509105b5aed77e27d2e61b I couldn't backport this fix to the 4.2 branch, that code is missing there. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #16 from krzysio.ku...@wp.pl --- I've managed to identify the issue and it should be fixed in today's nightly. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387
--- Comment #15 from krzysio.ku...@wp.pl ---
This issue seems to be caused by multithreading and use of destroyed shared
resources.
The crash can be prevented by adding the following line to
`KisSwatchGroup::Private`:
~Private(){usleep(1);}
Somehow it causes just enough time to pass for crash not to occur, although
there's still artefacts caused by use of invalid resources.
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 krzysio.ku...@wp.pl changed: What|Removed |Added Assignee|b...@valdyas.org|krzysio.ku...@wp.pl Resolution|FIXED |--- Status|RESOLVED|REOPENED CC||krzysio.ku...@wp.pl -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #14 from Dmitry Kazakov --- Git commit 20f6d33754a44d9295dff1ee5573dabbfcb213e1 by Dmitry Kazakov, on behalf of Krzysztof Kurek. Committed on 21/09/2019 at 10:08. Pushed by dkazakov into branch 'krita/4.2'. Fix the TestKistSwatchGroup test KisSwatchGroup now inserts the new KisSwatch into the first position not containing a valid KisSwatch. M +14 -37 libs/pigment/resources/KisSwatchGroup.cpp M +3-3libs/pigment/tests/TestKisSwatchGroup.cpp https://invent.kde.org/kde/krita/commit/20f6d33754a44d9295dff1ee5573dabbfcb213e1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #13 from Dmitry Kazakov --- Git commit d0108d29965446c4667daa1ab13a99bd8ea4a495 by Dmitry Kazakov, on behalf of Krzysztof Kurek. Committed on 21/09/2019 at 09:15. Pushed by dkazakov into branch 'master'. Fix the TestKistSwatchGroup test KisSwatchGroup now inserts the new KisSwatch into the first position not containing a valid KisSwatch. M +14 -37 libs/pigment/resources/KisSwatchGroup.cpp M +3-3libs/pigment/tests/TestKisSwatchGroup.cpp https://invent.kde.org/kde/krita/commit/d0108d29965446c4667daa1ab13a99bd8ea4a495 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #12 from acc4commissi...@gmail.com --- It's still reproducable in the latest nightly... I'll post here when it's not anymore. A short crashlog : Error occurred on Wednesday, September 11, 2019 at 23:53:51. krita.exe caused an Access Violation at location 77422618 in module ntdll.dll Reading from location 0CB22D3A34C8. AddrPC Params 77422618 237D4C60 373EE800 6FD084C2 ntdll.dll -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/5be3887e747a16 |krita/commit/d779201edad488 |3d862c237d77cfa1e4f2a4e7af |79034ffd2121a1a1a0f0679bfd --- Comment #11 from Boudewijn Rempt --- Git commit d779201edad48879034ffd2121a1a1a0f0679bfd by Boudewijn Rempt. Committed on 10/09/2019 at 08:25. Pushed by rempt into branch 'krita/4.2'. Check the palette for valid entries Somehow, this code is more complex than I think it should be... M +16 -2libs/pigment/resources/KisSwatchGroup.cpp https://invent.kde.org/kde/krita/commit/d779201edad48879034ffd2121a1a1a0f0679bfd -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/ ||krita/commit/5be3887e747a16 ||3d862c237d77cfa1e4f2a4e7af Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #10 from Boudewijn Rempt --- Git commit 5be3887e747a163d862c237d77cfa1e4f2a4e7af by Boudewijn Rempt. Committed on 02/09/2019 at 12:58. Pushed by rempt into branch 'master'. Check the palette for valid entries Somehow, this code is more complex than I think it should be... M +16 -2libs/pigment/resources/KisSwatchGroup.cpp https://invent.kde.org/kde/krita/commit/5be3887e747a163d862c237d77cfa1e4f2a4e7af -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #9 from Boudewijn Rempt --- Ah, now I get it, sorry, I was a bit confused... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Assignee|griffinval...@gmail.com |b...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #8 from acc4commissi...@gmail.com --- (In reply to Boudewijn Rempt from comment #7) > I cannot reproduce this anymore. Can anyone else? Still reproducable in the lastest nightly. :/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Boudewijn Rempt --- I cannot reproduce this anymore. Can anyone else? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 wolthera changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |griffinval...@gmail.com --- Comment #6 from wolthera --- I'll assign this to myself for now, once I know more I'll either fix it, or just write a debug report. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 Raghavendra kamath changed: What|Removed |Added CC||ra...@raghukamath.com --- Comment #5 from Raghavendra kamath --- I have this crash with a palette created in newer version of Krita, The palette also has groups. Unfortunately trying to get a backtrace in gdb hangs my entire system -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #4 from acc4commissi...@gmail.com --- Created attachment 121847 --> https://bugs.kde.org/attachment.cgi?id=121847=edit Palette file Oh, ok. Seems like It was a part the Digital Atelier brush bundle by Ramon Miranda(https://gumroad.com/l/sFbEb). The palette was gone when the bundle was inactive. Sorry for the confusion. The palette file was also inside the bundle file. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #3 from wolthera --- Do you have the muses brush pack installed or something like that? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 --- Comment #2 from acc4commissi...@gmail.com --- Created attachment 121846 --> https://bugs.kde.org/attachment.cgi?id=121846=edit Screenshot. I'm not sure where it's stored. I didn't add it either, it's just included by default with the build. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 410387] Krita suddenly closes while using the palettize filter
https://bugs.kde.org/show_bug.cgi?id=410387 wolthera changed: What|Removed |Added Ever confirmed|0 |1 CC||griffinval...@gmail.com Status|REPORTED|CONFIRMED --- Comment #1 from wolthera --- Can you share that palette? I do get an asan backtrace with a totally different palette, but it'd be nice if we had the original palette. ==24394==AddressSanitizer: while reporting a bug found another one. Ignoring. ==24394==ERROR: AddressSanitizer: heap-use-after-free on address 0x60400202f610 at pc 0x7fffe6224354 bp 0x7fff7abd09c0 sp 0x7fff7abd09b0 READ of size 4 at 0x60400202f610 thread T24 (Thread (pooled)) ==24394==AddressSanitizer: while reporting a bug found another one. Ignoring. ==24394==AddressSanitizer: while reporting a bug found another one. Ignoring. #0 0x7fffe6224353 in std::__atomic_base::load(std::memory_order) const /usr/include/c++/7/bits/atomic_base.h:396 #1 0x7fffe6224353 in int QAtomicOps::load(std::atomic const&) /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227 #2 0x7fffe6221f3d in QBasicAtomicInteger::load() const /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103 #3 0x7fffe621f1eb in QtPrivate::RefCount::ref() /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:55 #4 0x7fffe6e3cab4 in QMap::QMap(QMap const&) /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:624 #5 0x7fffe6e3a3ed in QVector >::reallocData(int, int, QFlags) /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:581 #6 0x7fffe6e3b67f in QVector >::detach() /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:390 #7 0x7fffe6e394c6 in QVector >::data() /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:127 #8 0x7fffe6e375f2 in QVector >::operator[](int) /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:438 #9 0x7fffe6e34615 in KisSwatchGroup::checkEntry(int, int) const /home/wolthera/krita/src/libs/pigment/resources/KisSwatchGroup.cpp:83 #10 0x7fffe6e03ea0 in KoColorSet::getColorGlobal(unsigned int, unsigned int) const /home/wolthera/krita/src/libs/pigment/resources/KoColorSet.cpp:308 #11 0x7fffb9390e32 in KisFilterPalettize::processImpl(KisSharedPtr, QRect const&, KisPinnedSharedPtr, KoUpdater*) const /home/wolthera/krita/src/plugins/filters/palettize/palettize.cpp:201 #12 0x7fffedacfd8c in KisFilter::process(KisSharedPtr, KisSharedPtr, KisSharedPtr, QRect const&, KisPinnedSharedPtr, KoUpdater*) const /home/wolthera/krita/src/libs/image/filter/kis_filter.cc:88 #13 0x7fffedcf3b5c in KisUpdateOriginalVisitor::visit(KisAdjustmentLayer*) /home/wolthera/krita/src/libs/image/kis_async_merger.cpp:127 #14 0x7fffedbf30b4 in KisAdjustmentLayer::accept(KisNodeVisitor&) /home/wolthera/krita/src/libs/image/kis_adjustment_layer.cc:115 #15 0x7fffede584dd in KisProjectionLeaf::accept(KisNodeVisitor&) /home/wolthera/krita/src/libs/image/kis_projection_leaf.cpp:245 #16 0x7fffedce8623 in KisAsyncMerger::startMerge(KisBaseRectsWalker&, bool) /home/wolthera/krita/src/libs/image/kis_async_merger.cpp:265 #17 0x7fffee39ba9b in KisUpdateJobItem::runMergeJob() /home/wolthera/krita/build/libs/image/kritaimage_autogen/EWIEGA46WW/../../../../../src/libs/image/kis_update_job_item.h:118 #18 0x7fffee39b6b1 in KisUpdateJobItem::run() /home/wolthera/krita/build/libs/image/kritaimage_autogen/EWIEGA46WW/../../../../../src/libs/image/kis_update_job_item.h:86 #19 0x7fffeb31e3e1 (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0xac3e1) #20 0x7fffeb319c71 (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0xa7c71) #21 0x7fffea2bc6da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da) #22 0x7fffeaa0188e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12188e) 0x60400202f610 is located 0 bytes inside of 40-byte region [0x60400202f610,0x60400202f638) freed by thread T24 (Thread (pooled)) here: #0 0x76efb9d8 in operator delete(void*, unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe19d8) #1 0x7fffe6e3e274 in QMapData::destroy() /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:251 #2 0x7fffe6e3dfec in QMap::~QMap() /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:339 #3 0x7fffe6e3ca49 in QVector >::destruct(QMap*, QMap*) /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:351 #4 0x7fffe6e39227 in QVector >::freeData(QTypedArrayData >*) /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:542 #5 0x7fffe6e3690f in QVector >::~QVector() /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:73 #6 0x7fffe6e39337 in KisSwatchGroup::Private::~Private() /home/wolthera/krita/src/libs/pigment/resources/KisSwatchGroup.cpp:24 #7 0x7fffe6e39364 in QScopedPointerDeleter::cleanup(KisSwatchGroup::Private*) /usr/include/x86_64-linux-gnu/qt5/QtCore/qscopedpointer.h:60
