[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2020-05-04 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413601

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2020-05-04 Thread Kuntal Majumder
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #7 from Kuntal Majumder  ---
Yes, since I essentially removed the actions which triggered the asserts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2020-05-04 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413601

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Boudewijn Rempt  ---
I think that these crashes are gone now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2020-04-02 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #5 from Boudewijn Rempt  ---
Git commit 97fb0fc6d11f4a42c2c86cd5d40e92fdf8ddeb58 by Boudewijn Rempt, on
behalf of Kuntal Majumder.
Committed on 02/04/2020 at 13:09.
Pushed by rempt into branch 'krita/4.3'.

Disable double click in magnetic lasso for now
(cherry picked from commit dacfa0aa507570d38c256c4f0ac5e585617c937a)

M  +8-0plugins/tools/selectiontools/KisToolSelectMagnetic.cc
M  +1-1plugins/tools/selectiontools/KisToolSelectMagnetic.h

https://invent.kde.org/kde/krita/commit/97fb0fc6d11f4a42c2c86cd5d40e92fdf8ddeb58

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2020-03-26 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #4 from Boudewijn Rempt  ---
Git commit dacfa0aa507570d38c256c4f0ac5e585617c937a by Boudewijn Rempt, on
behalf of Kuntal Majumder.
Committed on 26/03/2020 at 13:07.
Pushed by kuntalmajumder into branch 'master'.

Disable double click in magnetic lasso for now

M  +8-0plugins/tools/selectiontools/KisToolSelectMagnetic.cc
M  +1-1plugins/tools/selectiontools/KisToolSelectMagnetic.h

https://invent.kde.org/kde/krita/commit/dacfa0aa507570d38c256c4f0ac5e585617c937a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2019-12-22 Thread Kuntal Majumder
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #3 from Kuntal Majumder  ---
Git commit 6007e8142070077e91b509d635c3cb0fc0e16a83 by Kuntal Majumder.
Committed on 22/12/2019 at 16:05.
Pushed by kuntalmajumder into branch 'magnetic-lasso-patch'.

Adds a signal compressor to distiguish single and double clicks

Qt triggers a single click even for a double click,
so hacked a signal compressor which expects a delay
between 2 clicks to determine whether the first click
was a single click or belonged to a double click

M  +36   -23   plugins/tools/selectiontools/KisToolSelectMagnetic.cc
M  +3-2plugins/tools/selectiontools/KisToolSelectMagnetic.h

https://invent.kde.org/kde/krita/commit/6007e8142070077e91b509d635c3cb0fc0e16a83

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2019-11-25 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413601

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 CC||b...@valdyas.org
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |hello...@disroot.org
   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2019-11-05 Thread Scott Petrovic
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #2 from Scott Petrovic  ---
Here is a separate crash that is happening with a back trace... 

Thread 1 "krita" received signal SIGSEGV, Segmentation fault.
QVector::operator= (other=..., this=0x6175dfe0)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:78
78  { QVector moved(std::move(other)); swap(moved); return *this; }
(gdb) bt
#0  0x7fffe4155981 in QVector::operator=(QVector&&)
(other=..., this=0x6175dfe0)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:78
#1  0x7fffe4155981 in KisToolSelectMagnetic::updateSelectedAnchor()
(this=0x574d3a60)
at
/home/scott/git/krita/src/plugins/tools/selectiontools/KisToolSelectMagnetic.cc:416
#2  0x7fffe41599fd in
KisToolSelectMagnetic::endPrimaryAction(KoPointerEvent*)
(this=0x574d3a60, event=0x7fffcd40)
at
/home/scott/git/krita/src/plugins/tools/selectiontools/KisToolSelectMagnetic.cc:321
#3  0x76d25f84 in
KisToolProxy::forwardToTool(KisToolProxy::ActionState, KisTool::ToolAction,
QEvent*, QPointF const&)
(this=, state=KisToolProxy::END, action=KisTool::Primary,
event=0x7fffd490, docPoint=...) at
/home/scott/git/krita/src/libs/ui/canvas/kis_tool_proxy.cpp:202
#4  0x76d260e0 in KisToolProxy::forwardEvent(KisToolProxy::ActionState,
KisTool::ToolAction, QEvent*, QEvent*)
(this=0x60b39fa0, state=state@entry=KisToolProxy::END,
action=action@entry=KisTool::Primary, event=event@entry=0x7fffd490,
originalEvent=originalEvent@entry=0x7fffd490)
at /home/scott/git/krita/src/libs/ui/canvas/kis_tool_proxy.cpp:132
#5  0x7703d60d in KisToolInvocationAction::end(QEvent*)
(this=0x5f0ee820, event=0x7fffd490) at
/usr/include/c++/9/bits/atomic_base.h:413
#6  0x770482a7 in
KisShortcutMatcher::tryEndRunningShortcut(Qt::MouseButton, QEvent*)
(this=this@entry=0x5f023620, button=,
event=event@entry=0x7fffd490)
at /home/scott/git/krita/src/libs/ui/input/kis_shortcut_matcher.cpp:679
#7  0x77049516 in KisShortcutMatcher::buttonReleased(Qt::MouseButton,
QEvent*)
(this=0x5f023620, button=,
event=event@entry=0x7fffd490)
at /home/scott/git/krita/src/libs/ui/input/kis_shortcut_matcher.cpp:296

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413601] Assert/crash with Magnetic Selection tool

2019-11-05 Thread Scott Petrovic
https://bugs.kde.org/show_bug.cgi?id=413601

--- Comment #1 from Scott Petrovic  ---
Here is another more detailed back trace. This might be a different crash than
the first one... 

Thread 1 "krita" received signal SIGSEGV, Segmentation fault.
__memmove_avx_unaligned_erms () at
../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:540
540 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file
or directory.
(gdb) bt
#0  0x7463af3d in __memmove_avx_unaligned_erms ()
at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:540
#1  0x7fffe4155c51 in memmove (__len=, __src=, __dest=)
at /usr/include/x86_64-linux-gnu/bits/string_fortified.h:40
#2  0x7fffe4155c51 in QVector
>::insert(QTypedArrayData >::iterator, int, QVector
const&) (t=..., n=1, before=..., this=0x574d61b0)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:755
#3  0x7fffe4155c51 in QVector >::insert(int,
QVector const&)
(t=..., i=, this=0x574d61b0)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:442
#4  0x7fffe4155c51 in
KisToolSelectMagnetic::beginPrimaryDoubleClickAction(KoPointerEvent*)
(this=0x574d6060, event=)
at
/home/scott/git/krita/src/plugins/tools/selectiontools/KisToolSelectMagnetic.cc:281
#5  0x76d2600e in
KisToolProxy::forwardToTool(KisToolProxy::ActionState, KisTool::ToolAction,
QEvent*, QPointF const&)
(this=, state=KisToolProxy::BEGIN, action=KisTool::Primary,
event=0x7fffd490, docPoint=...) at
/home/scott/git/krita/src/libs/ui/canvas/kis_tool_proxy.cpp:181
#6  0x76d260e0 in KisToolProxy::forwardEvent(KisToolProxy::ActionState,
KisTool::ToolAction, QEvent*, QEvent*)
(this=0x5a175df0, state=state@entry=KisToolProxy::BEGIN,
action=action@entry=KisTool::Primary, event=event@entry=0x7fffd490,
originalEvent=originalEvent@entry=0x7fffd490)
at /home/scott/git/krita/src/libs/ui/canvas/kis_tool_proxy.cpp:132
#7  0x7703cf60 in KisToolInvocationAction::begin(int, QEvent*)
(this=this@entry=0x5f0427c0, shortcut=,
event=event@entry=0x7fffd490)
at /usr/include/c++/9/bits/atomic_base.h:413
#8  0x77048c46 in
KisShortcutMatcher::tryRunReadyShortcut(Qt::MouseButton, QEvent*)

-- 
You are receiving this mail because:
You are watching all bug changes.