[krita] [Bug 416212] Problems when clicking an empty layer with liquify tool

2020-05-04 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=416212

--- Comment #4 from Boudewijn Rempt  ---
Backtrace:

Thread 1 (Thread 0x7f8133495800 (LWP 11394)):
[KCrash Handler]
#6  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#7  0x7f812dc4f801 in __GI_abort () at abort.c:79
#8  0x7f812e67959b in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7f81300e918a in kis_assert_common (assertion=,
file=, line=, throwException=,
isIgnorable=) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qarraydata.h:61
#10 0x7f8130a5f1f9 in KisImage::copyFromImageImpl (this=,
rhs=..., policy=) at /usr/include/c++/9/bits/atomic_base.h:413
#11 0x7f8130a5fdc3 in KisImage::KisImage (this=0x55f788635ad0, rhs=...,
undoStore=, exactCopy=) at
/home/boud/dev/4.3/libs/image/kis_image.cc:483
#12 0x7f8130a5fe86 in KisImage::clone (this=0x55f779c7b660,
exactCopy=exactCopy@entry=true) at
/home/boud/dev/4.3/libs/image/kis_image.cc:355
#13 0x7f8132148418 in KisDocument::copyFromDocumentImpl
(this=0x55f78421f0e0, rhs=..., policy=KisDocument::CONSTRUCT) at
/home/boud/dev/4.3/libs/ui/KisDocument.cpp:906
#14 0x7f8132148c5a in KisDocument::KisDocument (this=0x55f78421f0e0,
rhs=...) at /home/boud/dev/4.3/libs/ui/KisDocument.cpp:536
#15 0x7f8132148e58 in KisDocument::lockAndCloneForSaving
(this=0x7f810c006090) at /home/boud/dev/4.3/libs/ui/KisDocument.cpp:855
#16 0x7f8132149b1d in KisDocument::initiateSavingInBackground
(this=0x7f810c006090, actionName=..., receiverObject=0x7f810c006090,
receiverMethod=0x7f8132c1d8f8
"1slotCompleteSavingDocument(KritaUtils::ExportFileJob,
KisImportExportErrorCode ,QString)", job=..., exportConfiguration=...,
optionalClonedDocument=...) at /home/boud/dev/4.3/libs/ui/KisDocument.cpp:990
#17 0x7f8132149e24 in KisDocument::initiateSavingInBackground
(this=, actionName=..., receiverObject=,
receiverMethod=, job=..., exportConfiguration=...) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:60
#18 0x7f813214a032 in KisDocument::exportDocumentImpl (this=0x7f810c006090,
job=..., exportConfiguration=...) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:1051
#19 0x7f813214b34f in KisDocument::saveAs (this=this@entry=0x7f810c006090,
_url=..., mimeType=..., showWarnings=showWarnings@entry=true,
exportConfiguration=...) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:60
#20 0x7f8132171df3 in KisMainWindow::saveDocument (this=0x55f7803b7980,
document=0x7f810c006090, saveas=, isExporting=false) at
/home/boud/dev/4.3/libs/global/kis_shared_ptr.h:82
#21 0x7f8132172e33 in KisMainWindow::slotFileSaveAs (this=0x55f7803b7980)
at /usr/include/c++/9/bits/atomic_base.h:413
#22 0x7f8132179a37 in KisMainWindow::qt_static_metacall (_o=0x55f7803b7980,
_c=, _id=, _a=0x7ffd31fa7510) at
/home/boud/dev/b-4.3/libs/ui/kritaui_autogen/include/moc_KisMainWindow.cpp:380
#23 0x7f812e8c7dc9 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#24 0x7f812f7703a2 in QAction::triggered(bool) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#25 0x7f812f772a0c in QAction::activate(QAction::ActionEvent) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#26 0x7f812f8ed2ec in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#27 0x7f812f8f48db in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#28 0x7f812f8f6eda in QMenu::keyPressEvent(QKeyEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#29 0x7f812f7b8037 in QWidget::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#30 0x7f812f8f792b in QMenu::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#31 0x7f812f7768bc in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#32 0x7f812f77eae2 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#33 0x7f81321355a9 in KisApplication::notify (this=,
receiver=0x55f783d600d0, event=0x7ffd31fa7e80) at
/home/boud/dev/4.3/libs/ui/KisApplication.cpp:680
#34 0x7f812e88cdb8 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#35 0x7f812f7d4d05 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#36 0x7f812f7768bc in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#37 0x7f812f77dac0 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#38 0x7f81321355a9 in KisApplication::notify (this=,
receiver=0x55f7873dcb70, event=0x7ffd31fa7e80) at
/home/boud/dev/4.3/libs/ui/KisApplication.cpp:680
#39 0x7f812e88cdb8 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#40 0x7f812ee8573b in
QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent*)
() from 

[krita] [Bug 416212] Problems when clicking an empty layer with liquify tool

2020-01-14 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=416212

Boudewijn Rempt  changed:

   What|Removed |Added

   Severity|normal  |crash
 CC||b...@valdyas.org

--- Comment #3 from Boudewijn Rempt  ---
Yes, this is a crash bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416212] Problems when clicking an empty layer with liquify tool

2020-01-14 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=416212

Ahab Greybeard  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Ahab Greybeard  ---
Setting to CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416212] Problems when clicking an empty layer with liquify tool

2020-01-14 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=416212

Ahab Greybeard  changed:

   What|Removed |Added

 CC||ahab.greybe...@hotmail.co.u
   ||k

--- Comment #1 from Ahab Greybeard  ---
Created attachment 125121
  --> https://bugs.kde.org/attachment.cgi?id=125121=edit
good liquify result

Shouldn't this be marked as a Crash bug?

Using the 4.3.0 prealpha appimage (git 0a0738b) I get slightly different (but
still incorrect results) and a crash on saving. As follows:

Steps to reproduce [and Observed results]

1. Make two layers and draw something on one of them.
2. Make a rectangular selection around the drawing.
3. Select the empty layer, click it with the Liquify Transform tool.
   [Get a warning: Cannot transform empty layer.]
4. Select the layer with the drawing and use the Liquify transform tool.
   [On the first stroke, the selection outline is removed and there is no
effect on the drawing.]
   [On further strokes, a liquify action is performed on the painted pixels.]
5. Liquify/drag pixels from inside the selection to outside the selection.
   [This works with some interesting 'sector sweeping' effects but there is
quite a bit of lag.]
6. Press Return to confirm/apply the transform.
   [The projected screen image returns to the original drawing.]
   [After a wait of about three seconds, the following is observed: ...]
   [The selection outline returns and has it's outline dragged out in
accordance with the liquify actions.]
   [The Overview and the Layer thunbnail both show the liquified result.]
   [Turning layers on and off does not give a liquified result on-screen.]
   [If the drawing layer is turned off, the original drawing is still
on-screen.]
7. Try to look at the Help - system info window
   [It shows a Safe Assert due to Transform]
9. Close the System info window with its Ok button.
   [Crash]


13 Jan 2020 21:43:26 +: Created image "Unnamed", 3508 * 2480 pixels, 300
dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc).
Layers: 2
13 Jan 2020 21:43:45 +: SAFE ASSERT (krita): "m_savedTransformArgs" in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp,
line 400
13 Jan 2020 21:49:26 +: Autosaving:
/home/adminahab/krita-14594-document_0-autosave.kra
13 Jan 2020 21:49:27 +: ASSERT (krita): "!rhs.m_d->disableUIUpdateSignals"
in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/kis_image.cc,
line 461

Note the Autosaving action.

Running krita again, there was no offer to load the autosaved file because it
didn't exist.

Turning Autosave off and repeating the Steps, I got a crash at Step 6.

13 Jan 2020 21:57:01 +: Created image "Unnamed", 3508 * 2480 pixels, 300
dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc).
Layers: 2
13 Jan 2020 21:57:19 +: SAFE ASSERT (krita): "m_savedTransformArgs" in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp,
line 400
13 Jan 2020 21:57:50 +: ASSERT (krita): "row < 0x7FFF && col < 0x7FFF" in
file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/tiles3/kis_tile_hash_table2.h,
line 133

Repeating this process in a freshly started krita (with Autosave still turned
off), the observed results were repeated and at Step 7, the Safe Assert was
there:


14 Jan 2020 13:37:06 +: Created image "Unnamed", 3508 * 2480 pixels, 300
dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc).
Layers: 2
14 Jan 2020 13:38:09 +: SAFE ASSERT (krita): "m_savedTransformArgs" in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp,
line 400

Then Save the document and there was a crash with no file saved:

14 Jan 2020 13:48:49 +: Saving Document  as
/home/adminahab/CONFIG/dump/Desktop/tue-liquify-1.kra (mime:
application/x-krita). 3508 * 2480 pixels, 5 layers.  101 frames, 24 framerate.
Export configuration: No configuration
14 Jan 2020 13:48:49 +: ASSERT (krita): "!rhs.m_d->disableUIUpdateSignals"
in file
/home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/kis_image.cc,
line 461

KRITA DID NOT CLOSE CORRECTLY

Restarted krita and repeated the process with a variation:

At Step 3. Click the empty layer with the Free Transform Tool
At Step 4. Select the drawing layer and click with the Liquify Transform
Tool.
[The Liquify transform works on the drawing as before.]
At Step 5.
[As before.]
At Step 6.
[Everything works with no problems.]

The image can be saved with no crashing and is attached as
tue-liquify-4.kra

-- 
You are receiving this mail because:
You