[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 --- Comment #7 from Robert Moerland --- Thank you! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #6 from Dmitry Kazakov --- Hi, Unfa, Ahab and Robert! I have fixed the transparent artifacs issue that Ahab reported but I decided not to make the Filter Layers todo seamless wraparound. We had had a short discussion on IRC and we decided that it would be too complicated for both, developers and users (since we'll have to also define WA-mode for clone layers and transform masks). Basically, if you would like to apply a seamless gaussian blur, then just apply it via Filter menu to a single layer or a flattened projection. The filter application is guaranteed to be seamless, but the filter layers and masks are not :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/6e79707 |hics/krita/-/commit/ebd8a65 |c5df420bafa5e56bd7d047ba8e3 |b6a89b39768984a7821c8aceaac |14c1ec |ff881b --- Comment #5 from Dmitry Kazakov --- Git commit ebd8a65b6a89b39768984a7821c8aceaacff881b by Dmitry Kazakov. Committed on 13/12/2024 at 08:52. Pushed by dkazakov into branch 'krita/5.2'. Fix artifacts when painting under a gaussian blus layer in WA-mode Our filter layers and masks do not wrap-around their content. It is done by-design. Because if they do, 1) Switching WA mode will have to regenerate the image projection, i.e. it will have to behave like "isolated mode", which causes issues on saving. Right now WA-mode is purely view-based transformation that doesn't influence how the image is rendered. 2) If we do wrapping for WA-mode, we'll also have to define it in some way for transformation masks and clone layers with offset. And it opens a rabbit hole. I have no idea how clone layers should behave in WA-mode :) tldr; if you want to apply a gaussian blur filter in WA-mode, just apply that using "Filter" menu. Only "image modification actions" do actually support WA-mode. Layers know nothing about WA-mode. M +1-1libs/image/kis_convolution_painter.cc https://invent.kde.org/graphics/krita/-/commit/ebd8a65b6a89b39768984a7821c8aceaacff881b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/6e79707 ||c5df420bafa5e56bd7d047ba8e3 ||14c1ec Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #4 from Dmitry Kazakov --- Git commit 6e79707c5df420bafa5e56bd7d047ba8e314c1ec by Dmitry Kazakov. Committed on 13/12/2024 at 08:51. Pushed by dkazakov into branch 'master'. Fix artifacts when painting under a gaussian blus layer in WA-mode Our filter layers and masks do not wrap-around their content. It is done by-design. Because if they do, 1) Switching WA mode will have to regenerate the image projection, i.e. it will have to behave like "isolated mode", which causes issues on saving. Right now WA-mode is purely view-based transformation that doesn't influence how the image is rendered. 2) If we do wrapping for WA-mode, we'll also have to define it in some way for transformation masks and clone layers with offset. And it opens a rabbit hole. I have no idea how clone layers should behave in WA-mode :) tldr; if you want to apply a gaussian blur filter in WA-mode, just apply that using "Filter" menu. Only "image modification actions" do actually support WA-mode. Layers know nothing about WA-mode. M +1-1libs/image/kis_convolution_painter.cc https://invent.kde.org/graphics/krita/-/commit/6e79707c5df420bafa5e56bd7d047ba8e314c1ec -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Robert Moerland changed: What|Removed |Added Assignee|rmoerlan...@gmail.com |krita-bugs-n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Robert Moerland changed: What|Removed |Added Version|4.4.2 |nightly build (please ||specify the git hash!) --- Comment #3 from Robert Moerland --- Reconfirmed with 5.2.6 and 5.30-alpha 3138bbd1 on Windows. Moreover, also induces a SAFE ASSERT, also without Filter Layer: SAFE ASSERT (krita): "m_d->grid.contains(rc)" in file C:/builds/graphics/krita/libs/image/KisOverlayPaintDeviceWrapper.cpp, line 247 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Robert Moerland changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |rmoerlan...@gmail.com CC||rmoerlan...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Ahab Greybeard changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 --- Comment #2 from Ahab Greybeard --- Created attachment 137223 --> https://bugs.kde.org/attachment.cgi?id=137223&action=edit border discontinuities -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434938] Blur Filter Layers break on seams in Wrap Around Mode
https://bugs.kde.org/show_bug.cgi?id=434938 Ahab Greybeard changed: What|Removed |Added CC||ahab.greybe...@hotmail.co.u ||k --- Comment #1 from Ahab Greybeard --- Created attachment 137222 --> https://bugs.kde.org/attachment.cgi?id=137222&action=edit gaps at borders I can confirm this for the Mar 30 5.0.0-prealpha (git 783e86c) appimage. It happens for a filter layer and a filter mask. When painting, there are obvious gaps at the border as show in the attachment 'gaps.png' If Image -> Trim to Image Size is done or if the filter visibility is turned off then on again, the gaps become discontinuities as shown in the attachment 'discontinuities.png'. The same effect is seen in the 4.3.0 and 4.4.0 appimages. -- You are receiving this mail because: You are watching all bug changes.
