[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #1 from Dmitry Kazakov --- Hi, Emmanual! Could you please share the file that fails? The crash happens on the layer that has a "Stroke" layer style with the pattern applied to it. You can modify the file to keep only this specific layer, if the file is private. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 amyspark changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Component|* Unknown |File formats Status|REPORTED|NEEDSINFO CC||a...@amyspark.me --- Comment #2 from amyspark --- Hi! Please sends us the file (or just the layer, as Dmitry said) and I'll take a look into it. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #3 from Dmitry Kazakov --- Could you also install DebugView (https://learn.microsoft.com/en-us/sysinternals/downloads/debugview) and see if Krita prints this warning in it when loading that file? "WARNING: failed to parse KisPatternData XML section!" If yes, then the problem is with the pattern compression format -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #4 from emmanuelpoirie...@gmail.com --- Hi All, did you get the file? It was in the archive. I add it here for convenience. Regards E. On 1/23/2023 4:07 PM, Dmitry Kazakov wrote: > https://bugs.kde.org/show_bug.cgi?id=464700 > > --- Comment #3 from Dmitry Kazakov --- > Could you also install DebugView > (https://learn.microsoft.com/en-us/sysinternals/downloads/debugview) and see > if > Krita prints this warning in it when loading that file? > > "WARNING: failed to parse KisPatternData XML section!" > > If yes, then the problem is with the pattern compression format > -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #5 from emmanuelpoirie...@gmail.com --- Hi again, the text entered is using the font I attached so you can test if it´s coming from the font. Regards E. On 1/26/2023 6:39 PM, emmanuel poirier wrote: > Hi All, > > did you get the file? It was in the archive. > > I add it here for convenience. > > Regards > > E. > > > On 1/23/2023 4:07 PM, Dmitry Kazakov wrote: >> https://bugs.kde.org/show_bug.cgi?id=464700 >> >> --- Comment #3 from Dmitry Kazakov --- >> Could you also install DebugView >> (https://learn.microsoft.com/en-us/sysinternals/downloads/debugview) >> and see if >> Krita prints this warning in it when loading that file? >> >> "WARNING: failed to parse KisPatternData XML section!" >> >> If yes, then the problem is with the pattern compression format >> > -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #6 from emmanuelpoirie...@gmail.com --- On 1/23/2023 4:07 PM, Dmitry Kazakov wrote: > https://bugs.kde.org/show_bug.cgi?id=464700 > > --- Comment #3 from Dmitry Kazakov --- > Could you also install DebugView > (https://learn.microsoft.com/en-us/sysinternals/downloads/debugview) and see > if > Krita prints this warning in it when loading that file? > > "WARNING: failed to parse KisPatternData XML section!" > > If yes, then the problem is with the pattern compression format > -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #7 from emmanuelpoirie...@gmail.com --- Hi Dmitry, krita shows nothing with debugview launched. I attached the log generated. Crash occurred around 10:28 PM on 26/1/22. I found another file which produces a crash but as I can't say if it's the same cause, I'll send it into another email with a note to differentiate. Regards E. On 1/23/2023 4:07 PM, Dmitry Kazakov wrote: > https://bugs.kde.org/show_bug.cgi?id=464700 > > --- Comment #3 from Dmitry Kazakov --- > Could you also install DebugView > (https://learn.microsoft.com/en-us/sysinternals/downloads/debugview) and see > if > Krita prints this warning in it when loading that file? > > "WARNING: failed to parse KisPatternData XML section!" > > If yes, then the problem is with the pattern compression format > -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 amyspark changed: What|Removed |Added Status|NEEDSINFO |ASSIGNED Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 --- Comment #8 from amyspark --- File made it in one piece from the looks of Bugzilla. Let's see what's inside... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #9 from amyspark --- Can confirm the crash happens here. After adding an early return to work around it, I get the following warnings: krita.general: Unhandled: "/null/FrFX/overprint" class QHash > false krita.general: WARNING: ASL style contains non-existent pattern reference! Searching for uuid: "c7acb22a-47a6-11de-919a-bf574370eaaf" (name: "Default/orangeslices" ) krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet krita.general: Unhandled: "/null/DrSh/Cntn" class QHash > false SAFE ASSERT (krita): "!localResources.contains(KoResourceSP())" in file E:\krita-win\src\libs\resources\KisLocalStrokeResources.cpp, line 79 The "Unhandled" warnings refer to your use of drop shadows in the layer, we don't support those yet. But moving past that, this looks like the Photoshop file is incomplete. The layer references a missing pattern, which causes Krita to insert a null pattern into the list, then remove it, and finally access it outright. Digging further into this. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 amyspark changed: What|Removed |Added Depends on||441605 --- Comment #10 from amyspark --- So upon further checking, the "invalid" placeholder pattern we inject for these cases triggers the counterpart of bug 441605: these patterns were never pushed into the global resource server on layer style read completion. Pushing a hotfix in a few moments. Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=441605 [Bug 441605] Safe assert on reading a file with a layer style -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 amyspark changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/973acffa8 ||a24c640e3a3c95007f99dfe4b4f ||5f48 --- Comment #11 from amyspark --- Git commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48 by L. E. Segovia. Committed on 28/01/2023 at 01:29. Pushed by lsegovia into branch 'master'. KisAslLayerStyleSerializer: fix layer-local patterns This is the counterpart of bug 441605, we only found this one out because in 464700 Wolthera injects a placeholder pattern, which in turn was never put into global storage. For the sake of completionism, I've added several safe asserts in the path that the nullptr makes, so that we get breakpointable warnings for missing resources in the future. Related: bug 441605 CCMAIL:dimul...@gmail.com CCMAIL:tamtamy.tym...@gmail.com M +15 -5libs/image/kis_asl_layer_style_serializer.cpp M +2-0libs/image/layerstyles/kis_ls_utils.cpp M +5-0libs/resources/KisLocalStrokeResources.cpp M +6-0libs/resources/KisRequiredResourcesOperators.cpp M +1-0libs/resources/KoResourceLoadResult.cpp M +8-0plugins/impex/psd/psd_loader.cpp https://invent.kde.org/graphics/krita/commit/973acffa8a24c640e3a3c95007f99dfe4b4f5f48 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 amyspark changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/973acffa8 |hics/krita/commit/8e83efca1 |a24c640e3a3c95007f99dfe4b4f |25a263dc993cf92e89c290f9339 |5f48|efe3 --- Comment #12 from amyspark --- Git commit 8e83efca125a263dc993cf92e89c290f9339efe3 by L. E. Segovia. Committed on 28/01/2023 at 01:31. Pushed by lsegovia into branch 'krita/5.1'. KisAslLayerStyleSerializer: fix layer-local patterns This is the counterpart of bug 441605, we only found this one out because in 464700 Wolthera injects a placeholder pattern, which in turn was never put into global storage. For the sake of completionism, I've added several safe asserts in the path that the nullptr makes, so that we get breakpointable warnings for missing resources in the future. Related: bug 441605 CCMAIL:dimul...@gmail.com CCMAIL:tamtamy.tym...@gmail.com (cherry picked from commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48) M +15 -5libs/image/kis_asl_layer_style_serializer.cpp M +2-0libs/image/layerstyles/kis_ls_utils.cpp M +5-0libs/resources/KisLocalStrokeResources.cpp M +6-0libs/resources/KisRequiredResourcesOperators.cpp M +1-0libs/resources/KoResourceLoadResult.cpp M +8-0plugins/impex/psd/psd_loader.cpp https://invent.kde.org/graphics/krita/commit/8e83efca125a263dc993cf92e89c290f9339efe3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #13 from amyspark --- The file should load now. For the missing pattern, it would be great if you could report it to the authors of Photopea; we cannot supply the patterns that come by default with Photoshop. Let us know if you find any more issues, and thanks for reporting this crash! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 Ivan Kuckir changed: What|Removed |Added CC||ivan.kuc...@gmail.com --- Comment #14 from Ivan Kuckir --- Hi guys, I am a creator of Photopea and I have fixed the issue with producing PSD files without a default pattern. This issue says that you have fixed it, however, it is not clear to me how can I test it. I have downloaded Krita 5.1.5, but the PSD file attached here still makes Krita crash. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.
https://bugs.kde.org/show_bug.cgi?id=464700 --- Comment #15 from amyspark --- Hi Ivan! We have Krita Plus for that. Please check out https://krita.org/en/download/krita-desktop/ and select your system from the list in "Nightly Builds". -- You are receiving this mail because: You are watching all bug changes.
