[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #19 from [email protected] --- Btw, have these changes been merged in Krita Plus? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #18 from [email protected] --- (In reply to Dmitry Kazakov from comment #14) > Hi, sbstratos79! > > Thank you very much for all the info (and the test file) you provided. It > was a very difficult to track bug, but your info really helped a lot! :) Glad to help! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Dmitry Kazakov changed: What|Removed |Added CC||[email protected] --- Comment #17 from Dmitry Kazakov --- *** Bug 472637 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Dmitry Kazakov changed: What|Removed |Added CC||[email protected] --- Comment #16 from Dmitry Kazakov --- *** Bug 464610 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Dmitry Kazakov changed: What|Removed |Added CC||[email protected] --- Comment #15 from Dmitry Kazakov --- *** Bug 468545 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #14 from Dmitry Kazakov --- Hi, sbstratos79! Thank you very much for all the info (and the test file) you provided. It was a very difficult to track bug, but your info really helped a lot! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #13 from Dmitry Kazakov --- Git commit 51eaef48b9bec42bdd909a4df4cd66f981e11fc0 by Dmitry Kazakov. Committed on 05/07/2023 at 10:46. Pushed by dkazakov into branch 'master'. Fix multithreading issue in KisUpdaterContext::getJobsSnapshot The crash happens under ASAN when using the Transform Tool. It may also happen in any other tool that uses image->blockUpdates(), that is Move Tool and Color Smudge in Overlay mode. M +29 -4libs/image/kis_updater_context.cpp https://invent.kde.org/graphics/krita/-/commit/51eaef48b9bec42bdd909a4df4cd66f981e11fc0 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/e39a0cf ||6dfbd4a59e3a028b78d91fc1228 ||3e2064 Status|ASSIGNED|RESOLVED --- Comment #12 from Dmitry Kazakov --- Git commit e39a0cf6dfbd4a59e3a028b78d91fc12283e2064 by Dmitry Kazakov. Committed on 05/07/2023 at 10:46. Pushed by dkazakov into branch 'master'. Make sure lod generation happens under updates locked Updates can come asyncronously via KisNode::handleKeyframeChannelUpdate, when a frame is automatically added via the auto-keyframing feature. To handle this case we should block execution of all the updates for this period of time. M +44 -0libs/image/KisRunnableStrokeJobUtils.h M +9-2libs/image/kis_sync_lod_cache_stroke_strategy.cpp M +3-1libs/image/kis_sync_lod_cache_stroke_strategy.h https://invent.kde.org/graphics/krita/-/commit/e39a0cf6dfbd4a59e3a028b78d91fc12283e2064 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #11 from Dmitry Kazakov --- Git commit c0c6abf2aefa9f90ba0c8cdd10d1632e6d9472a2 by Dmitry Kazakov. Committed on 05/07/2023 at 10:46. Pushed by dkazakov into branch 'master'. Don't auto-copy keyframe when source and destination frames are the same Copying causes an update signal to be emitted, which triggers invalid threaded access in some circumstances. M +5-2 plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp M +7-2 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +4-2 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/-/commit/c0c6abf2aefa9f90ba0c8cdd10d1632e6d9472a2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #10 from Dmitry Kazakov --- I have managed to reproduce the issue with the test image, though it happens only on Linux for some reason... SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 ASSERT (krita): "m_buffer[currentIndex].loadAcquire() >= 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 44 SAFE ASSERT (krita): "oldValue > 0" in file /home/appimage/persistent/krita/libs/image/tiles3/KisTiledExtentManager.cpp, line 94 Aborted (core dumped) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #9 from Dmitry Kazakov --- Git commit 821fedf457686f39de9fdd6fced21f14167dc63f by Dmitry Kazakov. Committed on 22/06/2023 at 11:06. Pushed by dkazakov into branch 'master'. Fix transform tool to work on animated images We shouldn't try to continue transformation from the previous undo command if the actual anamation time has changed since then M +26 -10 plugins/tools/tool_transform2/kis_transform_utils.cpp M +4-3plugins/tools/tool_transform2/kis_transform_utils.h M +5-0 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +4-0 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp M +1-0 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h https://invent.kde.org/graphics/krita/-/commit/821fedf457686f39de9fdd6fced21f14167dc63f -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Halla Rempt changed: What|Removed |Added Ever confirmed|0 |1 Assignee|[email protected] |[email protected] Status|REPORTED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #8 from Halla Rempt --- I was wrong with my initial assumption -- it's not gpu related, the backtrace just was confusing. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #7 from [email protected] --- (In reply to sbstratos79 from comment #6) > My system info: > https://pixeldrain.com/u/T8d5HwAc System info with integrated Intel GPU: https://pixeldrain.com/u/aSfZuug8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #6 from [email protected] --- My system info: https://pixeldrain.com/u/T8d5HwAc -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #5 from [email protected] --- (In reply to Halla Rempt from comment #1) > Hm, the crash happens in the nvidia opengl driver: > > /usr/lib/libnvidia-glcore.so.530.41.03 > > which likely means that it's not something we can fix ourselves, but the > gpu/driver simply cannot handle what you're asking of it. This time I ran Krita with the integrated Intel GPU. Krita still crashed. Here's the backtrace. https://pixeldrain.com/u/PPHRXYJQ And as I mentioned in my original post, I can't reproduce this crash in v5.1.4. Something has changed in 5.1.5 that is causing the crash. I think it's worth looking into. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #4 from Ahab Greybeard --- Here is the system information for my PC: Krita Version: 5.1.5 Hidpi: false Qt Version (compiled): 5.12.12 Version (loaded): 5.12.12 OS Information Build ABI: x86_64-little_endian-lp64 Build CPU: x86_64 CPU: x86_64 Kernel Type: linux Kernel Version: 4.19.0-23-amd64 Pretty Productname: Debian GNU/Linux 10 (buster) Product Type: debian Product Version: 10 Desktop: MATE Locale Languages: en_GB, en C locale: en_GB.UTF-8 QLocale current: en-GB QLocale system: en-GB QTextCodec for locale: UTF-8 OpenGL Info Vendor: "NVIDIA Corporation" Renderer: "NVIDIA GeForce GTX 750 Ti/PCIe/SSE2" Version: "4.6.0 NVIDIA 470.141.03" Shading language: "4.60 NVIDIA" Requested format: QSurfaceFormat(version 3.0, options QFlags(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile QSurfaceFormat::CompatibilityProfile) Current format: QSurfaceFormat(version 4.6, options QFlags(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile QSurfaceFormat::CompatibilityProfile) Version: 4.6 Supports deprecated functions true is OpenGL ES: false supportsBufferMapping: true supportsBufferInvalidation: true forceDisableTextureBuffers: false Extensions: "GL_KHR_no_error" "GL_KHR_robust_buffer_access_behavior" "GL_KHR_parallel_shader_compile" "GL_SGIS_generate_mipmap" "GL_ARB_vertex_type_2_10_10_10_rev" "GL_ARB_occlusion_query2" "GL_EXT_bindable_uniform" "GL_EXT_stencil_two_side" "GL_ARB_texture_env_add" "GL_EXTX_framebuffer_mixed_formats" "GL_NV_register_combiners" "GL_NV_texture_env_combine4" "GL_ARB_internalformat_query" "GL_NV_command_list" "GL_NV_gpu_shader5" "GL_ARB_compute_shader" "GL_ARB_texture_view" "GL_EXT_shadow_funcs" "GL_ARB_uniform_buffer_object" "GL_ARB_gpu_shader_int64" "GL_AMD_multi_draw_indirect" "GL_EXT_point_parameters" "GL_NV_gpu_multicast" "GL_EXT_texture_integer" "GL_ARB_multisample" "GL_ARB_shader_atomic_counter_ops" "GL_EXT_texture_lod" "GL_ARB_copy_buffer" "GL_KHR_robustness" "GL_NV_vertex_attrib_integer_64bit" "GL_NV_alpha_to_coverage_dither_control" "GL_EXT_import_sync_object" "GL_EXT_texture_filter_anisotropic" "GL_NV_vertex_program2" "GL_NV_vertex_program3" "GL_ARB_window_pos" "GL_ARB_copy_image" "GL_ARB_seamless_cube_map" "GL_EXT_texture_env_dot3" "GL_ARB_vertex_attrib_64bit" "GL_ARB_gpu_shader_fp64" "GL_EXT_direct_state_access" "GL_ARB_framebuffer_object" "GL_KHR_context_flush_control" "GL_EXT_texture3D" "GL_EXT_blend_subtract" "GL_ARB_shader_group_vote" "GL_EXT_framebuffer_multisample_blit_scaled" "GL_ARB_tessellation_shader" "GL_NVX_nvenc_interop" "GL_EXT_texture_swizzle" "GL_EXT_blend_minmax" "GL_EXT_compiled_vertex_array" "GL_NV_shader_storage_buffer_object" "GL_ARB_texture_compression_bptc" "GL_NV_fragment_program" "GL_EXT_texture_env_add" "GL_ARB_draw_elements_base_vertex" "GL_EXT_texture_shared_exponent" "GL_ARB_get_texture_sub_image" "GL_IBM_rasterpos_clip" "GL_EXT_polygon_offset_clamp" "GL_NV_compute_program5" "GL_EXT_Cg_shader" "GL_ARB_sync" "GL_ARB_vertex_shader" "GL_ARB_texture_stencil8" "GL_ARB_draw_buffers" "GL_NV_copy_depth_to_color" "GL_NV_vertex_program2_option" "GL_NV_ES1_1_compatibility" "GL_ARB_shading_language_420pack" "GL_EXT_texture_compression_dxt1" "GL_NV_texture_multisample" "GL_ARB_shading_language_include" "GL_OVR_multiview2" "GL_EXT_framebuffer_multisample" "GL_ARB_shader_storage_buffer_object" "GL_NV_shader_atomic_counters" "GL_ARB_shader_atomic_counters" "GL_ARB_query_buffer_object" "GL_ARB_clear_buffer_object" "GL_ARB_texture_compression" "GL_ARB_vertex_array_object" "GL_NV_draw_vulkan_image" "GL_ARB_texture_barrier" "GL_ARB_pipeline_statistics_query" "GL_EXT_multiview_timer_query" "GL_NV_multisample_filter_hint" "GL_EXT_packed_float" "GL_KHR_blend_equation_advanced" "GL_ARB_internalformat_query2" "GL_EXT_texture_cube_map" "GL_EXT_texture_buffer_object" "GL_EXT_window_rectangles" "GL_ARB_compatibility" "GL_ARB_multitexture"
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Ahab Greybeard changed: What|Removed |Added CC||[email protected] ||k --- Comment #3 from Ahab Greybeard --- I don't see the behaviour reported with the animation .kra file provided (jump.kra) with 5.1.4 or 5.1.5 or the 5.2.0 prealpha (96efda7010) appimages. In the linked forum topic, I noted that the canvas turned black when a large canvas animation was played with the 5.1.5 appimage. However, this was with an isolated home environment 5.1.5 appimage and that does not happen in the standard 'common' environment with the 5.1.5 appimage or with 5.1.4 or the 5.2.0 prealpha. I will investigate that further as a separate issue. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 --- Comment #2 from Halla Rempt --- I cannot reproduce with this file: but I'm on a PC with an intel gpu. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 Halla Rempt changed: What|Removed |Added CC||[email protected] --- Comment #1 from Halla Rempt --- Hm, the crash happens in the nvidia opengl driver: /usr/lib/libnvidia-glcore.so.530.41.03 which likely means that it's not something we can fix ourselves, but the gpu/driver simply cannot handle what you're asking of it. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 469226] Transformation on large canvas animation frames causes crash
https://bugs.kde.org/show_bug.cgi?id=469226 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
