[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 wolthera changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/e66763c |hics/krita/-/commit/054fbd2 |492adfb6c8c163ae90e69fb4d7b |0d57a093ec4baabc659eb4b |5a7277 |669a29 --- Comment #6 from wolthera --- Git commit 054fbd20d57a093ec4baabc659eb4b669a29 by Wolthera van Hövell tot Westerflier. Committed on 14/08/2023 at 16:36. Pushed by woltherav into branch 'krita/5.2'. Make transformationResolution happen earlier and be a bit better aligned to the SVG 2 spec. A bit contradictory, becuase the SVG spec wants it to happen later, but we should have it this early to eventually apply shaping breaks. Collapsing is now handled by the resolveTransforms function. This also handles adressability and 'middle' glyphs a little better, which means we have less problems with ligatures. Related: bug 471374 M +1-1libs/flake/text/KoSvgTextShape_p.h M +106 -74 libs/flake/text/KoSvgTextShape_p_layout.cpp https://invent.kde.org/graphics/krita/-/commit/054fbd20d57a093ec4baabc659eb4b669a29 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 wolthera changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/e66763c ||492adfb6c8c163ae90e69fb4d7b ||5a7277 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from wolthera --- Git commit e66763c492adfb6c8c163ae90e69fb4d7b5a7277 by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier. Committed on 14/08/2023 at 16:34. Pushed by woltherav into branch 'master'. Make transformationResolution happen earlier and be a bit better aligned to the SVG 2 spec. A bit contradictory, becuase the SVG spec wants it to happen later, but we should have it this early to eventually apply shaping breaks. Collapsing is now handled by the resolveTransforms function. This also handles adressability and 'middle' glyphs a little better, which means we have less problems with ligatures. Related: bug 471374 M +1-1libs/flake/text/KoSvgTextShape_p.h M +106 -74 libs/flake/text/KoSvgTextShape_p_layout.cpp https://invent.kde.org/graphics/krita/-/commit/e66763c492adfb6c8c163ae90e69fb4d7b5a7277 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 --- Comment #4 from wolthera --- Created attachment 160866 --> https://bugs.kde.org/attachment.cgi?id=160866&action=edit Fixes the bug, but unsure how appropriate This patch fixes the bug, and consists of two parts: part 1 is to collapse bidi controls, as per Part 2 of the text-layout algorithm: "discarded during layout due to being a collapsed white space character, a soft hyphen character, or a bidi control character; or", however, if I do this when text-in-shape is active it break text-in-shape mixed-bidi. I don't yet understand why which is why I don't like to make a proper mr yet. part 2 is that the line-breaking algorithm never finalized for this text because it ends with a control character. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 --- Comment #3 from wolthera --- Ok, I figured out the bug: somehow the bidi-marks are set as the anchor start. Lemme think about how to tackle this... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 wolthera changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from wolthera --- hum, everything starts working when I set "direction:rtl" on the parent, and both firefox, chromium and inkscape are able to sus this out without that property, so I'm wondering what the exact logic is here... I can't seem to find anything in css writing modes: https://www.w3.org/TR/css-writing-modes-3/#direction -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 Alvin Wong changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 472382] RTL text aligns differently from 5.1
https://bugs.kde.org/show_bug.cgi?id=472382 --- Comment #1 from Alvin Wong --- Created attachment 160378 --> https://bugs.kde.org/attachment.cgi?id=160378&action=edit Screenshots -- You are receiving this mail because: You are watching all bug changes.
