[krita] [Bug 500885] Anim: Can't scrub animation back to starting frame when re-selecting it after pausing.

2025-09-07 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=500885

Emmet O'Neill  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/c65f656 |hics/krita/-/commit/0316f63
   |e1287620d7f9466a4a4f0e3ab85 |a970191a421d5c34bdedd9774d6
   |03808f  |74193b

--- Comment #8 from Emmet O'Neill  ---
Git commit 0316f63a970191a421d5c34bdedd9774d674193b by Emmet O'Neill.
Committed on 04/09/2025 at 22:59.
Pushed by emmetoneill into branch 'master'.

UI/Animation/TimelineDocker: Can now re-select previous selected frame after
pausing.

The default behavior of QAbstractItemModel was causing an edge case
where users couldn't re-select the starting frame of their animation after
pausing
because it was technically already paused. Now, we've made it so that pausing
the animation playback will move the selection to the frame that the
animation was paused on, solving this issue.

M  +6-3libs/ui/KisPlaybackEngine.cpp
M  +1-0libs/ui/KisPlaybackEngineQT.cpp
M  +26   -2plugins/dockers/animation/KisAnimTimelineDocker.cpp
M  +1-0plugins/dockers/animation/KisAnimTimelineDocker.h
M  +0-2plugins/dockers/animation/KisAnimTimelineFramesView.cpp

https://invent.kde.org/graphics/krita/-/commit/0316f63a970191a421d5c34bdedd9774d674193b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 500885] Anim: Can't scrub animation back to starting frame when re-selecting it after pausing.

2025-09-04 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=500885

--- Comment #9 from Emmet O'Neill  ---
Git commit ef74e03a4058953926971d2177f3164e3b51770f by Emmet O'Neill.
Committed on 04/09/2025 at 23:46.
Pushed by emmetoneill into branch 'master'.

Animation/Audio: Fixed playback when audio is attached.

The bugfix associated with commit 0316f63a970191a421d5c34bdedd9774d674193b
inadvertently broke animation playback after audio was attached due to
a 2x signal/slot connection causing the play/pause button to activate
twice upon switching to the PlaybackEngineMLT.

Switching the connections between the transport controls and playback engine
to use Qt::UniqueConnection fixes this problem.

M  +8-8plugins/dockers/animation/KisAnimTimelineDocker.cpp

https://invent.kde.org/graphics/krita/-/commit/ef74e03a4058953926971d2177f3164e3b51770f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 500885] Anim: Can't scrub animation back to starting frame when re-selecting it after pausing.

2025-04-01 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=500885

Emmet O'Neill  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/c65f656
   ||e1287620d7f9466a4a4f0e3ab85
   ||03808f
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Emmet O'Neill  ---
Git commit c65f656e1287620d7f9466a4a4f0e3ab8503808f by Emmet O'Neill.
Committed on 01/04/2025 at 21:19.
Pushed by emmetoneill into branch 'master'.

UI/Animation/TimelineDocker: Can now re-select previous selected frame after
pausing.

The default behavior of QAbstractItemModel was causing an edge case
where users couldn't re-select the starting frame of their animation after
pausing
because it was technically already paused. Now, we've made it so that pausing
the animation playback will move the selection to the frame that the
animation was paused on, solving this issue.

M  +6-3libs/ui/KisPlaybackEngine.cpp
M  +1-0libs/ui/KisPlaybackEngineQT.cpp
M  +26   -2plugins/dockers/animation/KisAnimTimelineDocker.cpp
M  +1-0plugins/dockers/animation/KisAnimTimelineDocker.h
M  +0-2plugins/dockers/animation/KisAnimTimelineFramesView.cpp

https://invent.kde.org/graphics/krita/-/commit/c65f656e1287620d7f9466a4a4f0e3ab8503808f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 500885] Anim: Can't scrub animation back to starting frame when re-selecting it after pausing.

2025-03-11 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=500885

Emmet O'Neill  changed:

   What|Removed |Added

Summary|Exceeding cached frame size |Anim: Can't scrub animation
   |limit freezes canvas|back to starting frame when
   |display after playing   |re-selecting it after
   |animation.  |pausing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 500885] Anim: Can't scrub animation back to starting frame when re-selecting it after pausing.

2025-03-11 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=500885

Emmet O'Neill  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are watching all bug changes.