[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2022-01-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431315

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.25

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2022-01-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431315

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||c65938f36c715771bd8deebb22d
   ||de811a6e47bd7
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Nate Graham  ---
Git commit c65938f36c715771bd8deebb22dde811a6e47bd7 by Nate Graham, on behalf
of Alexander Lohnau.
Committed on 31/01/2022 at 18:01.
Pushed by ngraham into branch 'master'.

sessionrunner: Change text from "New Session" to "Switch User"

This is how we call it since ~2016.

Because of the string changes, it can not get cherry-picked to stable.

M  +1-1runners/sessions/sessionrunner.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/c65938f36c715771bd8deebb22dde811a6e47bd7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2022-01-30 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=431315

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1423

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2021-01-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431315

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Nate Graham  ---
Seems like the intention was to match SDDM's prior behavior of creating new
sessions by default instead of switching to a new one. However that default
setting has since been changed, so these are now out of sync. And I think SDDM
handles this itself right now, so the manual workaround is no longer needed.

(That's as I understand it at least).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2021-01-24 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=431315

Alexander Lohnau  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2021-01-24 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=431315

--- Comment #4 from Alexander Lohnau  ---
bool switchUser = listAll || term.compare(i18n("switch user"),
Qt::CaseInsensitive) == 0 || term.compare(i18n("new session"),
Qt::CaseInsensitive) == 0;

if (switchUser &&
KAuthorized::authorizeAction(QStringLiteral("start_new_session")) &&
dm.isSwitchable() && dm.numReserve() >= 0) {
Plasma::QueryMatch match(this);
match.setType(Plasma::QueryMatch::ExactMatch);
match.setIconName(QStringLiteral("system-switch-user"));
match.setText(i18n("New Session"));
matches << match;
}


This seems intentional and has been the case since the initial import in 2014,
@d_ed is there a rationale behind this? Like that switching users would in this
case create a new session?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 431315] Searching for "Switch user" finds an item called "New Session"

2021-01-24 Thread Mikel Johnson
https://bugs.kde.org/show_bug.cgi?id=431315

Mikel Johnson  changed:

   What|Removed |Added

Version|master  |5.20.90
   Assignee|[email protected]|[email protected]
Product|plasmashell |krunner
  Component|Application Launcher|general
   |(Kickoff)   |
   Target Milestone|1.0 |---

--- Comment #3 from Mikel Johnson  ---
actually this is a general krunner problem

-- 
You are receiving this mail because:
You are watching all bug changes.