[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Arjen Hiemstra]

https://bugs.kde.org/show_bug.cgi?id=394467

Arjen Hiemstra  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/lib |https://invent.kde.org/plas
   |ksysguard/7a580e83e1b2d21cd |ma/libksysguard/commit/bc59
   |5deacb2cbba86130e1de669 |d3f6532aaf34d738444a566ab49
   ||1dd4b5fbc
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Arjen Hiemstra  ---
Git commit bc59d3f6532aaf34d738444a566ab491dd4b5fbc by Arjen Hiemstra, on
behalf of Adriaan de Groot.
Committed on 01/07/2020 at 13:16.
Pushed by ahiemstra into branch 'master'.

Align headers and data consistently

As the bug report says, data and columns should generally
have the same alignment. Move all the alignment calculation
to one spot and do it consistently.

M  +28   -41   processui/ProcessModel.cpp

https://invent.kde.org/plasma/libksysguard/commit/bc59d3f6532aaf34d738444a566ab491dd4b5fbc

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=394467

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #9 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/libksysguard/-/merge_requests/34

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=394467

gr...@kde.org changed:

   What|Removed |Added

 CC||gr...@kde.org
 Status|REOPENED|CONFIRMED

--- Comment #8 from gr...@kde.org ---
It's helpful to spell out the issues, possibly drawing big red arrows on
screenshots, when dealing with visual bugs. Not everyone sees these things.

- PID header center data right
- Memory header center data right

I don't have a sufficiently working KSysGuard at the moment to check other
columns, it would be useful Karl or Patrick if you write up a list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Karl Ove Hufthammer]

https://bugs.kde.org/show_bug.cgi?id=394467

--- Comment #7 from Karl Ove Hufthammer  ---
(In reply to Nate Graham from comment #6)
> Looks like just the name column isn't centered, right?

No, the problem is that the headers don’t have the same alignment as the data.
See https://phabricator.kde.org/D13098 for a fix of a similar (now fixed)
problem in Lokalize. Note that one has to use `Qt::AlignRight |
Qt::AlignAbsolute` instead of just `Qt::AlignRight` for things to work properly
for RTL languages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=394467

--- Comment #6 from Nate Graham  ---
Looks like just the name column isn't centered, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=394467

Patrick Silva  changed:

   What|Removed |Added

   Platform|Other   |Archlinux Packages
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
Version|5.12.5  |5.14.2

--- Comment #5 from Patrick Silva  ---
As we can see in my screenshot, the issue pointed here persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=394467

Patrick Silva  changed:

   What|Removed |Added

 Attachment #115929|ksysguard 5.14. |ksysguard 5.14.2 on Arch
description||Linux

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=394467

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #4 from Patrick Silva  ---
Created attachment 115929
  --> https://bugs.kde.org/attachment.cgi?id=115929=edit
ksysguard 5.14.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=394467

Kai Uwe Broulik  changed:

   What|Removed |Added

   Version Fixed In||5.12.6
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/lib
   ||ksysguard/7a580e83e1b2d21cd
   ||5deacb2cbba86130e1de669

--- Comment #3 from Kai Uwe Broulik  ---
Git commit 7a580e83e1b2d21cd5deacb2cbba86130e1de669 by Kai Uwe Broulik.
Committed on 24/05/2018 at 10:20.
Pushed by broulik into branch 'Plasma/5.12'.

[ProcessModel] Center more column headings

Also horizontally center TTY, Relative Start Time, and CPU Time.
Those are typically narrow columns and so should be horizontally centered like
the others.
FIXED-IN: 5.12.6

Differential Revision: https://phabricator.kde.org/D13031

M  +3-0processui/ProcessModel.cpp

https://commits.kde.org/libksysguard/7a580e83e1b2d21cd5deacb2cbba86130e1de669

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=394467

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=394467

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
Can confirm, the processor time column header is left-aligned for some reason.
Doesn't seem to be related to translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 394467] Inconsistent column alignment in KSysGuard

[Karl Ove Hufthammer]

https://bugs.kde.org/show_bug.cgi?id=394467

--- Comment #1 from Karl Ove Hufthammer  ---
Just noticed a small error in my previous comment. In the first example, it’s
the ‘PID’ (not the ‘CPU %’) header that’s centred even though the corresponding
data is (correctly) right-aligned.

-- 
You are receiving this mail because:
You are watching all bug changes.