[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=370448

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Version Fixed In|21.04.0 |21.08.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=370448

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com
 Resolution|--- |FIXED
   Version Fixed In||21.04.0
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/netw
   ||ork/ktorrent/-/commit/cb743
   ||ae6b67541649bc3f6b6e3adece2
   ||3627e017

--- Comment #6 from Rex Dieter  ---
Fixed in
https://invent.kde.org/network/ktorrent/-/commit/cb743ae6b67541649bc3f6b6e3adece23627e017

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[Steve]

https://bugs.kde.org/show_bug.cgi?id=370448

Steve  changed:

   What|Removed |Added

 CC||ulat...@yahoo.com

--- Comment #5 from Steve  ---
Created attachment 133148
  --> https://bugs.kde.org/attachment.cgi?id=133148=edit
Patch to fix the problem

The fix for this is easy...is it ever going to be applied? I have to rebuild
ktorrent every time the package is updated. Several of the trackers I use only
have the release version whitelisted.

This bug just had its 4-year anniversary...

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[howl]

https://bugs.kde.org/show_bug.cgi?id=370448

--- Comment #4 from howl  ---
Reviewing the procedure in the 4 series when tagging a release of KTorrent, for
example a future 5.1.3, this should be done in libktcore/ktversion.h:

 #include 
 #include "util/constants.h"

-#define KT_VERSION_MACRO "5.1.2"
+#define KT_VERSION_MACRO "5.1.3"

 namespace kt
 {
const bt::Uint32 MAJOR = 5;
const bt::Uint32 MINOR = 1;
-   const bt::Uint32 RELEASE = 2;
-   const bt::VersionType VERSION_TYPE = bt::DEVEL;
+   const bt::Uint32 RELEASE = 3;
+   const bt::VersionType VERSION_TYPE = bt::NORMAL;
const char VERSION_STRING[] = KT_VERSION_MACRO;
 }


Also when the release is a Release Candidate the way is:
#define KT_VERSION_MACRO "5.2rc1"
const bt::Uint32 MAJOR = 5;
const bt::Uint32 MINOR = 2;
const bt::Uint32 RELEASE = 1;
VERSION_TYPE = bt::RELEASE_CANDIDATE

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[howl]

https://bugs.kde.org/show_bug.cgi?id=370448

--- Comment #3 from howl  ---
As Pino said 5.1 still affected, I have changed the version of the bug because
I suppouse 5.0 is not going to be solved so let's see if at least 5.1.

5.1.1 identifies itself as 5.1dev.

Even looking at the code in the 5.1.2 tarball someone is not updating the
version numbers as release is 1 instead of 2.

The only variable that is getting properly updated is KT_VERSION_MACRO but
still the version_type is being bt::DEVEL for all the releases since 5.0.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[howl]

https://bugs.kde.org/show_bug.cgi?id=370448

howl  changed:

   What|Removed |Added

Version|5.0 |5.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=370448

Pino Toscano  changed:

   What|Removed |Added

 CC||howl@gmail.com

--- Comment #2 from Pino Toscano  ---
*** Bug 383149 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=370448

Pino Toscano  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
Summary|Ktorrent 5.0 and 5.0.1  |Ktorrent stable tarballs
   |stable tarballs has |have VERSION_TYPE =
   |VERSION_TYPE = bt::DEVEL in |bt::DEVEL in ktversion.h,
   |ktversion.h |and thus identified as
   ||development client

--- Comment #1 from Pino Toscano  ---
Happens with 5.1 as well.

Also, the kt::MINOR and kt::RELEASE variables are outdated.

-- 
You are receiving this mail because:
You are watching all bug changes.