[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=366609

--- Comment #11 from Martin Flöser  ---
(In reply to Dr. Chapatin from comment #10)
> duplicate?
> https://bugs.kde.org/show_bug.cgi?id=379635
> 
> This bug is still valid for context menus from task manager and tray icons
> on plasma 5.10.5.

No that is not a duplicate. It's a bug in Qt.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=366609

--- Comment #10 from Dr. Chapatin  ---
duplicate?
https://bugs.kde.org/show_bug.cgi?id=379635

This bug is still valid for context menus from task manager and tray icons on
plasma 5.10.5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kwi
   ||n/1193b0da771a5d1042bf2aed0
   ||a2727f89ddf488e
 Resolution|--- |FIXED
   Version Fixed In||5.10

--- Comment #9 from Martin Gräßlin  ---
Git commit 1193b0da771a5d1042bf2aed0a2727f89ddf488e by Martin Gräßlin.
Committed on 07/04/2017 at 14:14.
Pushed by graesslin into branch 'master'.

Initial support for popup window handling

Summary:
So far KWin did not properly handle popup windows. That is when a popup
surface got created and a click outside the surface happened KWin did not
send out the popupDone Wayland event.

This change makes KWin aware of whether a surface is a popup and tracks
through a new PopupInputFilter whether there are popup windows. In case
there are popups the new filter waits for mouse press events and cancels
the popups if the press does not happen on any surface belonging to the
same client. To quote the relevant section of the Wayland documentation:

The popup grab continues until the window is destroyed or a mouse
button is pressed in any other client's window. A click in any of the
client's surfaces is reported as normal, however, clicks in other
clients' surfaces will be discarded and trigger the callback.

So far the support is still incomplete. Not yet implemented are:
 * support xdg_shell popup windows
 * verifying whether the popup is allowed to be a popup
 * cancel the popup on more global interactions like screen lock or
   kwin effect
FIXED-IN: 5.10

Test Plan: Auto test and manual testing with QtWayland client

Reviewers: #plasma, #kwin

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D5177

M  +1-0CMakeLists.txt
M  +81   -0autotests/integration/pointer_input.cpp
M  +2-0input.cpp
M  +0-1pointer_input.cpp
A  +80   -0popup_input_filter.cpp [License: GPL (v2/3)]
A  +50   -0popup_input_filter.h [License: GPL (v2/3)]
M  +16   -0shell_client.cpp
M  +3-0shell_client.h
M  +26   -0toplevel.h

https://commits.kde.org/kwin/1193b0da771a5d1042bf2aed0a2727f89ddf488e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D5177

--- Comment #8 from Martin Gräßlin  ---
I'm very happy to tell that I just implemented basic support for popup windows:
https://phabricator.kde.org/D5177

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 CC||2112...@jeffcoschools.us

--- Comment #7 from Martin Gräßlin  ---
*** Bug 377821 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=366609

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 CC||balalic.en...@gmail.com

--- Comment #6 from Martin Gräßlin  ---
*** Bug 377527 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=366609

Dr. Chapatin  changed:

   What|Removed |Added

 CC||yy...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 CC||tro...@free.fr

--- Comment #5 from Martin Gräßlin  ---
*** Bug 377101 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 CC||rudyro...@gmail.com

--- Comment #4 from Martin Gräßlin  ---
*** Bug 374236 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[idoitprone]

https://bugs.kde.org/show_bug.cgi?id=366609

idoitprone  changed:

   What|Removed |Added

 CC||monkeyboy...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

 CC||itl964@gmail.com

--- Comment #3 from Martin Gräßlin  ---
*** Bug 370926 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

  Component|wayland-generic |input

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 366609] Context menu do not close when discarded on Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366609

Martin Gräßlin  changed:

   What|Removed |Added

  Component|components  |wayland-generic
   Assignee|notm...@gmail.com   |kwin-bugs-n...@kde.org
 Status|UNCONFIRMED |CONFIRMED
Product|frameworks-plasma   |kwin
 Ever confirmed|0   |1
Version|5.24.0  |git master

--- Comment #2 from Martin Gräßlin  ---
This is a known limitation in KWin currently. KWin does not (yet) handle popups
correctly and doesn't dismiss them when clicking somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.