[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=368393

Martin Gräßlin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kwi
   ||n/9934f5b57537feae54afd0c43
   ||66c90253638ada2
 Resolution|--- |FIXED

--- Comment #5 from Martin Gräßlin  ---
Git commit 9934f5b57537feae54afd0c4366c90253638ada2 by Martin Gräßlin.
Committed on 29/11/2016 at 11:35.
Pushed by graesslin into branch 'master'.

Properly implement maximize of ShellClient

Summary:
This brings some more checks from Client to ShellClient. Thus the
states are better adjusted.

Unfortunately the X11 implementation is also slightly adjusted, so could
create regressions in worst case.

Reviewers: #kwin, #plasma_on_wayland

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D3507

M  +0-1autotests/integration/quick_tiling_test.cpp
M  +4-3geometry.cpp
M  +42   -0shell_client.cpp

https://commits.kde.org/kwin/9934f5b57537feae54afd0c4366c90253638ada2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=368393

Martin Gräßlin  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D3507
  Flags||ReviewRequest+

--- Comment #4 from Martin Gräßlin  ---
and put to review: https://phabricator.kde.org/D3507

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=368393

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368393

--- Comment #3 from Martin Gräßlin  ---
Created attachment 101119
  --> https://bugs.kde.org/attachment.cgi?id=101119=edit
POC patch

Proof of concept patch which fixes the problem. But it shuffles quite some code
around and I fear it could create regressions on X11, so needs way more
testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368393

--- Comment #2 from Martin Gräßlin  ---
Currently trying to fix it. The root problem is that changeMaximize does not
yet implement all checks for ShellClient which are implemented for Client. This
results in the window not being set as QuickTileMaximized when being maximized
and thus it doesn't go out of the state when starting to move.

I have an implementation which fixes the problem but breaks another unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368393

Martin Gräßlin  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Martin Gräßlin  ---
I have been using this for months without noticing. Thanks for reporting!
Apparently I only use it to move maximized windows from one screen to another.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368393] maximized wayland windows can be moved while they stay maximized

[CapsAdmin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368393

CapsAdmin  changed:

   What|Removed |Added

   Platform|Other   |Neon Packages

-- 
You are receiving this mail because:
You are watching all bug changes.