[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 renne...@protonmail.com changed: What|Removed |Added Summary|key combo does not |key combo does not |highlight URLs on Wayland |highlight URLs in Konsole ||on Wayland -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 Nicolas Fella changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||nicolas.fe...@gmx.de --- Comment #1 from Nicolas Fella --- Also happening with 5.27, so not a new behavior. What's suspicious and probably related: Using "Never" we first get wl_keyboard.key, then wl_keyboard.modifiers: [14: wl_keyboard] key: serial: 12960; time: 12368442; key: 37; state: 1 (pressed) sym: Control_L(65507), utf8: '' [14: wl_keyboard] modifiers: serial: 12961; group: 0 depressed: 0004: Control latched: locked: [14: wl_keyboard] key: serial: 12962; time: 12372454; key: 37; state: 0 (released) sym: Control_L(65507), utf8: '' [14: wl_keyboard] modifiers: serial: 12963; group: 0 depressed: latched: locked: Using other settings we get first wl_keyboard.modifiers, then wl_keyboard.key: [14: wl_keyboard] modifiers: serial: 13475; group: 0 depressed: 0004: Control latched: locked: [14: wl_keyboard] key: serial: 13477; time: 12451531; key: 37; state: 1 (pressed) sym: Control_L(65507), utf8: '' [14: wl_keyboard] modifiers: serial: 13478; group: 0 depressed: latched: locked: [14: wl_keyboard] key: serial: 13480; time: 12452327; key: 37; state: 0 (released) sym: Control_L(65507), utf8: '' https://wayland.app/protocols/wayland#wl_keyboard:event:key says > If this event produces a change in modifiers, then the resulting > wl_keyboard.modifiers event must be sent after this event. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Priority|NOR |VHI --- Comment #2 from David Edmundson --- Confirmed. Code in Xwayland is: keyboard->sendModifiers(xkb->modifierState().depressed, xkb->modifierState().latched, xkb->modifierState().locked, xkb->currentLayout()); // update global state keyboard->sendKey(event->nativeScanCode(), state, xwaylandClient); // to only xwayland that's clearly wrong, but it's not a super trivial fix either. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6106 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 Nate Graham changed: What|Removed |Added Severity|normal |minor CC||n...@kde.org Priority|VHI |NOR --- Comment #4 from Nate Graham --- Cosmetic issue affecting non-default settings with a known workaround; lowering severity and priority. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 --- Comment #5 from Nicolas Fella --- The Konsole issue is minor, but the root cause potentially affects a lot more apps in unknown ways -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 --- Comment #6 from Nate Graham --- What are other potential effects, in general terms? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 --- Comment #7 from David Edmundson --- Any wayland app that acts on modifier keys to do stuff is being given wrong data and therefore could be broken with us at fault, which is why I set it high. But the bugzilla severity doesn't really matter long term, it's being fixed either way. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 490270] key combo does not highlight URLs in Konsole on Wayland
https://bugs.kde.org/show_bug.cgi?id=490270 David Edmundson changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/kwin/-/commit/374d859493 ||1861ef7dfbed8eda5f8552aa4f8 ||25c Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #8 from David Edmundson --- Git commit 374d8594931861ef7dfbed8eda5f8552aa4f825c by David Edmundson. Committed on 24/07/2024 at 15:57. Pushed by davidedmundson into branch 'master'. xwayland: Only update keyboard modifers for XWayland's keys KeyboardInterface is a multiplexer, it has a global state to kwin that forwards events the single focussed window. XWayland also forwards events to clients, but uses the keyboard interface. It has some overloads that take a specific client, this was used for key events but not modifiers. The end result was not only that XWayland could miss a modifier update, but also that wayland clients would get modifier updates out of order. Key events must come first. M +56 -0autotests/integration/x11keyread.cpp M +9-0src/wayland/keyboard.cpp M +1-0src/wayland/keyboard.h M +34 -3src/xwayland/xwayland.cpp https://invent.kde.org/plasma/kwin/-/commit/374d8594931861ef7dfbed8eda5f8552aa4f825c -- You are receiving this mail because: You are watching all bug changes.
