[marble] [Bug 316969] crashed always when importing a bookmark file

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=316969

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #16 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #15 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[topas]

https://bugs.kde.org/show_bug.cgi?id=316969

topas  changed:

   What|Removed |Added

 CC||tobias.boe...@googlemail.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[topas]

https://bugs.kde.org/show_bug.cgi?id=316969

topas  changed:

   What|Removed |Added

 CC|topas-...@web.de|

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=316969

Justin Zobel  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #14 from Justin Zobel  ---
Thank you for the report.

As it has been a while since this was reported, can you please test and confirm
if this issue is still occurring or if this bug report can be marked as
resolved.

I have set the bug status to "needsinfo" pending your response, please change
back to "reported" or "resolved/worksforme" when you respond, thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Mike Somov]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #13 from Mike Somov  ---
Created attachment 104741
  --> https://bugs.kde.org/attachment.cgi?id=104741=edit
New crash information added by DrKonqi

keditbookmarks (4.14.13) on KDE Platform 4.14.13 using Qt 4.8.6

crashed always when importing a bookmark file

-- Backtrace (Reduced):
#7  begin (this=0x0) at /usr/include/qt4/QtCore/qlist.h:267
#8  TreeItem::deleteChildren (this=0x0, first=-1, last=-1) at
../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:76
#9  0x7f2bb3dd4132 in KBookmarkModel::removeBookmark (this=0x2164190,
bookmark=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:451
#10 0x7f2bb3dcf851 in CreateCommand::undo (this=0x2ce6ca0) at
../../../keditbookmarks/kbookmarkmodel/commands.cpp:156
#11 0x7f2bb3dd150e in DeleteCommand::redo (this=0x2c24890) at
../../../keditbookmarks/kbookmarkmodel/commands.cpp:320

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Mike Somov]

https://bugs.kde.org/show_bug.cgi?id=316969

Mike Somov  changed:

   What|Removed |Added

 CC||spiritfrom...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #12 from Dennis Nienhüser  ---
Backporting would be nice, but needs some changes:
- avoid return type change of BookmarkManager::addNewBookmarkFolder() in order
to keep ABI. Can be done by introducing a new
BookmarkManager::addBookmarkFolder()
- ideally also move importBookmarksRecursively to the private class like done
in 7bfecba. The move of the second method shouldn't be done though as that
involves l10n changes

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #11 from Dennis Nienhüser  ---
This one got lost somehow:

commit 251b8f280
Author: Sergey Popov 
Date:   Sat Jan 7 11:56:06 2017 +0100

Fix importing of bookmarks

Summary:
Also cleared some comments in BookmarkManager.h
Fixes BUG:316969
Related Google Code-In 2016 task:
https://codein.withgoogle.com/dashboard/task-instances/6308606150443008/

Reviewers: nienhueser, rahn

Subscribers: rahn, nienhueser

Differential Revision: https://phabricator.kde.org/D3989

BUG: 316969
FIXED-IN: Applications/17.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #10 from Dennis Nienhüser  ---
Git commit 7bfecba79239f91b459dcdfc81a4124d21e8ba5a by Dennis Nienhüser.
Committed on 07/01/2017 at 11:46.
Pushed by nienhueser into branch 'master'.

API cleanup: Move methods to private class, rename for clarity

M  +2-2src/lib/marble/BookmarkManager.cpp
M  +1-1src/lib/marble/BookmarkManager.h
M  +24   -17   src/lib/marble/BookmarkManagerDialog.cpp
M  +0-5src/lib/marble/BookmarkManagerDialog.h

https://commits.kde.org/marble/7bfecba79239f91b459dcdfc81a4124d21e8ba5a

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

--- Comment #9 from Dennis Nienhüser  ---
GCI task https://codein.withgoogle.com/tasks/5107915830591488/ should take care
of this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

Dennis Nienhüser  changed:

   What|Removed |Added

 CC||flywh...@illogical.dk

--- Comment #8 from Dennis Nienhüser  ---
*** Bug 373750 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=316969

Dennis Nienhüser  changed:

   What|Removed |Added

 CC||begle...@gmail.com

--- Comment #7 from Dennis Nienhüser  ---
*** Bug 331312 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 316969] crashed always when importing a bookmark file

[topas via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=316969

topas  changed:

   What|Removed |Added

 CC||topas-...@web.de

--- Comment #6 from topas  ---
Found a workaround:

1. Make shure Marble is not running.

2. Just paste your whole import file or merge your differences into
/home/[yourusername]/.local/share/marble/bookmarks/bookmarks.kml

3. Start Marble. (Started without a crash on my Ubuntu 16.04)

-- 
You are receiving this mail because:
You are watching all bug changes.