[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 Nate Graham changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Version Fixed In||1.11.3 Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/777ac37e ||a21212c4d924c75be5cee502ad5 ||820c0 --- Comment #7 from Nate Graham --- Git commit 777ac37ea21212c4d924c75be5cee502ad5820c0 by Nate Graham. Committed on 21/10/2020 at 17:52. Pushed by ngraham into branch 'release/20.08'. Fix fast scrolling with Shift+Scroll When holding down the shift key, multiply wheel and touchpad scroll distances by 10 to re-implement the fast scrolling feature that broke when we added animated/smooth scrolling. FIXED-IN: 1.11.3 M +5-2ui/pageview.cpp https://invent.kde.org/graphics/okular/commit/777ac37ea21212c4d924c75be5cee502ad5820c0 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 --- Comment #6 from Patrick --- Ok, thanks. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/298 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 --- Comment #4 from Nate Graham --- I guess not. I'll submit it myself then, but I'll use your authorship info. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 --- Comment #3 from Nate Graham --- Thanks Patrick. That works great for me. Would you like to submit it as a merge request (targeting the `release/20.08` branch) at https://invent.kde.org/graphics/okular/-/merge_requests/? That would be lovely. Here's the supporting documentation: https://community.kde.org/Infrastructure/GitLab -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889
--- Comment #2 from Patrick ---
The original shift+wheel behavior was handled by QAbstractSlider (in
QAbstractSliderPrivate::scrollByDelta), which is inherited by QScrollBar and
triggered by QAbstractScrollArea::wheelEvent.
Possible fix:
--- src/okular-20.08.2/ui/pageview.cpp 2020-10-05 08:26:20.0 +0200
+++ pageview.cpp2020-10-16 14:59:28.407667911 +0200
@@ -3123,7 +3123,9 @@ void PageView::wheelEvent(QWheelEvent *e
d->scroller->scrollTo(QPoint(horizontalScrollBar()->value(),
verticalScrollBar()->value()), 0); // sync scroller with scrollbar
}
} else {
-if (delta != 0 && delta % QWheelEvent::DefaultDeltasPerStep == 0)
{
+if ((e->modifiers() & Qt::ShiftModifier) == Qt::ShiftModifier) {
+QAbstractScrollArea::wheelEvent(e);
+} else if (delta != 0 && delta % QWheelEvent::DefaultDeltasPerStep
== 0) {
// number of scroll wheel steps Qt gives to us at the same
time
int count = abs(delta / QWheelEvent::DefaultDeltasPerStep);
if (delta < 0) {
--
You are receiving this mail because:
You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 Miles Krell changed: What|Removed |Added CC||k...@mileskrell.com -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 Albert Astals Cid changed: What|Removed |Added CC||oliver.san...@tu-dresden.de -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 420889] Shift+scroll wheel behavior broke
https://bugs.kde.org/show_bug.cgi?id=420889 Nate Graham changed: What|Removed |Added Priority|NOR |VHI Keywords||regression Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Summary|Shift+scroll wheel |Shift+scroll wheel behavior |behaviour changed |broke --- Comment #1 from Nate Graham --- Can confirm. I didn't even know this feature existed! -- You are receiving this mail because: You are watching all bug changes.
