[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/okular/commit/8b008b02 |hics/okular/commit/843c43cc |fc31e20f7c74ab2c25d34160756 |6ba82a80db86e0a5ed11e27e255 |c7a92 |cd851 --- Comment #6 from Nate Graham --- Git commit 843c43cc6ba82a80db86e0a5ed11e27e255cd851 by Nate Graham, on behalf of David Hurka. Committed on 21/10/2020 at 00:52. Pushed by ngraham into branch 'master'. Fix cursor not updated after clicking internal link updateCursor() was called by wheelEvent(), which made sense, because after the wheel event the page will have moved under the cursor. With smooth scrolling, it makes less sense in wheelEvent(), because at that point scrolling is still in the future. scrollContentsBy() appears to be called on every scroll step. (It is documented to be called at scrollbar value changes, so makes sense.) This patch removes updateCursor() from wheelEvent(), but adds it to scrollContentsBy(). I did not check anything out with d->visibleItems, as was indicated it graphics/okular!176. M +0-4autotests/parttest.cpp M +5-2ui/pageview.cpp https://invent.kde.org/graphics/okular/commit/843c43cc6ba82a80db86e0a5ed11e27e255cd851 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Nate Graham changed: What|Removed |Added Version Fixed In||1.11.3 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/8b008b02 ||fc31e20f7c74ab2c25d34160756 ||c7a92 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from Nate Graham --- Git commit 8b008b02fc31e20f7c74ab2c25d34160756c7a92 by Nate Graham, on behalf of David Hurka. Committed on 21/10/2020 at 00:40. Pushed by ngraham into branch 'release/20.08'. Fix cursor not updated after clicking internal link updateCursor() was called by wheelEvent(), which made sense, because after the wheel event the page will have moved under the cursor. With smooth scrolling, it makes less sense in wheelEvent(), because at that point scrolling is still in the future. scrollContentsBy() appears to be called on every scroll step. (It is documented to be called at scrollbar value changes, so makes sense.) This patch removes updateCursor() from wheelEvent(), but adds it to scrollContentsBy(). I did not check anything out with d->visibleItems, as was indicated it graphics/okular!176. M +5-2ui/pageview.cpp https://invent.kde.org/graphics/okular/commit/8b008b02fc31e20f7c74ab2c25d34160756c7a92 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/297 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 --- Comment #3 from Nate Graham --- Git commit da934a0a0aad36e03c6c313a67ef30afabec58a3 by Nate Graham, on behalf of Oliver Sander. Committed on 13/10/2020 at 18:35. Pushed by ngraham into branch 'master'. Make cursor open hand again after clicking on internal link M +7-0autotests/parttest.cpp https://invent.kde.org/graphics/okular/commit/da934a0a0aad36e03c6c313a67ef30afabec58a3 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 --- Comment #2 from Oliver Sander --- I did some initial investigations at https://invent.kde.org/graphics/okular/-/merge_requests/176. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Albert Astals Cid changed: What|Removed |Added CC||oliver.san...@tu-dresden.de -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link
https://bugs.kde.org/show_bug.cgi?id=421437 Albert Astals Cid changed: What|Removed |Added CC||keziolio...@gmail.com, ||n...@kde.org --- Comment #1 from Albert Astals Cid --- Seems like another regression of the QScroller patch, please have a look -- You are receiving this mail because: You are watching all bug changes.
