[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 Armin changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #10 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/426 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #9 from Albert Astals Cid --- Just do it and reference the other merge request, it will fail to compile and that's *good* -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #8 from Michal Vlasák --- (In reply to Albert Astals Cid from comment #7) > Please read > https://community.kde.org/Infrastructure/GitLab#Submitting_a_merge_request I am very sorry for wasting your time due to my mistake. I completely overlooked that I had not yet forked okular repository. I somehow got confused because I have previously done so for poppler. Would it be worth to open this merge request when 'instance->asset()' is not yet possible with current poppler? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #7 from Albert Astals Cid --- Please read https://community.kde.org/Infrastructure/GitLab#Submitting_a_merge_request -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #6 from Michal Vlasák --- (In reply to Albert Astals Cid from comment #3) > > It seems that I can't create new merge request normally. > > You're going to need to be a bit more verbose on what's the problem you're > having ;) Sorry for being unclear. I don't see the button normally used for creating merge requests. I thought it was intentionally limited only to orginization members. (The difference between poppler/okular repositories is visible in files attached above). -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #5 from Michal Vlasák --- Created attachment 138261 --> https://bugs.kde.org/attachment.cgi?id=138261&action=edit okular merge requests -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #4 from Michal Vlasák --- Created attachment 138260 --> https://bugs.kde.org/attachment.cgi?id=138260&action=edit poppler merge requests -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 Albert Astals Cid changed: What|Removed |Added CC||[email protected] --- Comment #3 from Albert Astals Cid --- > It seems that I can't create new merge request normally. You're going to need to be a bit more verbose on what's the problem you're having ;) -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 --- Comment #2 from Michal Vlasák --- (In reply to Nate Graham from comment #1) > Thanks; can you please submit code in the form of a merge request at > https://invent.kde.org/graphics/okular/-/merge_requests? It seems that I can't create new merge request normally. Maybe "E-mail a new merge request to this project" will work, but I didn't try. I didn't even think this is ready for merge request, yet: - it requires changes in poppler, that I didn't yet implement correctly, - there may be more to it, and I am probably not entitled to do the decision. My patch was more or less a rough sketch of what somebody more knowledgeable may do. For instance, I changed the handling of "Instance::Type*" to allow even audio (which works fine in Okular IIRC) but I don't know how mismatched the Flash/Audio/Video type is in real PDFs (there probably was a reason why it was like set like that). Another thing I remembered: currently Acrobat uses very similiar code to Okular's to play Flash video (it no longer uses Flash player). But because Flash-less Rich Media doesn't normally have controls it emulates it if it finds a certain "skin" in `/Params`. Doing same in Okular may bring it up to par with current Acrobat for old documents. Details can be found at https://gitlab.com/agrahn/media9/-/issues/9#note_554144989. I also noticed, that Okular currently unconditionally uses first RichMediaConfiguration, which works for all usual cases, but handling this generally wouldn't be hard. All in all, I would like to first get poppler to even allow for the code above and in the mean time get feedback from you guys to know whether it could work like this. I didn't even manage to get it running. Is there Okular/Qt way I can use to assure myself that I am even running the code I added? I didn't find success with std::out. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations
https://bugs.kde.org/show_bug.cgi?id=436710 Nate Graham changed: What|Removed |Added CC||[email protected] --- Comment #1 from Nate Graham --- Thanks; can you please submit code in the form of a merge request at https://invent.kde.org/graphics/okular/-/merge_requests? -- You are receiving this mail because: You are watching all bug changes.
