[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #13 from Harald Sitter --- Git commit 984a4e9acee45dca1aa5bcc69294b536930a20c2 by Harald Sitter. Committed on 28/06/2017 at 11:51. Pushed by sitter into branch 'master'. fix device RO check Summary: - mark deviceNode const - copy it as deviceName - mutate deviceName by removing `/dev/` - use the new deviceName for the read-only check this makes sure we emit the unmodified deviceNode (e.g. /dev/vda) rather than the name (e.g. vda). unbreaks for example calamares which doesn't know what to do with "vda". Test Plan: - without fix clamares fails to list devices - with the fix calamares lists devices Reviewers: stikonas Reviewed By: stikonas Differential Revision: https://phabricator.kde.org/D6414 M +4-2src/plugins/libparted/libpartedbackend.cpp https://commits.kde.org/kpmcore/984a4e9acee45dca1aa5bcc69294b536930a20c2 -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Andrius Štikonas changed: What|Removed |Added Status|VERIFIED|RESOLVED Latest Commit|https://commits.kde.org/kpm |https://commits.kde.org/kpm |core/fda1e219de430d1301839e |core/a35702e9113d655ffcc4b2 |27790e108b12c4 |ffc06e791f256d0beb --- Comment #12 from Andrius Štikonas --- Git commit a35702e9113d655ffcc4b2ffc06e791f256d0beb by Andrius Štikonas. Committed on 22/06/2017 at 02:11. Pushed by stikonas into branch 'master'. Use lsblk's TYPE=disk when scanning for devices. The previous way relied on kernel device numbers but this gets ugly, especially in cases when device number is not assigned such as virtio disks. M +2-2src/backend/corebackend.cpp M +16 -19 src/plugins/libparted/libpartedbackend.cpp https://commits.kde.org/kpmcore/a35702e9113d655ffcc4b2ffc06e791f256d0beb -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Andrius Štikonas changed: What|Removed |Added Version Fixed In||kpmcore 3.2.0 --- Comment #11 from Andrius Štikonas --- Ok, thanks for lsblk. So far it still looks like TYPE=disk might work much simpler. Loop devices seems to have different TYPE as well, so they won't appear in calamares. But anyway, this is not too urgent. Can probably just go into next feature release. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #10 from Harald Sitter --- Created attachment 106210 --> https://bugs.kde.org/attachment.cgi?id=106210&action=edit lsblk -a -O output -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #9 from Harald Sitter --- Created attachment 106209 --> https://bugs.kde.org/attachment.cgi?id=106209&action=edit lsblk -a output I am also attaching lsblk output for reference -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Harald Sitter changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #8 from Harald Sitter --- Works like a charm with new master build. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #7 from Andrius Štikonas --- Looks like it might be possible to improve device detection by looking at lsblk's TYPE column and check for "disk". Then we can avoid using major numbers entirely. I'll try to do this later but Calamares should already work after tonight when kpmcore will be rebuilt. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Andrius Štikonas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit||https://commits.kde.org/kpm ||core/fda1e219de430d1301839e ||27790e108b12c4 --- Comment #6 from Andrius Štikonas --- Git commit fda1e219de430d1301839e27790e108b12c4 by Andrius Štikonas. Committed on 20/06/2017 at 14:51. Pushed by stikonas into branch 'master'. Add more major device numbers for virtio. M +1-1src/plugins/libparted/libpartedbackend.cpp https://commits.kde.org/kpmcore/fda1e219de430d1301839e27790e108b12c4 -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #5 from Andrius Štikonas --- Looks like virtio can use various device numbers often in the range 240-254 (https://lkml.org/lkml/2016/3/2/930) In principle I can add the whole range to whitelist. Any better solutions? -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #4 from Andrius Štikonas --- Hmm, I was told virtio major device number is 253. But when I'm trying here locally I see 252. What does lsblk report to you? -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 --- Comment #3 from Harald Sitter --- Created attachment 106187 --> https://bugs.kde.org/attachment.cgi?id=106187&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Harald Sitter changed: What|Removed |Added CC||[email protected] Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #2 from Harald Sitter --- I do not think this is working TBH. I am trying neon unstable which has master builds of kpmcore and partitionmanager, yet the virtio device does not show up. To reproduce with virt-manager: - create new VM - use neon unstable as seed ISO - create new disk - customize config before install - on IDE Disk 1 switch the advanaced setting for the disk bus from IDE to VirtIO - apply and begin install - try to install with calamares -> no devices - `pkcon install partitionmanager` -> no devices - `parted; print all` -> lists virtio as expected -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 378607] virtio devices not found (vda)
https://bugs.kde.org/show_bug.cgi?id=378607 Andrius Štikonas changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Andrius Štikonas --- Virtio support was implemented recently. It is just not released. But you can always grab kpmcore git master. It doesn't have that many changes and should be stable (might need recompilation of calamares and partitionmanager although, I'm not 100% sure. It might just work). -- You are receiving this mail because: You are watching all bug changes.
