[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181
David Redondo changed:
What|Removed |Added
Version Fixed In||5.17.0
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/pla
||sma-workspace/ea32a7611227c
||a141bd60d983d1489d2be82d10f
--- Comment #16 from David Redondo ---
Git commit ea32a7611227ca141bd60d983d1489d2be82d10f by David Redondo.
Committed on 25/07/2019 at 10:05.
Pushed by davidre into branch 'master'.
[Image Wallpaper Slideshow] Allow setting of different sorting orders
Summary:
Allows setting of other sorting orders like alphabetical or last modified date.
To enable this a new ProxyModel is introduced which handles the sorting and
filtering (as indicated by the checkboxes). This is backed by the
slideshowModel
whcih previously as only used for the configutation. The lists of slides and
unseen
slides are dropped as now the slides that are shown are taken from the model.
FIXED-IN: 5.17.0
Test Plan:
{F6938259}
{F6938260}
{F6938261}
{F6938263}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22121
M +1-0wallpapers/image/CMakeLists.txt
M +1-1wallpapers/image/backgroundlistmodel.h
M +75 -81 wallpapers/image/image.cpp
M +23 -6wallpapers/image/image.h
M +5-3wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
M +52 -2wallpapers/image/imagepackage/contents/ui/config.qml
M +8-2wallpapers/image/imagepackage/contents/ui/main.qml
A +90 -0wallpapers/image/slidefiltermodel.cpp [License: GPL (v2+)]
A +50 -0wallpapers/image/slidefiltermodel.h [License: GPL (v2+)]
M +19 -0wallpapers/image/slidemodel.cpp
M +22 -0wallpapers/image/slidemodel.h
M +4-1wallpapers/image/slideshowpackage/contents/config/main.xml
https://commits.kde.org/plasma-workspace/ea32a7611227ca141bd60d983d1489d2be82d10f
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Filip Fila changed: What|Removed |Added CC||filipfila@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #15 from David Redondo --- For the use case mentioned Michał there could be also the option to sort all images alphabetically in addition to the modes mentioned by David. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 David Redondo changed: What|Removed |Added CC||k...@david-redondo.de -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #14 from Michał Dybczak --- Yes. Even without an option to set the order of chosen images, we can then influence it by renaming the files and in the result, we gain control over what is shown in what order. That would work for me. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #13 from Nate Graham --- (In reply to Mihai Sorin Dobrescu from comment #12) > Probably some UI choice is necessary (random - as it is now, sorted - by one > or more criteria). Yep. Allowing corting by just a single criterion is the simplest and most comprehensible approach, so we would have something like a "Sort order" combobox with the options "Random" "Alphabetical" "Date modified" and whatever else might be useful. As for your development environment, I actually use a KDE Neon Dev Unstable VM to do my Plasma work and I find that this works very well. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 razrfal...@gmail.com changed: What|Removed |Added CC|razrfal...@gmail.com| -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #12 from Mihai Sorin Dobrescu --- Probably some UI choice is necessary (random - as it is now, sorted - by one or more criteria). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #11 from David Edmundson --- This wiki may help: https://community.kde.org/Get_Involved/development BackgroundListModel isn't the easiest starting point for KDE, it's needlessly overengineered (in a bad way) old code. There are two things to sort: 1) sorting wallpapers within a folder 2) sorting the folders themselves The flag you suggest will solve 1. 2 will remain unsorted, but it is at least deterministic, which might be enough? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #10 from Mihai Sorin Dobrescu --- I'd love to, but I need to learn QT and KDE first, I have no experience with these, except for using KDE on a daily basis. Also, I am totally noob at Linux development (I can get some sources and make so far). And KDE development setup is a completely unknown to me. I can try, sure, probably in a virtual machine? I've no idea what's the right, recomended and preferred Linux flavour for KDE development. Any hints? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Daniel Faust changed: What|Removed |Added CC|hessija...@mailbox.org | -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #9 from Nate Graham --- Yeah, that sounds about right. Since you're already on the path, would you like to try your hand at producing a patch? You'd be making a lot of people very happy. :) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #8 from Mihai Sorin Dobrescu --- Really? I think the issue is here: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/backgroundlistmodel.cpp#n551 When calling QDir::entryInfoList(), no sort flags are specified. Only filters are set here: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/backgroundlistmodel.cpp#n543 Well, is more, to add options in the UI (probably where you've prompted), manage them etc.. I might be wrong, after all, I'm just a developer seeing the QT for the first time... -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #7 from Nate Graham --- Here's the code, if you'd like to have a go at it: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/imagepackage/contents/ui/config.qml -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 --- Comment #6 from Mihai Sorin Dobrescu --- Oh, I have reported a duplicate bug. So old this one, reported 10 yeas ago and nobody cares! I wonder where is the source code, what is the difficulty? Should be simple... -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Nate Graham changed: What|Removed |Added CC||msdobre...@gmail.com --- Comment #5 from Nate Graham --- *** Bug 405774 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Michał Dybczak changed: What|Removed |Added CC||michal.dybc...@gmail.com --- Comment #4 from Michał Dybczak --- I support this idea because I had the same one recently, after reading this article about dynamic wallpapers: http://technastic.com/macos-mojave-dynamic-wallpaper-on-linux/ I also tried it and had no success because of the randomness of the slideshow setting and thought that having an option to disable randomness would do the trick. So with 16 pictures, I could set change of picture every 1,5 hour, count which one should be used at certain hour (like 3 pm) and then next-skip to the appropriate one and then natural time progress would make it work. I soon realized, we need more then that. Suspending system suspends also time tracking for wallpaper switcher, so we would also had option to change from independent time to real (computer) time to make this work. I'm not talking about generally disabling randomness or independent time - current slideshow options is great and works fine. Just those additional options would allow for creation of time depended wallpaper sets. This would be an obscure setting but still a fun thing to do and a good topic for articles on "how to do this on Plasma". Just a thought ;). Hopefully someone will think about it some day and add this. Thanks :) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Dimitri changed: What|Removed |Added CC||thecursed...@yahoo.it -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Daniel Faust changed: What|Removed |Added CC||razrfal...@gmail.com --- Comment #3 from Daniel Faust --- *** Bug 299315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Daniel Faust changed: What|Removed |Added CC||simonandr...@gmail.com --- Comment #2 from Daniel Faust --- *** Bug 337404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 186181] Add config options for wallpaper slideshow order
https://bugs.kde.org/show_bug.cgi?id=186181 Daniel Faust changed: What|Removed |Added Component|wallpaper-image |Image Wallpaper Product|plasma4 |plasmashell CC||hessija...@mailbox.org, ||plasma-b...@kde.org Target Milestone|--- |1.0 Version|unspecified |5.8.0 Summary|Desktop slideshow as|Add config options for |animation |wallpaper slideshow order -- You are receiving this mail because: You are watching all bug changes.
