[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Marco Martin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

Marco Martin  changed:

   What|Removed |Added

Version|5.24.0  |5.7.5
  Component|components  |Application Launcher
   ||(Kickoff)
   Assignee|notm...@gmail.com   |k...@davidedmundson.co.uk
Product|frameworks-plasma   |plasmashell
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #18 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #17)
> IMHO, it's more plasmoid design issue than theme bug. If there are 2 buttons
> with the same action in an application ("Poweroff " etc buttons in menu),
> likely they should look the same. 

Yes, this general inconsistency is a plasma design "issue" if you will.
There is another bug report about this IIRC (I'm not sure if it is still open
or has been closed, can't find it at the moment).

But that Kickoff's tab icons and the launcher icon itself are taken from the
icon theme in these particular cases is a bug in the themes, which should be
fixed in the themes.

> At least in System Settings' case SS keeps "thinking" that old icons theme
> is still used

That's unrelated to the icon cache though IMHO.
Rather sounds like a problem with actually saving the selected icon theme to
kdeglobals to me...
But yes, this should not really be discussed here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #17 from Pulfer  ---
(In reply to Wolfgang Bauer from comment #16)
> I am not sure about your review request though.
> On the one hand you "complain" that some icons are taken from the icon
> theme, and you want to fix that by taking *all* icons from the icon theme?
> ;-)

I rather "complain" that in general menu plasmoids' contents look inconsistent
because of mixed icon sources. The only exception is desktop themes having the
same icons as icon themes. But in such cases it works the same way as if
"usesPlasmaTheme: false" was set.

> The desktop themes should be fixed IMHO.

IMHO, it's more plasmoid design issue than theme bug. If there are 2 buttons
with the same action in an application ("Poweroff " etc buttons in menu),
likely they should look the same. 

> And AFAIK, the icon module actually deletes the icon cache when you switch to 
> a different theme.

At least in System Settings' case SS keeps "thinking" that old icons theme is
still used (if you press back button instead of closing SS with KCM icons after
applying new icons theme). So it inserts icons from older theme to icons cache.
Maybe some other applications do the same. But likely it's better to discuss in
#365363 anyway...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #16 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #14)> Likely it's caused by
https://bugs.kde.org/show_bug.cgi?id=365363 (System
> Setting may damage icons cache)

Not really.
The Plasma theme cache is independent from the icon cache (which is in
~/.cache/icon-cache.kcache).
I definitely don't see that problem you describe there.
And AFAIK, the icon module actually deletes the icon cache when you switch to a
different theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #15 from Wolfgang Bauer  ---
Ok, you're right, sorry.
I can reproduce your problem now:
When switching the desktop theme to Air or Oxygen, Kickoff indeed takes some
icons from the icon theme (to be precise, the icons for the Favorites,
Applications, and Computer tabs, and the application launcher icon itself).
Not sure why I didn't see that before, maybe I switched the icon theme as well
when I tested it...

This seems  to be a problem/bug in those desktop themes though, not in Plasma
or Kickoff.
If I set Breeze as desktop theme and switch the icon theme to Oxygen, those
icons are still Breeze (i.e. they are in fact taken from the desktop theme).

Another problem is that switching the icon theme has no effect on running
applications (including Plasma), but there is a bug report about that I think.

I am not sure about your review request though.
On the one hand you "complain" that some icons are taken from the icon theme,
and you want to fix that by taking *all* icons from the icon theme? ;-)
The desktop themes should be fixed IMHO.

Though personally I do agree that it can be confusing that some icons are taken
from the icon theme, while others are taken from the desktop theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #14 from Pulfer  ---
(In reply to Wolfgang Bauer from comment #12)
> (In reply to Pulfer from comment #10)
> > Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I
> > guess there's a typo there ("system-user" element instead of 
> > "system-users").
> 
> No, works fine here.
> 
> Maybe a caching issue?
> Try to delete ~/.cache/plasma* when Plasma is not running.

Likely it's caused by https://bugs.kde.org/show_bug.cgi?id=365363 (System
Setting may damage icons cache)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #13 from Wolfgang Bauer  ---
PS: changing "Look and Feel" apparently doesn't work fully in 5.7.0.
I can confirm that.

But probably worth a specific bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #12 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #10)
> Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I
> guess there's a typo there ("system-user" element instead of "system-users").

No, works fine here.

Maybe a caching issue?
Try to delete ~/.cache/plasma* when Plasma is not running.

But as mentioned, I cannot reproduce your problem here on openSUSE...

> As for application launcher icon, sometimes it uses icon from Plasma theme,
> sometimes from icons theme (icon may change after system reboot). 

I noticed this when I change themes, it still uses the old one.
But after restarting plasmashell, this is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #11 from Pulfer  ---
(In reply to Pulfer from comment #10)
> I recorded a video where it's possible to see that launcher icon on panel is
> used from icons theme, not from plasma theme (sorry for non-English Plasma
> interface but it shouldn't matter): https://disk.yandex.ru/client/disk

Correct URL: https://yadi.sk/i/GxaIPQUBt8nBa

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #10 from Pulfer  ---
(In reply to Wolfgang Bauer from comment #8)
> > In fact, they both have such elements in start.svgz. Maybe
> > plasma-frameworks's IconItem::setSource function is buggy then.
> 
> start.svgz is only used for application launcher "icon" itself AFAIK.

Sorry, I meant system.svgz. BTW, please check system.svgz from air theme. I
guess there's a typo there ("system-user" element instead of "system-users").

As for application launcher icon, sometimes it uses icon from Plasma theme,
sometimes from icons theme (icon may change after system reboot). 

I recorded a video where it's possible to see that launcher icon on panel is
used from icons theme, not from plasma theme (sorry for non-English Plasma
interface but it shouldn't matter): https://disk.yandex.ru/client/disk

Ignore kicker favorite system actions icons on video, they are patched to use
icons theme. Also note that I replaced start-here-kde from Breeze icons theme
(color dots) with icon from Breeze plasma theme ("K"). But it's clear that
launcher uses Breeze icons theme icon if I switch desktop theme to Oxygen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #9 from Wolfgang Bauer  ---
(In reply to Wolfgang Bauer from comment #8)
> They were missing in Oxygen and Air, and have been (will be) added in KDE
> Frameworks 5.24.0:
> https://quickgit.kde.org/?p=plasma-framework.
> git=commit=7379b9b830848e09defee17b362ac10852a4f4be

Actually that is in 5.23.0 already, and it does work fine here: if I set Oxygen
or Air as desktop theme, the system favorites and Kickoff's tabs use indeed
Oxygen icons.

The other icons for Kickoffs tabs are in bookmarks.svgz, applications.svgz,
computer.svgz and view.svgz (should also be in
/usr/share/plasma/desktop-theme/*/icons/).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #8 from Wolfgang Bauer  ---
(In reply to Pulfer from comment #6)
> (In reply to Eike Hein from comment #5)
> > Maybe the Oxygen theme has no icons.
> 
> Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"
> etc in /usr/share/plasma/desktoptheme/*/icons/ (plasma theme) directories.

The corresponding icons are/should be in
usr/share/plasma/desktoptheme/*/icons/system.svgz.
They were missing in Oxygen and Air, and have been (will be) added in KDE
Frameworks 5.24.0:
https://quickgit.kde.org/?p=plasma-framework.git=commit=7379b9b830848e09defee17b362ac10852a4f4be

> There's a chance that using Breeze icon theme as fallback (if there's no
> selected icon in plasma theme) is hardcoded somewhere.

Yes, if the desktop/plasma theme is missing icons, they are taken from the
"default" plasma theme (i.e. Breeze) instead.

(In reply to Pulfer from comment #7)
> > Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"
> 
> In fact, they both have such elements in start.svgz. Maybe
> plasma-frameworks's IconItem::setSource function is buggy then.

start.svgz is only used for application launcher "icon" itself AFAIK.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #7 from Pulfer  ---
> Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot"

In fact, they both have such elements in start.svgz. Maybe plasma-frameworks's
IconItem::setSource function is buggy then.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #6 from Pulfer  ---
(In reply to Eike Hein from comment #5)
> Maybe the Oxygen theme has no icons.

Neither Breeze nor Oxygen have icons like "system-log-out", "system-reboot" etc
in /usr/share/plasma/desktoptheme/*/icons/ (plasma theme) directories. And both
have such icons in /usr/share/icons/* (icon theme) directories.

There's a chance that using Breeze icon theme as fallback (if there's no
selected icon in plasma theme) is hardcoded somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #5 from Eike Hein  ---
Maybe the Oxygen theme has no icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

Pulfer  changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

--- Comment #4 from Pulfer  ---
(In reply to Eike Hein from comment #3)
> At least in Kicker's case, the system favorites are supposed to use the 
> Plasma theme. 

Why does it use Breeze icons if Plasma theme is set to Oxygen? Is it a Plasma
bug?

> The Kickoff patch might be valid, please submit it via Phab.

https://git.reviewboard.kde.org/r/128392/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Eike Hein  ---
At least in Kicker's case, the system favorites are supposed to use the Plasma
theme. The Kickoff patch might be valid, please submit it via Phab.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #2 from Pulfer  ---
Created attachment 99929
  --> https://bugs.kde.org/attachment.cgi?id=99929=edit
Patch to make kicker and kickoff use icons from icon theme

Not sure if it's desired behaviour for upstream. But as it makes Kicker and
Kickoff look consistent, I'll apply it to ROSA's Plasma Desktop package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365204] Breeze icons are always used in some places

[Pulfer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365204

--- Comment #1 from Pulfer  ---
Created attachment 99928
  --> https://bugs.kde.org/attachment.cgi?id=99928=edit
Kickoff menu with messup up icons

Kickoff menu is also affected. Some icons are taken from Breeze them, some from
Oxygen.

-- 
You are receiving this mail because:
You are watching all bug changes.