[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matthew Woehlke]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #131 from Matthew Woehlke  ---
> Virtual memory is not a relevant measure of anything useful.

That is neither necessarily true, nor necessarily untrue. While I have seen
instances of processes having huge VIRT that didn't correspond to real memory
usage (e.g. 256G VIRT with reasonable RES), most of the time there is a strong
correlation between VIRT and actual memory use. (The other problem with RES is
it doesn't account for "real" memory that has been swapped out, AFAIK. IMO both
are useful measurements.)

At any rate, RES was insane also. Here's the full htop line:

  1893 matthew20   0 26.9G 17.1G 20308 S  0.3 54.5  3h10:59
/usr/bin/plasmashell

I doubt I can provide any *new* information. I'm using slideshow wallpaper.
After a while (not sure if it is "always" or somewhat at random; I only just
upgraded to F29 about a week or so ago), memory usage grows to unreasonable
size. The only thing I know that's "new" is that this is still happening with
qt5-5.11.1-9.fc29.x86_64. (Based on inspecting the debuginfo sources, I *do*
have 224684 applied.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #130 from David Edmundson  ---
Virtual memory is not a relevant measure of anything useful. Only Res + Shared
matter.

If you do think you have an issue with memory and confirm you have
https://codereview.qt-project.org/#/c/224684/ applied please open a new bug
with as much relevant new information as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matthew Woehlke]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #129 from Matthew Woehlke  ---
What's the story with this? Because it is apparently still happening with
qt5-5.11.1-9.fc29.x86_64... (I just killed a plasma that had ballooned to
almost 27G VIRT.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[alexander]

https://bugs.kde.org/show_bug.cgi?id=368838

alexander  changed:

   What|Removed |Added

 CC||rot...@gmx.de

--- Comment #128 from alexander  ---
(In reply to cdobrich from comment #127)
> (In reply to Rik Mills from comment #123)
> @Rik Mills @Nate Graham 
> 
> Would you please alert this thread when the fixes have made their way into
> the Kubuntu 18.04 repositories. I'm waiting on updating until this fix has
> trickled down, because it is crippling bad for my system.

I have the same problem. It took me ages to find that plasmashell and the
slideshow is the problem  almost ditched Kubuntu 18.04 completely.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Kelvie Wong]

https://bugs.kde.org/show_bug.cgi?id=368838

Kelvie Wong  changed:

   What|Removed |Added

 CC||kel...@ieee.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Lissanro Rahyen]

https://bugs.kde.org/show_bug.cgi?id=368838

Lissanro Rahyen  changed:

   What|Removed |Added

 CC||ma...@science.su

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368838

cdobr...@gmail.com changed:

   What|Removed |Added

 CC||cdobr...@gmail.com

--- Comment #127 from cdobr...@gmail.com ---
(In reply to Rik Mills from comment #123)
@Rik Mills @Nate Graham 

Would you please alert this thread when the fixes have made their way into the
Kubuntu 18.04 repositories. I'm waiting on updating until this fix has trickled
down, because it is crippling bad for my system.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #126 from David Edmundson  ---
*** Bug 392505 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #125 from Nate Graham  ---
Thanks Rik. I'd love to know what you hear. It would be nice to finally get
this fixed in Kubuntu once and for all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Darin Miller]

https://bugs.kde.org/show_bug.cgi?id=368838

Darin Miller  changed:

   What|Removed |Added

 CC||darinsmil...@gmail.com

--- Comment #124 from Darin Miller  ---
Memory leak still present with Kubuntu 18.04 updated as follows: 
  Plasma 5.12.5
  FW 5.44.0 
  QT 5.9.5 
  HW: Toshiba Satellite laptop, Intel graphics

Both the media frame widget and desktop background are affected.  Setting the
update interval to 10s (or less) and parking a memory widget on the desktop was
the method used for monitoring.

Note: pkill plasmashell; QSG_RENDER_LOOP=threaded kstart plasmashell also
stopped  the leak.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Rik Mills]

https://bugs.kde.org/show_bug.cgi?id=368838

Rik Mills  changed:

   What|Removed |Added

 CC||rikmi...@kubuntu.org

--- Comment #123 from Rik Mills  ---
@Nate @David

Appears the mentioned fix is in debian packaging repo for their master branch,
but not in the ubuntu/bionic branch used for Ubuntu 5.9.x uploads. At a guess,
as the launchpad bug was marked as fixed, I would guess that was an oversight,
or it was thought the fix was in 5.9.5 tars themselves.

Letting Qt guys know.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Antonio Orefice]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #122 from Antonio Orefice  ---
So, i open another one, it is simpler.
Could you guys please test? It is a plasma js script that will use all of my
memory just re-aligning folderview icons over and over
Here:
https://bugs.kde.org/show_bug.cgi?id=394436

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #121 from David Edmundson  ---
@Nate

I can't see https://codereview.qt-project.org/#/c/224684/ in the debian
packaging tarball. It's in the debian packaging git repo though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matt Whitlock]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #120 from Matt Whitlock  ---
(In reply to Ovidiu Chi from comment #117)
> > I am running a slideshow of 2560x1600 images every 2 seconds with 
> > QSG_RENDER_LOOP=basic
> 
> @Matt, You'd have to start the slideshow then, after a little while(a few
> seconds), change the duration (e.g. from 3s to 2s).

Okay, I have restarted plasmashell with QSG_RENDER_LOOP=basic QSG_INFO=1, and I
do indeed see this in the output:

qt.scenegraph.general: QSG: basic render loop

I set a slideshow at an interval of 3 seconds and started monitoring
plasmashell's memory usage and VRAM usage. It has been a few minutes, and I see
no extreme rise in memory usage. (Plasmashell, since it hosts a
garbage-collected runtime environment, does grow in memory usage for a little
while after startup until it is "warm.")

Something I forgot to mention before: I do make sure to show some tooltips in
the task switcher, pop up the applications menu, pop up the calendar, etc., to
be certain that there are some previously rendered but now hidden windows. This
was the trigger of the logic bug originally.

Now I change the slideshow interval from 3 seconds to 2 seconds. I observe no
extreme increase in plasmashell's memory usage or VRAM usage. Plasmashell's
usage still gently rises over time, due to the other leak, which is still
unaddressed, but the major VRAM leak is not present.


(In reply to David Edmundson from comment #118)
> Qt [switches] based on graphic driver. Some don't support GL use in threads.

You would think that Mesa/Gallium/RadeonSI (AMDGPU) would be modern enough for
Qt to use the threaded renderer by default, but "basic" is still the default on
my system. I am going to leave the QSG_RENDER_LOOP=threaded in my session
environment, as I experience no problems with it whatsoever.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #119 from Nate Graham  ---
Which fix is it lacking, David?

https://codereview.qt-project.org/#/c/224684/
or
https://codereview.qt-project.org/#/c/202781/?

Or both? :/

Either way, I'll go get this fixed...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #118 from David Edmundson  ---
>. I entered `QSG_INFO=1 plasmashell` in the terminal to find out the value, 
>but nothing is displayed.

You need to quit the old plasmashell beforehand.

>So it seems Kubuntu 18.04 is set to `basic` by default.

Qt swtiched based on graphic driver. Some don't support GL use in threads.


-

As for Kubuntu. Looking at
http://archive.ubuntu.com/ubuntu/pool/universe/q/qtdeclarative-opensource-src/qtdeclarative-opensource-src_5.9.5-0ubuntu1.debian.tar.xz
 from https://packages.ubuntu.com/source/bionic/qtdeclarative-opensource-src  I
do not see my patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #117 from Ovidiu Chi  ---
> I am running a slideshow of 2560x1600 images every 2 seconds with 
> QSG_RENDER_LOOP=basic

@Matt, You'd have to start the slideshow then, after a little while(a few
seconds), change the duration (e.g. from 3s to 2s).

I did some more tests.
I set `export QSG_RENDER_LOOP=threaded` in
`~/.config/plasma-workspace/env/env.sh` and logged back in.
I cannot reproduce the problem anymore. The memory either doesn't increase or
rises very little and gets freed afterwards. Everything looks stable.

I then set `export QSG_RENDER_LOOP=basic` in the same file and I could
reproduce again.
So it seems Kubuntu 18.04 is set to `basic` by default. I entered `QSG_INFO=1
plasmashell` in the terminal to find out the value, but nothing is displayed.

I don't know if the behavior is the same on all graphic cards.
If someone is able to test this out, great, otherwise it will be another tweak
I need to write down.

System details:
CPU: Intel i7-6700HQ (8) @ 3.500GHz 
GPU: Intel HD Graphics 530 
GPU: NVIDIA GeForce GTX 960M 

OpenGL renderer string: Mesa DRI Intel(R) HD Graphics 530 (Skylake GT2) 
I have not installed the Nvidia drivers.

I've set GRUB_CMDLINE_LINUX_DEFAULT="quiet splash nouveau.modeset=0" in
`/etc/default/grub` so I can log in, shut down and suspend the laptop properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matt Whitlock]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #116 from Matt Whitlock  ---
(In reply to Ovidiu Chi from comment #114)
> Matt, I'm not knowledgeable enough to say which memory leak this is, or the
> precise nature of it, but scrolling the list of widgets doesn't do much for
> my system as you can see in the first video in my comment #106. When I was
> using KDE Neon I could get the memory usage to 1GB in a few seconds by doing
> just that.

The leak demonstrated by rapidly scrolling the list of available widgets occurs
*much* more slowly on my system now than it used to. I too could previously get
plasmashell up over 1 GB in under a minute. I tried again just now and was able
to bloat it up from just under 200 MB to over 300 MB with about five minutes of
scrolling the widgets list. So it's *better* but still not totally solved.

The leak demonstrated by the slideshow is fully gone for me. I am running a
slideshow of 2560x1600 images every 2 seconds with QSG_RENDER_LOOP=basic as I
write this, and both plasmashell's memory usage and the VRAM usage (as reported
by radeontop) are remaining in a narrow range.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #115 from Ovidiu Chi  ---
(In reply to David Edmundson from comment #112)
> @Ovidiu, A packager stating something doesn't necessarily mean much. Can you
> point me to the packaging code. Also do you have
> https://codereview.qt-project.org/#/c/202781/  which is for a different leak.

David, I'm not a packager, nor a Qt/C++ dev so I couldn't point you at much
except for user facing stuff.
The link looks like a commit. If you're asking if my system has that included,
I don't know how to check precisely (I assume it would be in binary form
anyway). But you mentioned at some point it should be in Qt >= 5.9.3. Kubuntu
18.04 has 5.9.5.
I was hoping someone could reproduce what I showed in the videos, with the
known fixes applied: either switch wallpapers manually for a couple of minutes
or start a slideshow with 4k images and change from 3s to 2s in the middle of
it. Memory should increase continuously and not be released.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #114 from Ovidiu Chi  ---
(In reply to Matt Whitlock from comment #113)

Matt, I'm not knowledgeable enough to say which memory leak this is, or the
precise nature of it, but scrolling the list of widgets doesn't do much for my
system as you can see in the first video in my comment #106. When I was using
KDE Neon I could get the memory usage to 1GB in a few seconds by doing just
that.
Keep in mind that Kubuntu 18.04 has backported the Qt patch slated for release
with Qt 5.11.
As it stands, in practice, Kubuntu's memory seems fine as long as I don't test
a new wallpaper to use, or fiddle with the slideshow feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matt Whitlock]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #113 from Matt Whitlock  ---
(In reply to David Edmundson from comment #112)
> @Matt
> How can you tell what is leaking from looking at comment #0?

There have been at least two distinct memory leaks discussed in this thread.
The original report by Antonio Orefice is about a memory leak that occurs when
Plasma renders images. Antonio posted a link to a video demonstrating the leak
in Comment #59. I am able to reproduce his leak by the same method: force
Plasma to paint a lot of images in a short amount of time. It will also leak
just the same eventually in normal use, but it takes longer. The leak occurs
even without opening the "Add Widget" panel and scrolling the list up and down
like mad, but that's one quick way to reproduce it.

The other leak was due to the logic error that you described in Comment #86.
That leak has been fixed by https://codereview.qt-project.org/#/c/202781/.

> and what do you mean by an "in-process leak". All leaks are in-process.

Firstly, that's not true; it's entirely possible to leak pixmaps, and those are
in the X server's process, not the X client's. But in this case, what I meant
was that the leak that was fixed by calling endSync() was a leak of graphics
memory, not a leak of system memory, so it wasn't accounted to the plasmashell
process.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #112 from David Edmundson  ---
@Ovidiu, A packager stating something doesn't necessarily mean much. Can you
point me to the packaging code. Also do you have
https://codereview.qt-project.org/#/c/202781/  which is for a different leak.

@Matt
How can you tell what is leaking from looking at comment #0? and what do you
mean by an "in-process leak". All leaks are in-process.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Matt Whitlock]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #111 from Matt Whitlock  ---
(In reply to Ovidiu Chi from comment #110)

Plasmashell *does* still have a memory leak, but it's not the one from this
bug. Actually, it *is* the one from the original report in Comment #0, but this
thread morphed into being about the other leak, which has been fixed. The
original, in-process (non-VRAM) memory leak still exists and can be triggered
by making plasmashell repaint a lot of images, such as by aggressively
scrolling the list of available widgets.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #110 from Ovidiu Chi  ---
(In reply to Nate Graham from comment #109)

I hate to be the "bad news" guy, but this looks exactly like what you describe
- an ever growing, never-releasing memory problem.
Here is a slideshow video: https://vimeo.com/270145715

The rate of increase seems lower than before the fix, but it's there. With the
4k pics it looks like about 30MB per image switch.
Try going from 3seconds to 2seconds or vice-versa. Changing the interval at
least once seems to matter.
Three of the 4k pictures are approx. 1.5MB, the eagle is 350KB, the blue desert
is 900KB, the mountain valley is 2.7 MB.
The Ubuntu ones were in the 500KB vicinity.
The problem is not as apparent with small image files.

P.S. A few tests later, plasmashell is at 4.4GB resident memory.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #109 from Nate Graham  ---
The bug was not that plasmashell uses memory, but rather that the usage grew
infinitely and the memory was never released. In Kubuntu 18.04, I'm happily
using a slideshow wallpaper and yes, while plasmashell consumes memory in the
process, the memory usage doesn't grow infinitely and it doesn't hold onto that
memory forever like it used to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #108 from Ovidiu Chi  ---
(In reply to David Edmundson from comment #107)

> As for your video, Qt 5.11 isn't out yet, are you sure Kubuntu has it?

Kubuntu has Qt 5.9.5, with a backport of your fix as stated here:
https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1761016

But Nate is best able to answer your question.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #107 from David Edmundson  ---
>Nate, David, will the fix be backported to KDE Neon?

I don't deal with any downstreams. You'll have to ask them.

As for your video, Qt 5.11 isn't out yet, are you sure Kubuntu has it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #106 from Ovidiu Chi  ---
Thought to give an update.
I'm using Kubuntu 18.04.
The original issue reported here by Antonio seems fixed. Video here:
https://vimeo.com/270079798
The memory leak due to wallpaper changes isn't. Video here:
https://vimeo.com/270080920

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[rplanchuelo]

https://bugs.kde.org/show_bug.cgi?id=368838

rplanchu...@gmail.com  changed:

   What|Removed |Added

 CC||rplanchu...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 CC||kn...@ifi.uio.no

--- Comment #105 from David Edmundson  ---
*** Bug 377795 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Ovidiu Chi]

https://bugs.kde.org/show_bug.cgi?id=368838

Ovidiu Chi  changed:

   What|Removed |Added

 CC||metalkt...@gmail.com

--- Comment #104 from Ovidiu Chi  ---
Nate, David, will the fix be backported to KDE Neon?
I'm asking here since Neon is the showcase of KDE software.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #103 from Nate Graham  ---
See my previous comment: this has been fixed in *Qt 5.11*. Ask your distros to
backport the patch to their Qt 5.9.x and 5.10.x packages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[DeMus]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #102 from DeMus  ---
KDE 5.12.4, Frameworks 5.45.0, Qt 5.10.1.
When using the slide-show memory is filling up pretty fast.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #101 from Nate Graham  ---
Qt 5.10 is closed now, so it will be in Qt 5.11. Ask your distros to backport
it (as Kubuntu already has into the Qt 5.9.5 they'll ship with Kubuntu 18.04:
https://bugs.launchpad.net/ubuntu-rtm/+source/qtdeclarative-opensource-src/+bug/1761016).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=368838

Zakhar  changed:

   What|Removed |Added

 CC|zakhar.nasi...@gmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Erick Osorio]

https://bugs.kde.org/show_bug.cgi?id=368838

Erick Osorio  changed:

   What|Removed |Added

 CC||evgom@gmail.com

--- Comment #100 from Erick Osorio  ---
(In reply to David Edmundson from comment #89)
> Please test: https://codereview.qt-project.org/#/c/224684/

David, do will your patch be in QT 5.10?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Jason]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #99 from Jason  ---
how do I go about changing "QSG_RENDER_LOOP" to threaded? FYI, when I run from
a terminal "QSG_INFO=1 plasmashell" I get nothing back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 CC||colliso...@osu.edu

--- Comment #98 from David Edmundson  ---
*** Bug 393248 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #97 from Zakhar  ---
(In reply to Jesse from comment #95)
> I tried the patch but the memory leak bug reported in #392568, which was
> marked as a duplicated of this one, still persists for me. So either I'm
> missing something or that bug is not really a duplicated.

My bug 392668 which was also marked duplicate will likely also persist, but we
will have to see.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 CC||zakhar.nasi...@gmail.com

--- Comment #96 from David Edmundson  ---
*** Bug 392668 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #95 from Jesse  ---
I tried the patch but the memory leak bug reported in #392568, which was marked
as a duplicated of this one, still persists for me. So either I'm missing
something or that bug is not really a duplicated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #94 from David Edmundson  ---
FYI. Merged now into Qt 5.11.0. Due to be released in a few months

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 CC||alex.miha...@gmail.com

--- Comment #93 from David Edmundson  ---
*** Bug 392524 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

Nate Graham  changed:

   What|Removed |Added

URL||https://codereview.qt-proje
   ||ct.org/#/c/224684/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 CC||jesse...@gmail.com

--- Comment #92 from David Edmundson  ---
*** Bug 392568 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368838

Dr. Chapatin  changed:

   What|Removed |Added

 CC||jan.muss...@gmail.com

--- Comment #91 from Dr. Chapatin  ---
*** Bug 392599 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Hannes Schweizer]

https://bugs.kde.org/show_bug.cgi?id=368838

Hannes Schweizer  changed:

   What|Removed |Added

 CC|nilat...@gmx.net|

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Hannes Schweizer]

https://bugs.kde.org/show_bug.cgi?id=368838

Hannes Schweizer  changed:

   What|Removed |Added

 CC||nilat...@gmx.net

--- Comment #90 from Hannes Schweizer  ---
Setup:
dev-qt/qtdeclarative-5.9.4
kde-plasma/plasma-desktop-5.12.3
QSG_RENDER_LOOP unchanged
OpenGL vendor string: X.Org
OpenGL renderer string: AMD CAYMAN (DRM 2.50.0 / 4.15.4-gentoo, LLVM 5.0.1)
OpenGL core profile version string: 4.3 (Core Profile) Mesa 18.0.0

Before applying your patch a 1s interval slideshow while playing around with
plasma reproducibly led to a mem increase of rougly 50-100MB/s.
After applying the patch and restarting plasma => mem consumption looks stable
for over an hour now.

You sir, deserve a medal!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #89 from David Edmundson  ---
Please test: https://codereview.qt-project.org/#/c/224684/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #88 from Nate Graham  ---
(In reply to Gauthier from comment #87)
> Hi,
> 
> I have memory leak that occurs without having the slide-show

> So I feel this is a different issue to the one reported here

Please don't report unrelated issues in a pre-existing bug report; file a new
one instead. See
https://community.kde.org/Get_Involved/Bug_Reporting#One_issue_per_bug_report

Also, if the issue is already resolved in a later Qt version, there is no need
to report a bug at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[Gauthier]

https://bugs.kde.org/show_bug.cgi?id=368838

Gauthier  changed:

   What|Removed |Added

 CC||achat1...@free.fr

--- Comment #87 from Gauthier  ---
Hi,

I have memory leak that occurs without having the slide-show but all other bugs
on memory leak seem to be linked to this one so I'm posting here.

Since updating to plasma 5.12.x on neon LTS, a memory leak started to appear on
plasmashell. This is not happening on my other machine on neon user and both
desktop have same config (same background, widgets, etc.). Main difference
between the two is QT 5.9.3 on neon LTS whereas QT 5.10 on neon user.

So I feel this is a different issue to the one reported here, and probably
fixed by QT 5.10 and so ideally should be reported as an inconsistency in the
update to plasma 5.12 in neon LTS...but I don't know where to report this .

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #86 from David Edmundson  ---
Steps to reproduce:

 - set to QSG_RENDER_LOOP=basic
 - create a slideshow
 - open a taskmanager tooltip
 - then we leak

Tooltip is not rendered because it's not visible.
But it's re-used so still exists.
QSGGuiThreadRenderLoop::renderWindow() returns false for that window without
doing anything.
But it's still marked as updatePending, so we never think we've rendered all
the windows.

This patch in Qt will fix it; though arugably isn't quite at the right cause.

diff --git a/src/quick/scenegraph/qsgrenderloop.cpp
b/src/quick/scenegraph/qsgrenderloop.cpp
index ca1fb9ba5..51b4775f2 100644
--- a/src/quick/scenegraph/qsgrenderloop.cpp
+++ b/src/quick/scenegraph/qsgrenderloop.cpp
@@ -384,7 +384,8 @@ void QSGGuiThreadRenderLoop::renderWindow(QQuickWindow
*window)
 bool lastDirtyWindow = true;
 auto i = m_windows.constBegin();
 while (i != m_windows.constEnd()) {
-if (i.value().updatePending) {
+QQuickWindowPrivate *cd = QQuickWindowPrivate::get(i.key());
+if (i.value().updatePending && cd->isRenderable()) {
 lastDirtyWindow = false;
 break;
 }

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #85 from David Edmundson  ---
Lucky timing, just gave up and hit submit.

Had

diff --git a/src/quick/scenegraph/qsgrenderloop.cpp
b/src/quick/scenegraph/qsgrenderloop.cpp
index ca1fb9ba5..a8beac369 100644
--- a/src/quick/scenegraph/qsgrenderloop.cpp
+++ b/src/quick/scenegraph/qsgrenderloop.cpp
@@ -418,6 +418,8 @@ void QSGGuiThreadRenderLoop::renderWindow(QQuickWindow
*window)
 emit window->afterAnimating();

 cd->syncSceneGraph();
+
+qDebug() << "maybe ending sync" << lastDirtyWindow;
 if (lastDirtyWindow)
 rc->endSync();



all the while not leaking this was printing with true on the end...then
randomly just as I started doing something else I'm seeing this always false..
and it's clear from the code that at that point it stops releasing anything.

If we find the cause of that, we'll get this fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

--- Comment #84 from David Edmundson  ---
Now managed to reproduce locally...but not even slightly consistently.

Can someone who has it reliably check if reverting
eeb320bbd8763f3e72f79369cc3908e999a0da3c in QtDeclarative fixes it.

My theory from some other user's output in 381000 was that we have a situation
in plasma where Qt's basic loop always things some other window needs updates
and we never hit endSync which releases the textures; but then that theory was
drowned in confusion from people talking about other bugs and it got lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 368838] plasmashell memory leak when slideshow is used for wallpaper/media frame/photo widget with QSG_RENDER_LOOP=basic

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=368838

David Edmundson  changed:

   What|Removed |Added

Summary|plasmashell memory leak |plasmashell memory leak
   |when slideshow is used for  |when slideshow is used for
   |wallpaper/media frame/photo |wallpaper/media frame/photo
   |widget  |widget with
   ||QSG_RENDER_LOOP=basic

-- 
You are receiving this mail because:
You are watching all bug changes.