[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=375871

David Edmundson  changed:

   What|Removed |Added

   Version Fixed In||5.9.2
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/8709b7edd5d17d2
   ||369e8ca4d261ec186387fa20e
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from David Edmundson  ---
Git commit 8709b7edd5d17d2369e8ca4d261ec186387fa20e by David Edmundson.
Committed on 08/02/2017 at 15:41.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs

Summary:
A previous patch made the task manager only accept drag events which
contained URL lists or internal taskmanager mimedata in order to make it
easier to drag applets onto the panel.

This broke a feature where you can drag arbitrary mimedata between
windows and hovering above a task will raise that window.

This patch reverses the logic to only ignore plasmoids, and accept all
other drag/drops.
FIXED-IN: 5.9.2

Test Plan:
Dragged applet from Widget explorer onto task manager and the task
manager moved to
the side to allow a drop.

set sorting to manual and moved a task

Dragged some text onto a task, and that window raised immediately

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4476

M  +5-10   applets/taskmanager/package/contents/ui/MouseHandler.qml

https://commits.kde.org/plasma-desktop/8709b7edd5d17d2369e8ca4d261ec186387fa20e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=375871

--- Comment #8 from Eike Hein  ---
Possible fix: https://phabricator.kde.org/D4475

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=375871

--- Comment #7 from Eike Hein  ---
This a regression from David's c50948648012e6 which made TM intentionally
reject drags without an URL to avoid interfering with drop-on-containment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375871

--- Comment #6 from Kai Uwe Broulik  ---
I can reproduce when dragging from Ark. It just rejects the drop and Task
Manager moves out of the way to make room for dropping onto the panel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375871

--- Comment #5 from Elvis Angelaccio  ---
(In reply to Elvis Angelaccio from comment #4)
> Can you try dragging a file from Ark to Dolphin? This definitely stopped
> working since 5.9

(with Dolphin in the background)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375871

--- Comment #4 from Elvis Angelaccio  ---
Right, now that I try again seems to work from Dolphin to Dolphin or from FV to
Dolphin. Not sure what I did yesterday...

Can you try dragging a file from Ark to Dolphin? This definitely stopped
working since 5.9

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=375871

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #3 from David Edmundson  ---
Seems to works fine here: 
I have two Dolphin's drag from one into the other, and it brings the other into
the foreground for dropping.

Can you explain exactly what you're dragging.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375871

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@davidedmudnson.co.uk
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Kai Uwe Broulik  ---
Looks like a regression caused by c50948648012e66b71b757e211432190d592c90d

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375871

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
It seems to be less reliable than it used to, ie. I sometimes have to wiggle
the mouse around on the task item for the window to show up. Just entering the
task item doesn't seem to start the raise timer. It still works overall,
though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375871] Drag functionality no longer working with minimized apps

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375871

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||rthoms...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.