[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 i.Dark_Templar changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #17 from i.Dark_Templar --- Looks like it's finally fixed. Tested with plasma-workspace 5.22.5 on Gentoo. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Konrad Materka changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||7c9021ebbc6277e40e2013bda48 ||962754d6e03a4 Version Fixed In||5.22.0 --- Comment #16 from Konrad Materka --- Git commit 7c9021ebbc6277e40e2013bda48962754d6e03a4 by Konrad Materka. Committed on 07/03/2021 at 11:40. Pushed by kmaterka into branch 'master'. [SNI] Handle NewMenu signal Qt uses NewMenu signal to notify when new context menu is set. It is not part of the official standard but already used by Qt (starting from Qt 5.11). FIXED-IN: 5.22.0 M +10 -0dataengines/statusnotifieritem/statusnotifieritemsource.cpp M +1-0dataengines/statusnotifieritem/statusnotifieritemsource.h https://invent.kde.org/plasma/plasma-workspace/commit/7c9021ebbc6277e40e2013bda48962754d6e03a4 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #15 from Konrad Materka --- Git commit 628c44c1eaec0bd877c6a247a7e2c0d0c5c294d1 by Konrad Materka. Committed on 23/01/2021 at 22:07. Pushed by kmaterka into branch 'master'. Emit NewMenu when new context menu is set. When new context menu is beeing set we should notify about it. It is possible that the menu is cached on the client side and the menu items ids are the same. This signal not part of the official standard but already used by Qt (starting from Qt 5.11). M +1-0src/kstatusnotifieritem.cpp M +5-0src/kstatusnotifieritemdbus_p.h M +3-0src/org.kde.StatusNotifierItem.xml https://invent.kde.org/frameworks/knotifications/commit/628c44c1eaec0bd877c6a247a7e2c0d0c5c294d1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #14 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/594 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #13 from i.Dark_Templar --- Updated to plasma-workspace 5.20.5. Bug is still present. Attached application still reproduces issue. Linked patch still fixes issue, although it had to be rebased again. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Konrad Materka changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED --- Comment #12 from Konrad Materka --- So that I'm changing this to Confirmed. It is not entirely fault of Plasma, but Qt is the foundation of KDE so we can't just close this as upstream bug :) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #11 from Konrad Materka --- I think it is still there - Qt bug is not fixed: https://bugreports.qt.io/browse/QTBUG-79287 On KDE/Plasma side we can implement non-standard "NewMenu" signal. In addition, we should update freedesktop documentation as well: https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/ -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #10 from i.Dark_Templar --- (In reply to Nate Graham from comment #9) > Is this still happening for you in Plasma 5.20--or even better, with current > git master? A lot of fixes related to this have landed recently. I'll check it when Plasma 5.20.X gets marked stable in Gentoo amd64. Currently 5.19.5 is stable there. There's also attached test which should reproduce issue. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|CONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #9 from Nate Graham --- Is this still happening for you in Plasma 5.20--or even better, with current git master? A lot of fixes related to this have landed recently. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #8 from Konrad Materka --- I had to check :) It is not working on "pure" LXDE. LXDE has a QPA plugin, similar one as KDE has. Run your test application with: XDG_SESSION_DESKTOP=X QT_QPA_PLATFORMTHEME=X ./menubugtest You will see exactly the same results. You can also remove/move the file: /usr/lib/x86_64-linux-gnu/qt5/plugins/platformthemes/libqtlxqt.so On KDE install package "plasma-integration" (at least on *Ubuntu) at will work correctly, the same as in LXDE. It should be installed by default. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #7 from i.Dark_Templar --- I don't think it's a bug in Qt because, as I wrote in original comment, it didn't reproduce with LXQt desktop for me, and LXQt is based on Qt mostly, and my patch for KDE, while it might have downsides or things to improve, fixes this bug. I'm using KDE with linked patch since reporting this bug and it works fine for me all the time. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #6 from Konrad Materka --- Qt BUG: https://bugreports.qt.io/browse/QTBUG-79287 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Konrad Materka changed: What|Removed |Added CC||mate...@gmail.com --- Comment #5 from Konrad Materka --- The situation happens only when: * Qt QPA (plasma-integration) is not used * Tray icon menu is changed to new menu * New menu is created before change This is partially (or mostly) a Qt bug. Qt does not send any event when menu is replaced by another menu. In Qt 5.11 (and newer) on menu change Qt sends: > signal time=1571299503.727968 sender=:1.628 -> destination=(null destination) > serial=22 path=/StatusNotifierItem; interface=org.kde.StatusNotifierItem; > member=NewMenu "NewMenu" is not supported by the standard, they admit that: https://github.com/qt/qtbase/commit/ff169e8859457188f94aed86368876ba5bab2e90 In older Qt (for example 5.9 LTS) nothing is being send! Possible workarounds (for developers): * do not replace whole menu, update it (even clear if needed m_tray->contextMenu()->clear()) - good option * set mew menu, but change anything later (for example, add new action) - good option * recreate whole System Tray icon - not so great advice * use plasma-integration - bad advice, developers have no influence on that Possible workaround on KDE Plasma side: * for Qt >= 5.11: implement "NewMenu" signal - but it is not part of the standard... * Qt < 5.11: disable cache entirely - not good, breaks global menu and impacts performance Possible solution on Qt side: * send "LayoutUpdated" in addition to "NewMenu" - I will create an issue in Qt Bug tracker -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Dr. Chapatin changed: What|Removed |Added CC||yy...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 David Edmundson changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #4 from i.Dark_Templar --- Good day. I already did (and updated it a bit for modern plasma-workspace code). Please see URL. I'll duplicate it here: https://phabricator.kde.org/D7260 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #3 from David Edmundson --- Could you upload it to our code review place please. http://phabricator.kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 i.Dark_Templar changed: What|Removed |Added URL||https://phabricator.kde.org ||/D7260 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 --- Comment #2 from i.Dark_Templar --- Created attachment 107217 --> https://bugs.kde.org/attachment.cgi?id=107217&action=edit refresh-menu.patch Proposed patch, fixes issue for me. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 383202] System tray icon's context menu isn't updated properly in plasma/x11
https://bugs.kde.org/show_bug.cgi?id=383202 i.Dark_Templar changed: What|Removed |Added Version|5.34.0 |5.9.5 Target Milestone|--- |1.0 Component|general |System Tray Product|frameworks-knotifications |plasmashell --- Comment #1 from i.Dark_Templar --- Changed product and version, it looks like bug is in plasma-workspace. -- You are receiving this mail because: You are watching all bug changes.