[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=389469

Eike Hein  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-desktop/24803dc9dc4000e |sma-desktop/1e218b405bee4d7
   |06edb60a3a8afe5925f0d72d7   |5a5d26a4c28da2724d967953a

--- Comment #15 from Eike Hein  ---
Git commit 1e218b405bee4d75a5d26a4c28da2724d967953a by Eike Hein.
Committed on 22/06/2018 at 21:05.
Pushed by hein into branch 'Plasma/5.12'.

Fix tooltip woes

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.
Related: bug 382571, bug 385947, bug 388749

Reviewers: broulik, davidedmundson, romangg

Reviewed By: davidedmundson

Subscribers: rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +33   -18   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/1e218b405bee4d75a5d26a4c28da2724d967953a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=389469

--- Comment #14 from David Edmundson  ---
Git commit 1ab6ae9a8a36068294c487896dd512c693332b08 by David Edmundson.
Committed on 20/06/2018 at 07:16.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Revert "Fix tooltip woes"

This reverts commit 24803dc9dc4000e06edb60a3a8afe5925f0d72d7.

Even though this commit is perfectly sensible it seems to introduce a
crash on startup for Qt 5.10.

Will revert for now, we can revisit later
Related: bug 382571, bug 385947, bug 388749

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +11   -27   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/1ab6ae9a8a36068294c487896dd512c693332b08

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=389469

Eike Hein  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/24803dc9dc4000e
   ||06edb60a3a8afe5925f0d72d7

--- Comment #13 from Eike Hein  ---
Git commit 24803dc9dc4000e06edb60a3a8afe5925f0d72d7 by Eike Hein.
Committed on 19/06/2018 at 11:22.
Pushed by hein into branch 'Plasma/5.12'.

Fix tooltip woes

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.
Related: bug 382571, bug 385947, bug 388749

Reviewers: broulik, davidedmundson, romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +27   -11   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/24803dc9dc4000e06edb60a3a8afe5925f0d72d7

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389469

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #12 from Nate Graham  ---
Me neither, nor with Plasma 5.13 and Frameworks 5.47 (both built from source).
Let's call this fixed and re-open it if we get any other reports from later
versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=389469

--- Comment #11 from Antonio Rojas  ---
I can no longer reproduce this in 5.12.5 (Frameworks 5.46)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Papoteur]

https://bugs.kde.org/show_bug.cgi?id=389469

--- Comment #10 from Papoteur  ---
The problem is also reported here:
https://bugs.mageia.org/show_bug.cgi?id=22715

For me, I don't observe any scrash. This behavior occurs since the start of the
session.
I don't understand why the status is still unconfirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Papoteur]

https://bugs.kde.org/show_bug.cgi?id=389469

Papoteur  changed:

   What|Removed |Added

 CC||yves.brungard_mageia@gadz.o
   ||rg

--- Comment #9 from Papoteur  ---
I'm also affected by the problem.
The duplicated thumbnail has no title, no effect. It's not always the same and
can be an icon or the thumbnail of another application.
With Plasma 5.12.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[David]

https://bugs.kde.org/show_bug.cgi?id=389469

--- Comment #8 from David  ---
Small comment: sometimes it also happens without plasmashell crashing
beforehand, and also happens sometimes after kwin crashes rather than
plasmashell.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 389469] Grouped tasks have an extra thumbnail in the tooltip after plasmashell has been restarted at least once

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389469

Nate Graham  changed:

   What|Removed |Added

Summary|Grouped tasks have an extra |Grouped tasks have an extra
   |thumbnail in the tooltip|thumbnail in the tooltip
   ||after plasmashell has been
   ||restarted at least once

-- 
You are receiving this mail because:
You are watching all bug changes.