[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2019-06-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=395615

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.17.0
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/af9a794695c73e8
   ||9a7f0958bd7f071d3fec02996
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Nate Graham  ---
Git commit af9a794695c73e89a7f0958bd7f071d3fec02996 by Nate Graham.
Committed on 17/06/2019 at 13:02.
Pushed by ngraham into branch 'master'.

[Task manager] Use consistent menu items for "pin/unpin" actions

Summary:
Make the pinning-relatedmenu items consistent by showing separate Pin and Unpin
menu
items when not using activities. When using activities, it's unavoidable, so we
still
show a more complicated UI there with checkboxes for the per-activity pinning
options.
FIXED-IN: 5.17.0

Test Plan:
Right-click on pinned launchers, open unpinned tasks, and open pinned tasks -
see that all have the correct menu items

Do it again with mode than one Activity and see that all is still well

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21856

M  +5-4applets/taskmanager/package/contents/ui/ContextMenu.qml

https://commits.kde.org/plasma-desktop/af9a794695c73e89a7f0958bd7f071d3fec02996

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2019-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=395615

--- Comment #3 from Nate Graham  ---
Here's a patch: https://phabricator.kde.org/D21856

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2019-06-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=395615

Patrick Silva  changed:

   What|Removed |Added

Version|5.15.4  |5.16.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2019-04-29 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=395615

Patrick Silva  changed:

   What|Removed |Added

Version|5.14.90 |5.15.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2019-01-17 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=395615

Patrick Silva  changed:

   What|Removed |Added

Version|5.13.1  |5.14.90

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2018-06-27 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=395615

Eike Hein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Eike Hein  ---
Yeah, we should consistify this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2018-06-27 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=395615

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
It has a checkbox next to it, so this is correct. It's somewhat inconsistent
with launchers, though, that use a separate "Unpin" action.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395615] Context menu from an entry in the task manager shows "pin" instead "unpin" when the app is already pinned

2018-06-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=395615

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.