[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #16 from martc...@gmx.net ---
Thanks for the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

David Edmundson  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from David Edmundson  ---

davidedmundson wrote:
> @bug_id = 404335
> @bug_status = RESOLVED
> @resolution = FIXED
> @cf_commitlink = 
> https://invent.kde.org/plasma/plasma-workspace/commit/8475fe4545998c806704a45a7d912f777a11533f
>
> Git commit 8475fe4545998c806704a45a7d912f777a11533f by David Edmundson.
> Committed on 30/06/2020 at 10:59.
> Pushed by davidedmundson into branch 'master'.
>
> Only spawn dbus-run-session if there isn't a session already
>
> Typically on modern systems this will be started for us earlier in the
> startup series and we don't have to worry about it.
>
> For X11 clients look for the bus address on the X11 root window as a way
> of sharing.
>
> For reasons at the time we start our own DBus session within our wayland
> session. Nesting causes conflicts and problems so this patch only start
> a dbus session if one has not been set up already.
>
> M  +1-1login-sessions/plasmawayland-dev.desktop.cmake
> M  +1-1login-sessions/plasmawayland.desktop.cmake
> M  +1-0startkde/CMakeLists.txt
> A  +10   -0startkde/plasma-dbus-run-session-if-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=404335

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #14 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/128

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #13 from David Edmundson  ---
Those setups don't get wayland anyway, but it's certainly the easiest path to
resolving the bug, so I'll make an updated patch doing that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #12 from Fabian Vogt  ---
(In reply to David Edmundson from comment #11)
> >There's simply no alternative. That seems to be the consensus on 
> >https://github.com/bus1/dbus-broker/issues/145 as well.
> 
> Ack, but I've personally changed my mind about whether it's our
> responsibility to do any kind of fallback.
> (https://phabricator.kde.org/D19004)
> 
> dbus-broker and dbus-daemon are both socket activated. On all good setups it
> will "just work". 
>
> It was just a hack for an old Ubuntu at the time, but that's no longer the
> case.

Unless on X11, where a property is changed on the root window,
DBUS_SESSION_BUS_ADDRESS has to be set in the environment to have a common
session bus. So unless DBus is explicitly started by a parent process in one
way or another, this is actually not enough AFAICT.

With systemd, pam_systemd takes care of that I think, but what is on systems
where this isn't the case, like without systemd or on FreeBSD, where DBus is an
"afterthought"?

The method of only using dbus-run-session if DBUS_SESSION_BUS_ADDRESS is unset
seems the safest.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #11 from David Edmundson  ---
>There's simply no alternative. That seems to be the consensus on 
>https://github.com/bus1/dbus-broker/issues/145 as well.

Ack, but I've personally changed my mind about whether it's our responsibility
to do any kind of fallback.
(https://phabricator.kde.org/D19004)

dbus-broker and dbus-daemon are both socket activated. On all good setups it
will "just work". 
It was just a hack for an old Ubuntu at the time, but that's no longer the
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-06-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=404335

Fabian Vogt  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #10 from Fabian Vogt  ---
What might work is to have a wrapper around dbus-run-session which only starts
a session bus if necessary, e.g.:

drs=
[ -n "${DBUS_SESSION_BUS_ADDRESS}" ] || drs=dbus-run-session
exec ${drs} "$@"

Maybe this could be added to startplasma-wayland itself.

What is unavoidable though is the use of dbus-run-session to start the bus if
it's not there yet.
There's simply no alternative. That seems to be the consensus on
https://github.com/bus1/dbus-broker/issues/145 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2020-05-25 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404335

martc...@gmx.net changed:

   What|Removed |Added

 CC||martc...@gmx.net

--- Comment #9 from martc...@gmx.net ---
I would like to point out that even with the regular D-Bus implementation using
`dbus-run-session` causes problems. This is at least the case under
systemd-based distributions where the D-Bus processes (including the session
D-Bus) are started via systemd.

I've explained it in further detail in this Arch Linux issue:
https://bugs.archlinux.org/task/66766

The main problem is that `org.freedesktop.systemd1` is not available this way
preventing software relying on it to work, e.g.
https://github.com/Martchus/syncthingtray#required-system-configuration.

In my opinion starting the session D-Bus and starting the graphical environment
should not be coupled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-10-01 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #8 from Ardith Metz  ---
Gnome 3.34 adopted systemd for start/manage session:
https://blogs.gnome.org/benzea/2019/10/01/gnome-3-34-is-now-managed-using-systemd/

I hope KDE join it some day. I saw some effort in
https://github.com/KDE/plasma-systemd-integration but it stalled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-26 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=404335

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-19 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #7 from David Edmundson  ---
Yes, that's why this bug is still open.

That doesn't mean I'm just going to naively replace one bug for another.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-19 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #6 from Ardith Metz  ---
(In reply to David Edmundson from comment #5)
> We absolutely cannot do that as a strict dependency.

Then don't and simply assume that system has dbus already started which is true
for most if not all distros. The current approach is described as
detrimental[1]

https://github.com/bus1/dbus-broker/issues/145#issuecomment-398727176

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #5 from David Edmundson  ---
We absolutely cannot do that as a strict dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-18 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #4 from Ardith Metz  ---
(In reply to David Edmundson from comment #3)
> That's true only if one has dbus socket activated.

Switching plasma session to run as systemd user service would allow to create
dependency on dbus.socket service.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=404335

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #3 from David Edmundson  ---
>but it's also possible to just omit dbus-run-session command and run 
>/usr/bin/startplasmacompositor directly.

That's true only if one has dbus socket activated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-10 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #2 from Ardith Metz  ---
The issue is not about that you should rely on dbus-broker but about that you
shouldn't rely on dbus-daemon and be agnostic of whatever dbus implementation
is used. In other words prepare for that dbus-run-session won't exist on system
anymore. dbus-broker maintainers gave you same ideas what to do but it's also
possible to just omit dbus-run-session command and run
/usr/bin/startplasmacompositor directly.

I assume that at the time "Ubuntu LTS supported dbus-broker for at least two
years" the vast majority of distros will already migrate to dbus-broker so
unless the goal is to make KDE wayland session an Ubuntu LTS only thing you
would better to reconsider this. Fedora 30 is expected in May 2019.

No, you don't have to thank me for this heads-up at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-03-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=404335

--- Comment #1 from Christoph Feck  ---
I am tempted to close this, and ask for a notification once Ubuntu LTS
supported dbus-broker for at least two years.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404335] Don't rely on dbus-run-session or dbus-launch for starting plasma-wayland session

2019-02-14 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=404335

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.